fix(vault): Treat tokens expiring in <60s as expired by agunnerson-elastic · Pull Request #3637 · external-secrets/external-secrets

agunnerson-elastic · 2024-06-28T15:42:35Z

Problem Statement

Without this, it's possible to hit a TOCTOU issue where checkToken() sees a valid token, but it expires before the actual operation is performed. This condition is only reachable when the experimental caching feature is enabled.

60 seconds was chosen as a sane (but arbitrary) value. It should be more than enough to cover the amount of time between checkToken() and the actual operation.

Related Issue

(None reported)

Proposed Changes

Treat close-to-expiring tokens as if they were expired already.

Checklist

I have read the contribution guidelines
All commits are signed with git commit --signoff
My changes have reasonable test coverage
All tests pass with make test
I ensured my PR is ready for review with make reviewable

agunnerson-elastic · 2024-06-28T15:43:52Z

Per #3598 (comment), I've also added Elastic to ADOPTERS.md.

Regarding make reviewable, it's currently failing with:

pkg/controllers/externalsecret/externalsecret_controller.go:296:53: directive `//nolint:exhaustive` is unused for linter "exhaustive" (nolintlint)
        switch externalSecret.Spec.Target.CreationPolicy { //nolint:exhaustive
                                                           ^
golangci-lint failed: some checks can be fixed with `make fmt`

but this wasn't something changed in this PR. Any ideas what might be causing it?

ADOPTERS.md

pkg/provider/vault/auth.go

gusfcarvalho · 2024-06-28T16:04:39Z

hi @agunnerson-elastic ! Thanks for your contribution. Just some questions regarding a case where users set token-based Auth for ESO. because caching is a feature that affects all vault SecretStores, I can see a case where ESO is configured with caching, but there are token-based connections regardless.

IIRC those tokens are not batch, and they do not expire 😄

agunnerson-elastic · 2024-06-28T17:03:11Z

Hey @gusfcarvalho, thanks for reviewing! I'll test out non-expiring tokens and check whether the ttl field is present.

EDIT: Commented in the thread above.

gusfcarvalho · 2024-07-01T15:08:17Z

Just put another comment. I'll put e2e tests to run, although I don't think we test for experimental cache..

gusfcarvalho · 2024-07-01T15:08:55Z

The error you're seeing might be from a version drift on golangci-lint - no issues on our runs 🤔

gusfcarvalho · 2024-07-01T15:09:06Z

/ok-to-test sha=67571cf

pkg/provider/vault/auth.go

Without this, it's possible to hit a TOCTOU issue where checkToken() sees a valid token, but it expires before the actual operation is performed. This condition is only reachable when the experimental caching feature is enabled. 60 seconds was chosen as a sane (but arbitrary) value. It should be more than enough to cover the amount of time between checkToken() and the actual operation. Signed-off-by: Andrew Gunnerson <andrew.gunnerson@elastic.co>

Signed-off-by: Andrew Gunnerson <andrew.gunnerson@elastic.co>

gusfcarvalho · 2024-07-02T08:35:30Z

LGTM :) Just want to use this PR for a latest e2e test pipeline bump lol 😄 hope you dont mind

gusfcarvalho · 2024-07-02T08:35:47Z

/ok-to-test sha=b8ca004

gusfcarvalho · 2024-07-02T14:18:59Z

/ok-to-test sha=b8ca0040200a7a05d57048d86a972fdf833b8c9b

…s#3637) * fix(vault): Treat tokens expiring in <60s as expired Without this, it's possible to hit a TOCTOU issue where checkToken() sees a valid token, but it expires before the actual operation is performed. This condition is only reachable when the experimental caching feature is enabled. 60 seconds was chosen as a sane (but arbitrary) value. It should be more than enough to cover the amount of time between checkToken() and the actual operation. Signed-off-by: Andrew Gunnerson <andrew.gunnerson@elastic.co> * ADOPTERS.md: Add Elastic Signed-off-by: Andrew Gunnerson <andrew.gunnerson@elastic.co> --------- Signed-off-by: Andrew Gunnerson <andrew.gunnerson@elastic.co> Signed-off-by: Felipe Hernandez <fhernandez@beyondtrust.com>

Signed-off-by: Felipe Hernandez <fhernandez@beyondtrust.com> feat: run make reviewable Signed-off-by: Felipe Hernandez <fhernandez@beyondtrust.com> feat: solving PR comments Signed-off-by: Felipe Hernandez <fhernandez@beyondtrust.com> fix: fix files conflicts Signed-off-by: Felipe Hernandez <fhernandez@beyondtrust.com> fix(vault): Treat tokens expiring in <60s as expired (external-secrets#3637) * fix(vault): Treat tokens expiring in <60s as expired Without this, it's possible to hit a TOCTOU issue where checkToken() sees a valid token, but it expires before the actual operation is performed. This condition is only reachable when the experimental caching feature is enabled. 60 seconds was chosen as a sane (but arbitrary) value. It should be more than enough to cover the amount of time between checkToken() and the actual operation. Signed-off-by: Andrew Gunnerson <andrew.gunnerson@elastic.co> * ADOPTERS.md: Add Elastic Signed-off-by: Andrew Gunnerson <andrew.gunnerson@elastic.co> --------- Signed-off-by: Andrew Gunnerson <andrew.gunnerson@elastic.co> Signed-off-by: Felipe Hernandez <fhernandez@beyondtrust.com> Allow specifying the same namespace for SecretStores (external-secrets#3555) * Allow specifying the same namespace for SecretStores Signed-off-by: shuheiktgw <s-kitagawa@mercari.com> * Fix unit tests Signed-off-by: shuheiktgw <s-kitagawa@mercari.com> --------- Signed-off-by: shuheiktgw <s-kitagawa@mercari.com> Signed-off-by: Felipe Hernandez <fhernandez@beyondtrust.com> docs: add proposal for PushSecret metadata (external-secrets#3612) * docs: add proposal for PushSecret metadata Signed-off-by: Moritz Johner <beller.moritz@googlemail.com> * docs: add examples for aws sm/ps Signed-off-by: Moritz Johner <beller.moritz@googlemail.com> * docs: add note regarding old format Signed-off-by: Moritz Johner <beller.moritz@googlemail.com> --------- Signed-off-by: Moritz Johner <beller.moritz@googlemail.com> Signed-off-by: Felipe Hernandez <fhernandez@beyondtrust.com> fix github credentials (external-secrets#3656) Signed-off-by: Gustavo Carvalho <gustavo.carvalho@productmadness.com> Signed-off-by: Felipe Hernandez <fhernandez@beyondtrust.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://github.com/external-secrets/external-secrets) | patch | `0.9.19` -> `0.9.20` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.9.20`](https://github.com/external-secrets/external-secrets/releases/tag/v0.9.20) [Compare Source](external-secrets/external-secrets@v0.9.19...v0.9.20) Image: `ghcr.io/external-secrets/external-secrets:v0.9.20` Image: `ghcr.io/external-secrets/external-secrets:v0.9.20-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.9.20-ubi-boringssl` #### What's Changed - bump 0.9.19 by [@knelasevero](https://github.com/knelasevero) in external-secrets/external-secrets#3553 - Fix typo: temaplate --> template by [@lindhe](https://github.com/lindhe) in external-secrets/external-secrets#3554 - Oracle Vault Provider Documentation by [@anders-swanson](https://github.com/anders-swanson) in external-secrets/external-secrets#3551 - feat: add location to GCP push secret by [@Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#3502 - add log.level and log.encoding to all components by [@KyriosGN0](https://github.com/KyriosGN0) in external-secrets/external-secrets#3558 - chore(deps): bump github/codeql-action from 3.25.7 to 3.25.8 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3561 - chore(deps): bump aquasecurity/trivy-action from 0.21.0 to 0.22.0 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3562 - chore(deps): bump tornado from 6.4 to 6.4.1 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3563 - chore(deps): bump packaging from 24.0 to 24.1 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3564 - chore(deps): bump mkdocs-material from 9.5.25 to 9.5.26 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3565 - chore(deps): bump zipp from 3.19.1 to 3.19.2 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3566 - chore(deps): bump ubi8/ubi-minimal from `9e458f4` to `5f1cd34` by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3568 - chore(deps): bump golang from 1.22.3-bookworm to 1.22.4-bookworm in /e2e by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3569 - chore(deps): bump golang from 1.22.3 to 1.22.4 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3567 - Infisical provider by [@akhilmhdh](https://github.com/akhilmhdh) in external-secrets/external-secrets#3477 - feat: kick github actions on main by [@Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#3572 - feat: add support to set Type for AWS parameter store by [@vsantos](https://github.com/vsantos) in external-secrets/external-secrets#3576 - Remove shuheiktgw from maintainers by [@shuheiktgw](https://github.com/shuheiktgw) in external-secrets/external-secrets#3573 - Add device42 provider by [@smcavallo](https://github.com/smcavallo) in external-secrets/external-secrets#3571 - ref: parameter store should be called only once by [@Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#3584 - chore: update dependencies by [@eso-service-account-app](https://github.com/eso-service-account-app) in external-secrets/external-secrets#3570 - feat(certcontroller): Allow restricting CRDs and Webhook configs in Informer cache by [@toVersus](https://github.com/toVersus) in external-secrets/external-secrets#3588 - Support glob for namespaces condition in ClusterSecretStore by [@speedfl](https://github.com/speedfl) in external-secrets/external-secrets#2920 - Fix typo privatKey in multiple files by [@IdanAdar](https://github.com/IdanAdar) in external-secrets/external-secrets#3578 - chore(deps): bump mkdocs-material from 9.5.26 to 9.5.27 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3595 - chore(deps): bump github/codeql-action from 3.25.8 to 3.25.10 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3591 - chore(deps): bump codecov/codecov-action from 4.4.1 to 4.5.0 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3592 - chore(deps): bump actions/checkout from 4.1.6 to 4.1.7 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3590 - chore: update dependencies by [@eso-service-account-app](https://github.com/eso-service-account-app) in external-secrets/external-secrets#3596 - chore(deps): bump golang from `aec4784` to `9678844` in /e2e by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3593 - chore(deps): bump golang from `9bdd569` to `6522f0c` by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3594 - feat(chart): Enable partial cache for certcontroller when installCRDs=true by [@toVersus](https://github.com/toVersus) in external-secrets/external-secrets#3589 - Add skip unmanaged store logic for push secret controller by [@Bude8](https://github.com/Bude8) in external-secrets/external-secrets#3123 - fix(vault): Fix crash when caching is enabled and a token expires by [@agunnerson-elastic](https://github.com/agunnerson-elastic) in external-secrets/external-secrets#3598 - Remove the use of "golang.org/x/crypto/pkcs12" by [@yihuaf](https://github.com/yihuaf) in external-secrets/external-secrets#3601 - Make UBI more tolerable from OS vulnerabilities by [@IdanAdar](https://github.com/IdanAdar) in external-secrets/external-secrets#3607 - fix: explicitly fetch status subresource due to inconsistencies by [@moolen](https://github.com/moolen) in external-secrets/external-secrets#3608 - Adds codepath for removing finalizers by [@lllamnyp](https://github.com/lllamnyp) in external-secrets/external-secrets#3610 - chore: update dependencies by [@eso-service-account-app](https://github.com/eso-service-account-app) in external-secrets/external-secrets#3624 - chore(deps): bump alpine from 3.20.0 to 3.20.1 in /e2e by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3622 - chore(deps): bump alpine from `77726ef` to `b89d9c9` in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3621 - chore(deps): bump golang from `6522f0c` to `ace6cc3` by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3620 - chore(deps): bump urllib3 from 2.2.1 to 2.2.2 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3618 - chore(deps): bump importlib-metadata from 7.1.0 to 7.2.1 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3617 - chore(deps): bump livereload from 2.6.3 to 2.7.0 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3616 - chore(deps): bump aquasecurity/trivy-action from 0.22.0 to 0.23.0 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3615 - chore(deps): bump softprops/action-gh-release from 2.0.5 to 2.0.6 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3614 - Fix ACR External Secret example by [@ellenfieldn](https://github.com/ellenfieldn) in external-secrets/external-secrets#3626 - feat: add bitwarden secret manager support by [@Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#3603 - fix: e2e installation of ESO needs to update dependencies first by [@Skarlso](https://github.com/Skarlso) in external-secrets/external-secrets#3635 - added secretserver env vars to e2e.yml by [@pacificcode](https://github.com/pacificcode) in external-secrets/external-secrets#3636 - docs: fix dataFrom.find in ExternalSecret api example by [@sboschman](https://github.com/sboschman) in external-secrets/external-secrets#3633 - chore: update dependencies by [@eso-service-account-app](https://github.com/eso-service-account-app) in external-secrets/external-secrets#3641 - chore(deps): bump github/codeql-action from 3.25.10 to 3.25.11 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3640 - chore(deps): bump importlib-metadata from 7.2.1 to 8.0.0 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3639 - add AuthRef to kubernetes provider fixes [#3627](external-secrets/external-secrets#3627) by [@kaedwen](https://github.com/kaedwen) in external-secrets/external-secrets#3628 - fix: implement handling for pushing whole k8s secret to gcsm by [@thejosephstevens](https://github.com/thejosephstevens) in external-secrets/external-secrets#3644 - bump e2e pipeline by [@gusfcarvalho](https://github.com/gusfcarvalho) in external-secrets/external-secrets#3646 - fix e2e permissions by [@gusfcarvalho](https://github.com/gusfcarvalho) in external-secrets/external-secrets#3647 - bump docs with e2e commands by [@gusfcarvalho](https://github.com/gusfcarvalho) in external-secrets/external-secrets#3648 - also needs pull-requests by [@gusfcarvalho](https://github.com/gusfcarvalho) in external-secrets/external-secrets#3649 - use github token to allow comment by [@gusfcarvalho](https://github.com/gusfcarvalho) in external-secrets/external-secrets#3651 - fix(webhook): perform conversion of data by [@cardoe](https://github.com/cardoe) in external-secrets/external-secrets#3638 - feat: implement pushing whole k8s secret to Azure Keyvault by [@CCOLLOT](https://github.com/CCOLLOT) in external-secrets/external-secrets#3650 - fix(vault): Treat tokens expiring in <60s as expired by [@agunnerson-elastic](https://github.com/agunnerson-elastic) in external-secrets/external-secrets#3637 - Allow specifying the same namespace for SecretStores by [@shuheiktgw](https://github.com/shuheiktgw) in external-secrets/external-secrets#3555 - docs: add proposal for PushSecret metadata by [@moolen](https://github.com/moolen) in external-secrets/external-secrets#3612 - fix github credentials by [@gusfcarvalho](https://github.com/gusfcarvalho) in external-secrets/external-secrets#3656 - docs: updated k8s support for ESO v0.9 by [@shazib-summar](https://github.com/shazib-summar) in external-secrets/external-secrets#3659 #### New Contributors - [@lindhe](https://github.com/lindhe) made their first contribution in external-secrets/external-secrets#3554 - [@KyriosGN0](https://github.com/KyriosGN0) made their first contribution in external-secrets/external-secrets#3558 - [@akhilmhdh](https://github.com/akhilmhdh) made their first contribution in external-secrets/external-secrets#3477 - [@smcavallo](https://github.com/smcavallo) made their first contribution in external-secrets/external-secrets#3571 - [@toVersus](https://github.com/toVersus) made their first contribution in external-secrets/external-secrets#3588 - [@speedfl](https://github.com/speedfl) made their first contribution in external-secrets/external-secrets#2920 - [@Bude8](https://github.com/Bude8) made their first contribution in external-secrets/external-secrets#3123 - [@agunnerson-elastic](https://github.com/agunnerson-elastic) made their first contribution in external-secrets/external-secrets#3598 - [@yihuaf](https://github.com/yihuaf) made their first contribution in external-secrets/external-secrets#3601 - [@lllamnyp](https://github.com/lllamnyp) made their first contribution in external-secrets/external-secrets#3610 - [@ellenfieldn](https://github.com/ellenfieldn) made their first contribution in external-secrets/external-secrets#3626 - [@pacificcode](https://github.com/pacificcode) made their first contribution in external-secrets/external-secrets#3636 - [@sboschman](https://github.com/sboschman) made their first contribution in external-secrets/external-secrets#3633 - [@kaedwen](https://github.com/kaedwen) made their first contribution in external-secrets/external-secrets#3628 - [@thejosephstevens](https://github.com/thejosephstevens) made their first contribution in external-secrets/external-secrets#3644 - [@cardoe](https://github.com/cardoe) made their first contribution in external-secrets/external-secrets#3638 - [@CCOLLOT](https://github.com/CCOLLOT) made their first contribution in external-secrets/external-secrets#3650 - [@shazib-summar](https://github.com/shazib-summar) made their first contribution in external-secrets/external-secrets#3659 **Full Changelog**: external-secrets/external-secrets@v0.9.19...v0.9.20 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.internal/nrdufour/home-ops/pulls/478 Co-authored-by: Renovate <renovate@ptinem.casa> Co-committed-by: Renovate <renovate@ptinem.casa>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [external-secrets](https://togithub.com/external-secrets/external-secrets) | HelmChart | minor | `0.9.19` -> `0.10.2` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.10.2`](https://togithub.com/external-secrets/external-secrets/releases/tag/v0.10.2) [Compare Source](https://togithub.com/external-secrets/external-secrets/compare/v0.10.1...v0.10.2) Image: `ghcr.io/external-secrets/external-secrets:v0.10.2` Image: `ghcr.io/external-secrets/external-secrets:v0.10.2-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.10.2-ubi-boringssl` #### What's Changed - release: update helm charts to version v0.10.1 by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3842](https://togithub.com/external-secrets/external-secrets/pull/3842) - fix: add watch to validatingwebhookconfigs by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3845](https://togithub.com/external-secrets/external-secrets/pull/3845) **Full Changelog**: https://github.com/external-secrets/external-secrets/compare/v0.10.1...v0.10.2 ### [`v0.10.1`](https://togithub.com/external-secrets/external-secrets/releases/tag/v0.10.1) [Compare Source](https://togithub.com/external-secrets/external-secrets/compare/v0.10.0...v0.10.1) Image: `ghcr.io/external-secrets/external-secrets:v0.10.1` Image: `ghcr.io/external-secrets/external-secrets:v0.10.1-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.10.1-ubi-boringssl` #### What's Changed - release: update helm chart to v0.10.0 by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3758](https://togithub.com/external-secrets/external-secrets/pull/3758) - doc: add maintainer of the bitwarden secret manager provider by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3762](https://togithub.com/external-secrets/external-secrets/pull/3762) - chore(deps): bump mkdocs-material from 9.5.30 to 9.5.31 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3763](https://togithub.com/external-secrets/external-secrets/pull/3763) - fix: decrypt remote parameter for SecureString type by [@vsantos](https://togithub.com/vsantos) in [https://github.com/external-secrets/external-secrets/pull/3761](https://togithub.com/external-secrets/external-secrets/pull/3761) - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3766](https://togithub.com/external-secrets/external-secrets/pull/3766) - chore(deps): bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3765](https://togithub.com/external-secrets/external-secrets/pull/3765) - chore(deps): bump docker/setup-buildx-action from 3.5.0 to 3.6.1 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3764](https://togithub.com/external-secrets/external-secrets/pull/3764) - feat: add beyondtrust provider by [@btfhernandez](https://togithub.com/btfhernandez) in [https://github.com/external-secrets/external-secrets/pull/3683](https://togithub.com/external-secrets/external-secrets/pull/3683) - chore: add minimal policy for fetching parameters from ssm by [@KrisJohnstone](https://togithub.com/KrisJohnstone) in [https://github.com/external-secrets/external-secrets/pull/3770](https://togithub.com/external-secrets/external-secrets/pull/3770) - Add Grafana Labs to ADOPTERS.md by [@Duologic](https://togithub.com/Duologic) in [https://github.com/external-secrets/external-secrets/pull/3787](https://togithub.com/external-secrets/external-secrets/pull/3787) - chore(deps): bump golang from 1.22.5 to 1.22.6 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3778](https://togithub.com/external-secrets/external-secrets/pull/3778) - chore(deps): bump pyyaml from 6.0.1 to 6.0.2 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3779](https://togithub.com/external-secrets/external-secrets/pull/3779) - chore(deps): bump zipp from 3.19.2 to 3.20.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3780](https://togithub.com/external-secrets/external-secrets/pull/3780) - chore(deps): bump babel from 2.15.0 to 2.16.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3781](https://togithub.com/external-secrets/external-secrets/pull/3781) - chore(deps): bump golang from 1.22.5-bookworm to 1.22.6-bookworm in /e2e by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3783](https://togithub.com/external-secrets/external-secrets/pull/3783) - chore(deps): bump github/codeql-action from 3.25.15 to 3.26.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3784](https://togithub.com/external-secrets/external-secrets/pull/3784) - chore(deps): bump fossas/fossa-action from 1.3.3 to 1.4.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3785](https://togithub.com/external-secrets/external-secrets/pull/3785) - chore(deps): bump watchdog from 4.0.1 to 4.0.2 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3782](https://togithub.com/external-secrets/external-secrets/pull/3782) - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3786](https://togithub.com/external-secrets/external-secrets/pull/3786) - chore: update security best practice by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3794](https://togithub.com/external-secrets/external-secrets/pull/3794) - feat: add CAProvider to Bitwarden provider by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3699](https://togithub.com/external-secrets/external-secrets/pull/3699) - fix: run helm.test.update on main branch by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3816](https://togithub.com/external-secrets/external-secrets/pull/3816) - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3815](https://togithub.com/external-secrets/external-secrets/pull/3815) - chore(deps): bump importlib-resources from 6.4.0 to 6.4.3 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3810](https://togithub.com/external-secrets/external-secrets/pull/3810) - chore(deps): bump markdown from 3.6 to 3.7 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3811](https://togithub.com/external-secrets/external-secrets/pull/3811) - Bump helm-docs image version to v1.7.0 in Makefile by [@PrateekKumar1709](https://togithub.com/PrateekKumar1709) in [https://github.com/external-secrets/external-secrets/pull/3806](https://togithub.com/external-secrets/external-secrets/pull/3806) - chore(deps): bump github/codeql-action from 3.26.0 to 3.26.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3812](https://togithub.com/external-secrets/external-secrets/pull/3812) - chore(deps): bump golang from 1.22.6-bookworm to 1.23.0-bookworm in /e2e by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3813](https://togithub.com/external-secrets/external-secrets/pull/3813) - chore: update go version of the project to 1.23 by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3829](https://togithub.com/external-secrets/external-secrets/pull/3829) - Use maps package from standard library by [@BooleanCat](https://togithub.com/BooleanCat) in [https://github.com/external-secrets/external-secrets/pull/3828](https://togithub.com/external-secrets/external-secrets/pull/3828) - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3836](https://togithub.com/external-secrets/external-secrets/pull/3836) - add the resourceNames(git commit -s) by [@younaman](https://togithub.com/younaman) in [https://github.com/external-secrets/external-secrets/pull/3822](https://togithub.com/external-secrets/external-secrets/pull/3822) - chore(deps): bump mkdocs-material from 9.5.31 to 9.5.33 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3830](https://togithub.com/external-secrets/external-secrets/pull/3830) - chore(deps): bump importlib-metadata from 8.2.0 to 8.4.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3831](https://togithub.com/external-secrets/external-secrets/pull/3831) - chore(deps): bump paginate from 0.5.6 to 0.5.7 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3832](https://togithub.com/external-secrets/external-secrets/pull/3832) - chore(deps): bump golang from 1.22.6 to 1.23.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3814](https://togithub.com/external-secrets/external-secrets/pull/3814) - chore(deps): bump github/codeql-action from 3.26.2 to 3.26.5 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3835](https://togithub.com/external-secrets/external-secrets/pull/3835) - chore(deps): bump idna from 3.7 to 3.8 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3834](https://togithub.com/external-secrets/external-secrets/pull/3834) - chore(deps): bump importlib-resources from 6.4.3 to 6.4.4 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3833](https://togithub.com/external-secrets/external-secrets/pull/3833) - feat: implement GetSecretMap for Bitwarden provider by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3800](https://togithub.com/external-secrets/external-secrets/pull/3800) - Demonstrate new slices/maps packages by [@BooleanCat](https://togithub.com/BooleanCat) in [https://github.com/external-secrets/external-secrets/pull/3839](https://togithub.com/external-secrets/external-secrets/pull/3839) #### New Contributors - [@btfhernandez](https://togithub.com/btfhernandez) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3683](https://togithub.com/external-secrets/external-secrets/pull/3683) - [@KrisJohnstone](https://togithub.com/KrisJohnstone) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3770](https://togithub.com/external-secrets/external-secrets/pull/3770) - [@PrateekKumar1709](https://togithub.com/PrateekKumar1709) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3806](https://togithub.com/external-secrets/external-secrets/pull/3806) - [@BooleanCat](https://togithub.com/BooleanCat) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3828](https://togithub.com/external-secrets/external-secrets/pull/3828) - [@younaman](https://togithub.com/younaman) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3822](https://togithub.com/external-secrets/external-secrets/pull/3822) **Full Changelog**: https://github.com/external-secrets/external-secrets/compare/v0.10.0...v0.10.1 ### [`v0.10.0`](https://togithub.com/external-secrets/external-secrets/releases/tag/v0.10.0) [Compare Source](https://togithub.com/external-secrets/external-secrets/compare/v0.9.20...v0.10.0) :warning: :red-alert: BREAKING CHANGE :red-alert: :warning: - Webhook Generator Webhook generator labels have changed from `generators.external-secrets.io/type: webhook` to `external-secrets.io/type: webhook`. - Webhook Provider Webhook provider now can only use secrets that are labeled with `external-secrets.io/type: webhook`. This enforces explicit setup for webhook secrets by users. ##### Fixing the issue: add the label for the secret used by the webhook: apiVersion: v1 kind: Secret metadata: name: your-secret labels: external-secrets.io/type: webhook ### <<<<<<<<<<<<< ADD THIS data: ... Image: `ghcr.io/external-secrets/external-secrets:v0.10.0` Image: `ghcr.io/external-secrets/external-secrets:v0.10.0-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.10.0-ubi-boringssl` #### What's Changed - chore: bump to 0.9.20 by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3660](https://togithub.com/external-secrets/external-secrets/pull/3660) - chore(deps): bump golang from 1.22.4 to 1.22.5 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3662](https://togithub.com/external-secrets/external-secrets/pull/3662) - chore(deps): bump distroless/static from `4197211` to `ce46866` by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3663](https://togithub.com/external-secrets/external-secrets/pull/3663) - chore(deps): bump docker/setup-buildx-action from 3.3.0 to 3.4.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3665](https://togithub.com/external-secrets/external-secrets/pull/3665) - chore(deps): bump docker/setup-qemu-action from 3.0.0 to 3.1.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3666](https://togithub.com/external-secrets/external-secrets/pull/3666) - chore(deps): bump mkdocs-material from 9.5.27 to 9.5.28 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3667](https://togithub.com/external-secrets/external-secrets/pull/3667) - chore(deps): bump certifi from 2024.6.2 to 2024.7.4 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3668](https://togithub.com/external-secrets/external-secrets/pull/3668) - chore(deps): bump golang from 1.22.4-bookworm to 1.22.5-bookworm in /e2e by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3669](https://togithub.com/external-secrets/external-secrets/pull/3669) - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3670](https://togithub.com/external-secrets/external-secrets/pull/3670) - sets eso-service-account for creating e2e comments by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3678](https://togithub.com/external-secrets/external-secrets/pull/3678) - use github token for the actions check by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3679](https://togithub.com/external-secrets/external-secrets/pull/3679) - Add support for Delinea Secret Server by [@pacificcode](https://togithub.com/pacificcode) in [https://github.com/external-secrets/external-secrets/pull/3468](https://togithub.com/external-secrets/external-secrets/pull/3468) - Fix: Only URL encode data being passed to URLs ([#3652](https://togithub.com/external-secrets/external-secrets/issues/3652)) by [@ryanmeans](https://togithub.com/ryanmeans) in [https://github.com/external-secrets/external-secrets/pull/3674](https://togithub.com/external-secrets/external-secrets/pull/3674) - Commenting secrets manifest from hashicorp vault integration [#3661](https://togithub.com/external-secrets/external-secrets/issues/3661) by [@jeffmachado](https://togithub.com/jeffmachado) in [https://github.com/external-secrets/external-secrets/pull/3680](https://togithub.com/external-secrets/external-secrets/pull/3680) - docs: Fix `namespaceRegexes` in full-cluster-secret-store.yaml by [@excalq](https://togithub.com/excalq) in [https://github.com/external-secrets/external-secrets/pull/3681](https://togithub.com/external-secrets/external-secrets/pull/3681) - Support for Oracle PushSecret.property [#2911](https://togithub.com/external-secrets/external-secrets/issues/2911) by [@Aeyk](https://togithub.com/Aeyk) in [https://github.com/external-secrets/external-secrets/pull/3577](https://togithub.com/external-secrets/external-secrets/pull/3577) - support for adding headers in vault provider by [@abhinav1708](https://togithub.com/abhinav1708) in [https://github.com/external-secrets/external-secrets/pull/3677](https://togithub.com/external-secrets/external-secrets/pull/3677) - chore(deps): bump github/codeql-action from 3.25.11 to 3.25.12 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3688](https://togithub.com/external-secrets/external-secrets/pull/3688) - chore(deps): bump actions/setup-go from 5.0.1 to 5.0.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3691](https://togithub.com/external-secrets/external-secrets/pull/3691) - chore(deps): bump actions/setup-python from 5.1.0 to 5.1.1 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3690](https://togithub.com/external-secrets/external-secrets/pull/3690) - chore(deps): bump aquasecurity/trivy-action from 0.23.0 to 0.24.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3689](https://togithub.com/external-secrets/external-secrets/pull/3689) - chore(deps): bump golang from `8c9183f` to `8c9183f` by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3687](https://togithub.com/external-secrets/external-secrets/pull/3687) - chore(deps): bump mkdocs-material from 9.5.28 to 9.5.29 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3692](https://togithub.com/external-secrets/external-secrets/pull/3692) - fix: aws secretmanager's SecretExists returns true for non-existent secrets by [@mintbomb27](https://togithub.com/mintbomb27) in [https://github.com/external-secrets/external-secrets/pull/3684](https://togithub.com/external-secrets/external-secrets/pull/3684) - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3693](https://togithub.com/external-secrets/external-secrets/pull/3693) - Added 2 articles I wrote on AWS secrets injection and ESO templating by [@alinadir44](https://togithub.com/alinadir44) in [https://github.com/external-secrets/external-secrets/pull/3707](https://togithub.com/external-secrets/external-secrets/pull/3707) - Update docs for namespaceSelectors usage and namespaceSelector deprecation by [@mtougeron](https://togithub.com/mtougeron) in [https://github.com/external-secrets/external-secrets/pull/3695](https://togithub.com/external-secrets/external-secrets/pull/3695) - fix: add namespace to path and route construction by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3632](https://togithub.com/external-secrets/external-secrets/pull/3632) - chore(deps): bump softprops/action-gh-release from 2.0.6 to 2.0.8 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3708](https://togithub.com/external-secrets/external-secrets/pull/3708) - chore(deps): bump github/codeql-action from 3.25.12 to 3.25.13 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3709](https://togithub.com/external-secrets/external-secrets/pull/3709) - Update bitwarden-secrets-manager.md by [@zazathomas](https://togithub.com/zazathomas) in [https://github.com/external-secrets/external-secrets/pull/3710](https://togithub.com/external-secrets/external-secrets/pull/3710) - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3711](https://togithub.com/external-secrets/external-secrets/pull/3711) - feat: add `PushSecret` support for Pulumi ESC by [@dirien](https://togithub.com/dirien) in [https://github.com/external-secrets/external-secrets/pull/3597](https://togithub.com/external-secrets/external-secrets/pull/3597) - remove redundant parameter grab call, we already have the data by [@rumenvasilev](https://togithub.com/rumenvasilev) in [https://github.com/external-secrets/external-secrets/pull/3722](https://togithub.com/external-secrets/external-secrets/pull/3722) - chore(deps): bump docker/login-action from 3.2.0 to 3.3.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3729](https://togithub.com/external-secrets/external-secrets/pull/3729) - chore(deps): bump ossf/scorecard-action from 2.3.3 to 2.4.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3727](https://togithub.com/external-secrets/external-secrets/pull/3727) - chore(deps): bump docker/setup-buildx-action from 3.4.0 to 3.5.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3728](https://togithub.com/external-secrets/external-secrets/pull/3728) - chore(deps): bump docker/setup-qemu-action from 3.1.0 to 3.2.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3731](https://togithub.com/external-secrets/external-secrets/pull/3731) - chore(deps): bump github/codeql-action from 3.25.13 to 3.25.15 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3730](https://togithub.com/external-secrets/external-secrets/pull/3730) - chore(deps): bump alpine from `77726ef` to `0a4eaa0` by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3733](https://togithub.com/external-secrets/external-secrets/pull/3733) - chore(deps): bump golang from `8c9183f` to `0d3653d` by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3732](https://togithub.com/external-secrets/external-secrets/pull/3732) - feat: increase verbosity of error message during validation by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3742](https://togithub.com/external-secrets/external-secrets/pull/3742) - chore(deps): bump golang from `6c27802` to `af9b40f` in /e2e by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3734](https://togithub.com/external-secrets/external-secrets/pull/3734) - chore(deps): bump alpine from 3.20.1 to 3.20.2 in /e2e by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3735](https://togithub.com/external-secrets/external-secrets/pull/3735) - chore(deps): bump alpine from `b89d9c9` to `0a4eaa0` in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3736](https://togithub.com/external-secrets/external-secrets/pull/3736) - chore(deps): bump regex from 2024.5.15 to 2024.7.24 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3737](https://togithub.com/external-secrets/external-secrets/pull/3737) - chore(deps): bump mkdocs-material from 9.5.29 to 9.5.30 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3738](https://togithub.com/external-secrets/external-secrets/pull/3738) - chore(deps): bump importlib-metadata from 8.0.0 to 8.2.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3739](https://togithub.com/external-secrets/external-secrets/pull/3739) - chore(deps): bump pymdown-extensions from 10.8.1 to 10.9 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3740](https://togithub.com/external-secrets/external-secrets/pull/3740) - docs: Remove references to pemCertificate and pemPrivateKey functions by [@trenslow](https://togithub.com/trenslow) in [https://github.com/external-secrets/external-secrets/pull/3744](https://togithub.com/external-secrets/external-secrets/pull/3744) - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3741](https://togithub.com/external-secrets/external-secrets/pull/3741) - docs: Improvements in the ExternalSecret comments in API section by [@c-neto](https://togithub.com/c-neto) in [https://github.com/external-secrets/external-secrets/pull/3725](https://togithub.com/external-secrets/external-secrets/pull/3725) - feat: add prefix definition to all secret keys for aws parameter store by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3718](https://togithub.com/external-secrets/external-secrets/pull/3718) - feat: do not modify the secret in case of a NotModified by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3746](https://togithub.com/external-secrets/external-secrets/pull/3746) - feat: webhook secrets must be labeled by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3753](https://togithub.com/external-secrets/external-secrets/pull/3753) - feat: support pkcs12 with chain in pushsecret to Azure KeyVault by [@mysteq](https://togithub.com/mysteq) in [https://github.com/external-secrets/external-secrets/pull/3747](https://togithub.com/external-secrets/external-secrets/pull/3747) - docs: document fullPemToPkcs12 and fullPemToPkcs12Pass helper functions by [@mysteq](https://togithub.com/mysteq) in [https://github.com/external-secrets/external-secrets/pull/3749](https://togithub.com/external-secrets/external-secrets/pull/3749) #### New Contributors - [@ryanmeans](https://togithub.com/ryanmeans) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3674](https://togithub.com/external-secrets/external-secrets/pull/3674) - [@jeffmachado](https://togithub.com/jeffmachado) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3680](https://togithub.com/external-secrets/external-secrets/pull/3680) - [@excalq](https://togithub.com/excalq) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3681](https://togithub.com/external-secrets/external-secrets/pull/3681) - [@Aeyk](https://togithub.com/Aeyk) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3577](https://togithub.com/external-secrets/external-secrets/pull/3577) - [@abhinav1708](https://togithub.com/abhinav1708) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3677](https://togithub.com/external-secrets/external-secrets/pull/3677) - [@mintbomb27](https://togithub.com/mintbomb27) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3684](https://togithub.com/external-secrets/external-secrets/pull/3684) - [@alinadir44](https://togithub.com/alinadir44) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3707](https://togithub.com/external-secrets/external-secrets/pull/3707) - [@mtougeron](https://togithub.com/mtougeron) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3695](https://togithub.com/external-secrets/external-secrets/pull/3695) - [@zazathomas](https://togithub.com/zazathomas) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3710](https://togithub.com/external-secrets/external-secrets/pull/3710) - [@rumenvasilev](https://togithub.com/rumenvasilev) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3722](https://togithub.com/external-secrets/external-secrets/pull/3722) - [@trenslow](https://togithub.com/trenslow) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3744](https://togithub.com/external-secrets/external-secrets/pull/3744) - [@c-neto](https://togithub.com/c-neto) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3725](https://togithub.com/external-secrets/external-secrets/pull/3725) - [@mysteq](https://togithub.com/mysteq) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3747](https://togithub.com/external-secrets/external-secrets/pull/3747) **Full Changelog**: https://github.com/external-secrets/external-secrets/compare/v0.9.20...v0.10.0 ### [`v0.9.20`](https://togithub.com/external-secrets/external-secrets/releases/tag/v0.9.20) [Compare Source](https://togithub.com/external-secrets/external-secrets/compare/v0.9.19...v0.9.20) Image: `ghcr.io/external-secrets/external-secrets:v0.9.20` Image: `ghcr.io/external-secrets/external-secrets:v0.9.20-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.9.20-ubi-boringssl` #### What's Changed - bump 0.9.19 by [@knelasevero](https://togithub.com/knelasevero) in [https://github.com/external-secrets/external-secrets/pull/3553](https://togithub.com/external-secrets/external-secrets/pull/3553) - Fix typo: temaplate --> template by [@lindhe](https://togithub.com/lindhe) in [https://github.com/external-secrets/external-secrets/pull/3554](https://togithub.com/external-secrets/external-secrets/pull/3554) - Oracle Vault Provider Documentation by [@anders-swanson](https://togithub.com/anders-swanson) in [https://github.com/external-secrets/external-secrets/pull/3551](https://togithub.com/external-secrets/external-secrets/pull/3551) - feat: add location to GCP push secret by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3502](https://togithub.com/external-secrets/external-secrets/pull/3502) - add log.level and log.encoding to all components by [@KyriosGN0](https://togithub.com/KyriosGN0) in [https://github.com/external-secrets/external-secrets/pull/3558](https://togithub.com/external-secrets/external-secrets/pull/3558) - chore(deps): bump github/codeql-action from 3.25.7 to 3.25.8 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3561](https://togithub.com/external-secrets/external-secrets/pull/3561) - chore(deps): bump aquasecurity/trivy-action from 0.21.0 to 0.22.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3562](https://togithub.com/external-secrets/external-secrets/pull/3562) - chore(deps): bump tornado from 6.4 to 6.4.1 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3563](https://togithub.com/external-secrets/external-secrets/pull/3563) - chore(deps): bump packaging from 24.0 to 24.1 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3564](https://togithub.com/external-secrets/external-secrets/pull/3564) - chore(deps): bump mkdocs-material from 9.5.25 to 9.5.26 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3565](https://togithub.com/external-secrets/external-secrets/pull/3565) - chore(deps): bump zipp from 3.19.1 to 3.19.2 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3566](https://togithub.com/external-secrets/external-secrets/pull/3566) - chore(deps): bump ubi8/ubi-minimal from `9e458f4` to `5f1cd34` by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3568](https://togithub.com/external-secrets/external-secrets/pull/3568) - chore(deps): bump golang from 1.22.3-bookworm to 1.22.4-bookworm in /e2e by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3569](https://togithub.com/external-secrets/external-secrets/pull/3569) - chore(deps): bump golang from 1.22.3 to 1.22.4 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3567](https://togithub.com/external-secrets/external-secrets/pull/3567) - Infisical provider by [@akhilmhdh](https://togithub.com/akhilmhdh) in [https://github.com/external-secrets/external-secrets/pull/3477](https://togithub.com/external-secrets/external-secrets/pull/3477) - feat: kick github actions on main by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3572](https://togithub.com/external-secrets/external-secrets/pull/3572) - feat: add support to set Type for AWS parameter store by [@vsantos](https://togithub.com/vsantos) in [https://github.com/external-secrets/external-secrets/pull/3576](https://togithub.com/external-secrets/external-secrets/pull/3576) - Remove shuheiktgw from maintainers by [@shuheiktgw](https://togithub.com/shuheiktgw) in [https://github.com/external-secrets/external-secrets/pull/3573](https://togithub.com/external-secrets/external-secrets/pull/3573) - Add device42 provider by [@smcavallo](https://togithub.com/smcavallo) in [https://github.com/external-secrets/external-secrets/pull/3571](https://togithub.com/external-secrets/external-secrets/pull/3571) - ref: parameter store should be called only once by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3584](https://togithub.com/external-secrets/external-secrets/pull/3584) - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3570](https://togithub.com/external-secrets/external-secrets/pull/3570) - feat(certcontroller): Allow restricting CRDs and Webhook configs in Informer cache by [@toVersus](https://togithub.com/toVersus) in [https://github.com/external-secrets/external-secrets/pull/3588](https://togithub.com/external-secrets/external-secrets/pull/3588) - Support glob for namespaces condition in ClusterSecretStore by [@speedfl](https://togithub.com/speedfl) in [https://github.com/external-secrets/external-secrets/pull/2920](https://togithub.com/external-secrets/external-secrets/pull/2920) - Fix typo privatKey in multiple files by [@IdanAdar](https://togithub.com/IdanAdar) in [https://github.com/external-secrets/external-secrets/pull/3578](https://togithub.com/external-secrets/external-secrets/pull/3578) - chore(deps): bump mkdocs-material from 9.5.26 to 9.5.27 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3595](https://togithub.com/external-secrets/external-secrets/pull/3595) - chore(deps): bump github/codeql-action from 3.25.8 to 3.25.10 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3591](https://togithub.com/external-secrets/external-secrets/pull/3591) - chore(deps): bump codecov/codecov-action from 4.4.1 to 4.5.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3592](https://togithub.com/external-secrets/external-secrets/pull/3592) - chore(deps): bump actions/checkout from 4.1.6 to 4.1.7 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3590](https://togithub.com/external-secrets/external-secrets/pull/3590) - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3596](https://togithub.com/external-secrets/external-secrets/pull/3596) - chore(deps): bump golang from `aec4784` to `9678844` in /e2e by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3593](https://togithub.com/external-secrets/external-secrets/pull/3593) - chore(deps): bump golang from `9bdd569` to `6522f0c` by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3594](https://togithub.com/external-secrets/external-secrets/pull/3594) - feat(chart): Enable partial cache for certcontroller when installCRDs=true by [@toVersus](https://togithub.com/toVersus) in [https://github.com/external-secrets/external-secrets/pull/3589](https://togithub.com/external-secrets/external-secrets/pull/3589) - Add skip unmanaged store logic for push secret controller by [@Bude8](https://togithub.com/Bude8) in [https://github.com/external-secrets/external-secrets/pull/3123](https://togithub.com/external-secrets/external-secrets/pull/3123) - fix(vault): Fix crash when caching is enabled and a token expires by [@agunnerson-elastic](https://togithub.com/agunnerson-elastic) in [https://github.com/external-secrets/external-secrets/pull/3598](https://togithub.com/external-secrets/external-secrets/pull/3598) - Remove the use of "golang.org/x/crypto/pkcs12" by [@yihuaf](https://togithub.com/yihuaf) in [https://github.com/external-secrets/external-secrets/pull/3601](https://togithub.com/external-secrets/external-secrets/pull/3601) - Make UBI more tolerable from OS vulnerabilities by [@IdanAdar](https://togithub.com/IdanAdar) in [https://github.com/external-secrets/external-secrets/pull/3607](https://togithub.com/external-secrets/external-secrets/pull/3607) - fix: explicitly fetch status subresource due to inconsistencies by [@moolen](https://togithub.com/moolen) in [https://github.com/external-secrets/external-secrets/pull/3608](https://togithub.com/external-secrets/external-secrets/pull/3608) - Adds codepath for removing finalizers by [@lllamnyp](https://togithub.com/lllamnyp) in [https://github.com/external-secrets/external-secrets/pull/3610](https://togithub.com/external-secrets/external-secrets/pull/3610) - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3624](https://togithub.com/external-secrets/external-secrets/pull/3624) - chore(deps): bump alpine from 3.20.0 to 3.20.1 in /e2e by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3622](https://togithub.com/external-secrets/external-secrets/pull/3622) - chore(deps): bump alpine from `77726ef` to `b89d9c9` in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3621](https://togithub.com/external-secrets/external-secrets/pull/3621) - chore(deps): bump golang from `6522f0c` to `ace6cc3` by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3620](https://togithub.com/external-secrets/external-secrets/pull/3620) - chore(deps): bump urllib3 from 2.2.1 to 2.2.2 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3618](https://togithub.com/external-secrets/external-secrets/pull/3618) - chore(deps): bump importlib-metadata from 7.1.0 to 7.2.1 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3617](https://togithub.com/external-secrets/external-secrets/pull/3617) - chore(deps): bump livereload from 2.6.3 to 2.7.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3616](https://togithub.com/external-secrets/external-secrets/pull/3616) - chore(deps): bump aquasecurity/trivy-action from 0.22.0 to 0.23.0 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3615](https://togithub.com/external-secrets/external-secrets/pull/3615) - chore(deps): bump softprops/action-gh-release from 2.0.5 to 2.0.6 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3614](https://togithub.com/external-secrets/external-secrets/pull/3614) - Fix ACR External Secret example by [@ellenfieldn](https://togithub.com/ellenfieldn) in [https://github.com/external-secrets/external-secrets/pull/3626](https://togithub.com/external-secrets/external-secrets/pull/3626) - feat: add bitwarden secret manager support by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3603](https://togithub.com/external-secrets/external-secrets/pull/3603) - fix: e2e installation of ESO needs to update dependencies first by [@Skarlso](https://togithub.com/Skarlso) in [https://github.com/external-secrets/external-secrets/pull/3635](https://togithub.com/external-secrets/external-secrets/pull/3635) - added secretserver env vars to e2e.yml by [@pacificcode](https://togithub.com/pacificcode) in [https://github.com/external-secrets/external-secrets/pull/3636](https://togithub.com/external-secrets/external-secrets/pull/3636) - docs: fix dataFrom.find in ExternalSecret api example by [@sboschman](https://togithub.com/sboschman) in [https://github.com/external-secrets/external-secrets/pull/3633](https://togithub.com/external-secrets/external-secrets/pull/3633) - chore: update dependencies by [@eso-service-account-app](https://togithub.com/eso-service-account-app) in [https://github.com/external-secrets/external-secrets/pull/3641](https://togithub.com/external-secrets/external-secrets/pull/3641) - chore(deps): bump github/codeql-action from 3.25.10 to 3.25.11 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3640](https://togithub.com/external-secrets/external-secrets/pull/3640) - chore(deps): bump importlib-metadata from 7.2.1 to 8.0.0 in /hack/api-docs by [@dependabot](https://togithub.com/dependabot) in [https://github.com/external-secrets/external-secrets/pull/3639](https://togithub.com/external-secrets/external-secrets/pull/3639) - add AuthRef to kubernetes provider fixes [#3627](https://togithub.com/external-secrets/external-secrets/issues/3627) by [@kaedwen](https://togithub.com/kaedwen) in [https://github.com/external-secrets/external-secrets/pull/3628](https://togithub.com/external-secrets/external-secrets/pull/3628) - fix: implement handling for pushing whole k8s secret to gcsm by [@thejosephstevens](https://togithub.com/thejosephstevens) in [https://github.com/external-secrets/external-secrets/pull/3644](https://togithub.com/external-secrets/external-secrets/pull/3644) - bump e2e pipeline by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3646](https://togithub.com/external-secrets/external-secrets/pull/3646) - fix e2e permissions by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3647](https://togithub.com/external-secrets/external-secrets/pull/3647) - bump docs with e2e commands by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3648](https://togithub.com/external-secrets/external-secrets/pull/3648) - also needs pull-requests by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3649](https://togithub.com/external-secrets/external-secrets/pull/3649) - use github token to allow comment by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3651](https://togithub.com/external-secrets/external-secrets/pull/3651) - fix(webhook): perform conversion of data by [@cardoe](https://togithub.com/cardoe) in [https://github.com/external-secrets/external-secrets/pull/3638](https://togithub.com/external-secrets/external-secrets/pull/3638) - feat: implement pushing whole k8s secret to Azure Keyvault by [@CCOLLOT](https://togithub.com/CCOLLOT) in [https://github.com/external-secrets/external-secrets/pull/3650](https://togithub.com/external-secrets/external-secrets/pull/3650) - fix(vault): Treat tokens expiring in <60s as expired by [@agunnerson-elastic](https://togithub.com/agunnerson-elastic) in [https://github.com/external-secrets/external-secrets/pull/3637](https://togithub.com/external-secrets/external-secrets/pull/3637) - Allow specifying the same namespace for SecretStores by [@shuheiktgw](https://togithub.com/shuheiktgw) in [https://github.com/external-secrets/external-secrets/pull/3555](https://togithub.com/external-secrets/external-secrets/pull/3555) - docs: add proposal for PushSecret metadata by [@moolen](https://togithub.com/moolen) in [https://github.com/external-secrets/external-secrets/pull/3612](https://togithub.com/external-secrets/external-secrets/pull/3612) - fix github credentials by [@gusfcarvalho](https://togithub.com/gusfcarvalho) in [https://github.com/external-secrets/external-secrets/pull/3656](https://togithub.com/external-secrets/external-secrets/pull/3656) - docs: updated k8s support for ESO v0.9 by [@shazib-summar](https://togithub.com/shazib-summar) in [https://github.com/external-secrets/external-secrets/pull/3659](https://togithub.com/external-secrets/external-secrets/pull/3659) #### New Contributors - [@lindhe](https://togithub.com/lindhe) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3554](https://togithub.com/external-secrets/external-secrets/pull/3554) - [@KyriosGN0](https://togithub.com/KyriosGN0) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3558](https://togithub.com/external-secrets/external-secrets/pull/3558) - [@akhilmhdh](https://togithub.com/akhilmhdh) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3477](https://togithub.com/external-secrets/external-secrets/pull/3477) - [@smcavallo](https://togithub.com/smcavallo) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3571](https://togithub.com/external-secrets/external-secrets/pull/3571) - [@toVersus](https://togithub.com/toVersus) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3588](https://togithub.com/external-secrets/external-secrets/pull/3588) - [@speedfl](https://togithub.com/speedfl) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/2920](https://togithub.com/external-secrets/external-secrets/pull/2920) - [@Bude8](https://togithub.com/Bude8) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3123](https://togithub.com/external-secrets/external-secrets/pull/3123) - [@agunnerson-elastic](https://togithub.com/agunnerson-elastic) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3598](https://togithub.com/external-secrets/external-secrets/pull/3598) - [@yihuaf](https://togithub.com/yihuaf) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3601](https://togithub.com/external-secrets/external-secrets/pull/3601) - [@lllamnyp](https://togithub.com/lllamnyp) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3610](https://togithub.com/external-secrets/external-secrets/pull/3610) - [@ellenfieldn](https://togithub.com/ellenfieldn) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3626](https://togithub.com/external-secrets/external-secrets/pull/3626) - [@pacificcode](https://togithub.com/pacificcode) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3636](https://togithub.com/external-secrets/external-secrets/pull/3636) - [@sboschman](https://togithub.com/sboschman) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3633](https://togithub.com/external-secrets/external-secrets/pull/3633) - [@kaedwen](https://togithub.com/kaedwen) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3628](https://togithub.com/external-secrets/external-secrets/pull/3628) - [@thejosephstevens](https://togithub.com/thejosephstevens) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3644](https://togithub.com/external-secrets/external-secrets/pull/3644) - [@cardoe](https://togithub.com/cardoe) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3638](https://togithub.com/external-secrets/external-secrets/pull/3638) - [@CCOLLOT](https://togithub.com/CCOLLOT) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3650](https://togithub.com/external-secrets/external-secrets/pull/3650) - [@shazib-summar](https://togithub.com/shazib-summar) made their first contribution in [https://github.com/external-secrets/external-secrets/pull/3659](https://togithub.com/external-secrets/external-secrets/pull/3659) **Full Changelog**: https://github.com/external-secrets/external-secrets/compare/v0.9.19...v0.9.20 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: Renovate Bot <renovate@whitesourcesoftware.com>

This fixes a regression introduced in external-secrets#3637 where non-expiring tokens were always treated as expired because their TTL is always 0. This situation can be easily detected by checking for a null `expire_time` value, which only happens for non-expiring tokens. Signed-off-by: Andrew Gunnerson <andrew.gunnerson@elastic.co>

agunnerson-elastic requested a review from a team as a code owner June 28, 2024 15:42

agunnerson-elastic requested a review from sebagomez June 28, 2024 15:42

gusfcarvalho reviewed Jun 28, 2024

View reviewed changes

ADOPTERS.md Show resolved Hide resolved

gusfcarvalho reviewed Jun 28, 2024

View reviewed changes

pkg/provider/vault/auth.go Show resolved Hide resolved

gusfcarvalho reviewed Jul 1, 2024

View reviewed changes

pkg/provider/vault/auth.go Show resolved Hide resolved

agunnerson-elastic force-pushed the vault-cache-expiring-tokens branch from 67571cf to 834b8be Compare July 1, 2024 21:26

agunnerson-elastic added 2 commits July 1, 2024 17:52

ADOPTERS.md: Add Elastic

b8ca004

Signed-off-by: Andrew Gunnerson <andrew.gunnerson@elastic.co>

agunnerson-elastic force-pushed the vault-cache-expiring-tokens branch from 834b8be to b8ca004 Compare July 1, 2024 21:55

gusfcarvalho approved these changes Jul 2, 2024

View reviewed changes

gusfcarvalho merged commit 2053df7 into external-secrets:main Jul 3, 2024

agunnerson-elastic deleted the vault-cache-expiring-tokens branch July 8, 2024 16:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(vault): Treat tokens expiring in <60s as expired#3637

fix(vault): Treat tokens expiring in <60s as expired#3637
gusfcarvalho merged 2 commits intoexternal-secrets:mainfrom
agunnerson-elastic:vault-cache-expiring-tokens

agunnerson-elastic commented Jun 28, 2024

Uh oh!

agunnerson-elastic commented Jun 28, 2024

Uh oh!

Uh oh!

Uh oh!

gusfcarvalho commented Jun 28, 2024

Uh oh!

agunnerson-elastic commented Jun 28, 2024 •

edited

Loading

Uh oh!

gusfcarvalho commented Jul 1, 2024

Uh oh!

gusfcarvalho commented Jul 1, 2024

Uh oh!

gusfcarvalho commented Jul 1, 2024

Uh oh!

Uh oh!

gusfcarvalho commented Jul 2, 2024

Uh oh!

gusfcarvalho commented Jul 2, 2024

Uh oh!

gusfcarvalho commented Jul 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

agunnerson-elastic commented Jun 28, 2024

Problem Statement

Related Issue

Proposed Changes

Checklist

Uh oh!

agunnerson-elastic commented Jun 28, 2024

Uh oh!

Uh oh!

Uh oh!

gusfcarvalho commented Jun 28, 2024

Uh oh!

agunnerson-elastic commented Jun 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gusfcarvalho commented Jul 1, 2024

Uh oh!

gusfcarvalho commented Jul 1, 2024

Uh oh!

gusfcarvalho commented Jul 1, 2024

Uh oh!

Uh oh!

gusfcarvalho commented Jul 2, 2024

Uh oh!

gusfcarvalho commented Jul 2, 2024

Uh oh!

gusfcarvalho commented Jul 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

agunnerson-elastic commented Jun 28, 2024 •

edited

Loading