Fix flaky ES controller test by shuheiktgw · Pull Request #3493 · external-secrets/external-secrets

shuheiktgw · 2024-05-14T00:52:00Z

Problem Statement

Since we merged #3459, the checkDeletion test case has become flaky. (ref) I dug into it and realized since we started using the cache client from the controller, the controller received a deleted secret here after reconciliation starts due to the secret deletion. To tackle the problem, I've disabled the cache client for secrets and config maps as we do in the actual environment. One good new is since we use the non-cache client for those resources, we can shorten the timeout from 20 seconds to 10 seconds.

Related Issue

N/A

Proposed Changes

The description above says it all.

Checklist

I have read the contribution guidelines
All commits are signed with git commit --signoff
My changes have reasonable test coverage
All tests pass with make test
I ensured my PR is ready for review with make reviewable

Signed-off-by: shuheiktgw <s-kitagawa@mercari.com>

sonarqubecloud · 2024-05-14T00:52:38Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Signed-off-by: shuheiktgw <s-kitagawa@mercari.com>

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://github.com/external-secrets/external-secrets) | patch | `0.9.18` -> `0.9.19` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.9.19`](https://github.com/external-secrets/external-secrets/releases/tag/v0.9.19) [Compare Source](external-secrets/external-secrets@v0.9.18...v0.9.19) Image: `ghcr.io/external-secrets/external-secrets:v0.9.19` Image: `ghcr.io/external-secrets/external-secrets:v0.9.19-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.9.19-ubi-boringssl` #### What's Changed - bump 0.9.18 by [@gusfcarvalho](https://github.com/gusfcarvalho) in external-secrets/external-secrets#3492 - Fix flaky ES controller test by [@shuheiktgw](https://github.com/shuheiktgw) in external-secrets/external-secrets#3493 - Raise error when unknown key specified in template by [@shuheiktgw](https://github.com/shuheiktgw) in external-secrets/external-secrets#3480 - Update ci.yml with ppc64le arch support by [@IdanAdar](https://github.com/IdanAdar) in external-secrets/external-secrets#3500 - chore(deps): bump regex from 2024.5.10 to 2024.5.15 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3512 - chore(deps): bump zipp from 3.18.1 to 3.18.2 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3511 - chore(deps): bump platformdirs from 4.2.1 to 4.2.2 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3510 - chore(deps): bump golang from `6d71b7c` to `5c56bd4` in /e2e by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3508 - chore(deps): bump github/codeql-action from 3.25.4 to 3.25.5 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3507 - chore(deps): bump codecov/codecov-action from 4.3.1 to 4.4.0 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3506 - chore(deps): bump actions/checkout from 4.1.5 to 4.1.6 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3505 - chore(deps): bump golangci/golangci-lint-action from 5.3.0 to 6.0.1 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3504 - chore(deps): bump golang from `2a88224` to `f1fe698` by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3503 - chore(deps): bump mkdocs-material from 9.5.22 to 9.5.23 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3509 - chore: update dependencies by [@eso-service-account-app](https://github.com/eso-service-account-app) in external-secrets/external-secrets#3513 - ppc64le additions by [@IdanAdar](https://github.com/IdanAdar) in external-secrets/external-secrets#3535 - chore(deps): bump ubi8/ubi-minimal from `2fa47fa` to `f729a7f` by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3523 - doc(BitWarden): extends the liveness timeout by [@acolombier](https://github.com/acolombier) in external-secrets/external-secrets#3542 - chore(deps): bump mkdocs-material from 9.5.23 to 9.5.24 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3526 - chore(deps): bump zipp from 3.18.2 to 3.19.0 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3527 - chore(deps): bump requests from 2.31.0 to 2.32.2 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3528 - chore(deps): bump codecov/codecov-action from 4.4.0 to 4.4.1 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3530 - chore(deps): bump aquasecurity/trivy-action from 0.20.0 to 0.21.0 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3531 - chore(deps): bump github/codeql-action from 3.25.5 to 3.25.6 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3532 - chore(deps): bump ubi8/ubi-minimal from `f729a7f` to `9e458f4` by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3543 - chore(deps): bump golang from `f1fe698` to `b8ded51` by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3522 - chore(deps): bump alpine from 3.19.1 to 3.20.0 in /e2e by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3525 - chore(deps): bump watchdog from 4.0.0 to 4.0.1 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3529 - chore(deps): bump alpine from 3.19 to 3.20 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3533 - chore: update dependencies by [@eso-service-account-app](https://github.com/eso-service-account-app) in external-secrets/external-secrets#3534 - Fix: ESO template crash when Kubernetes secret data is nil by [@ma-ble](https://github.com/ma-ble) in external-secrets/external-secrets#3537 - chore(deps): bump alpine from `c5b1261` to `77726ef` by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3524 - Add CA-Bundle to pemToPkcs12 output by [@WatcherWhale](https://github.com/WatcherWhale) in external-secrets/external-secrets#3494 - chore(deps): bump docker/login-action from 3.1.0 to 3.2.0 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3544 - chore(deps): bump github/codeql-action from 3.25.6 to 3.25.7 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3545 - chore(deps): bump certifi from 2024.2.2 to 2024.6.2 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3546 - chore(deps): bump mkdocs-material from 9.5.24 to 9.5.25 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3547 - chore(deps): bump zipp from 3.19.0 to 3.19.1 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3549 - chore(deps): bump requests from 2.32.2 to 2.32.3 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3548 - chore: update dependencies by [@eso-service-account-app](https://github.com/eso-service-account-app) in external-secrets/external-secrets#3550 #### New Contributors - [@acolombier](https://github.com/acolombier) made their first contribution in external-secrets/external-secrets#3542 - [@ma-ble](https://github.com/ma-ble) made their first contribution in external-secrets/external-secrets#3537 **Full Changelog**: external-secrets/external-secrets@v0.9.18...v0.9.19 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.internal/nrdufour/home-ops/pulls/471 Co-authored-by: Renovate <renovate@ptinem.casa> Co-committed-by: Renovate <renovate@ptinem.casa>

Signed-off-by: shuheiktgw <s-kitagawa@mercari.com> Signed-off-by: Bude8 <henryblee8@gmail.com>

Signed-off-by: shuheiktgw <s-kitagawa@mercari.com> Signed-off-by: Bill Hamilton <bill.hamilton@delinea.com>

Fix flaky ES controller test

faac2b9

Signed-off-by: shuheiktgw <s-kitagawa@mercari.com>

shuheiktgw requested a review from a team as a code owner May 14, 2024 00:52

shuheiktgw requested a review from moolen May 14, 2024 00:52

gusfcarvalho approved these changes May 14, 2024

View reviewed changes

gusfcarvalho merged commit 4779457 into main May 14, 2024

gusfcarvalho deleted the fix_flaky_es_test branch May 14, 2024 15:43

default23 pushed a commit to default23/external-secrets that referenced this pull request May 17, 2024

Fix flaky ES controller test (external-secrets#3493)

9ce60ec

Signed-off-by: shuheiktgw <s-kitagawa@mercari.com>

Bude8 pushed a commit to Bude8/external-secrets that referenced this pull request Jun 13, 2024

Fix flaky ES controller test (external-secrets#3493)

ed7b733

Signed-off-by: shuheiktgw <s-kitagawa@mercari.com> Signed-off-by: Bude8 <henryblee8@gmail.com>

pacificcode pushed a commit to pacificcode/external-secrets that referenced this pull request Jul 3, 2024

Fix flaky ES controller test (external-secrets#3493)

d17ad56

Signed-off-by: shuheiktgw <s-kitagawa@mercari.com> Signed-off-by: Bill Hamilton <bill.hamilton@delinea.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix flaky ES controller test#3493

Fix flaky ES controller test#3493
gusfcarvalho merged 1 commit intomainfrom
fix_flaky_es_test

shuheiktgw commented May 14, 2024 •

edited

Loading

Uh oh!

sonarqubecloud bot commented May 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

shuheiktgw commented May 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem Statement

Related Issue

Proposed Changes

Checklist

Uh oh!

sonarqubecloud bot commented May 14, 2024

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

shuheiktgw commented May 14, 2024 •

edited

Loading