Methods for managing securityContext and OpenShift support by sabre1041 · Pull Request #3420 · external-secrets/external-secrets

sabre1041 · 2024-04-27T19:33:32Z

Problem Statement

Enhanced securityContext customizations with specific considerations for OpenShift

Proposed Changes

Provided new Helm partial that provides enhancements for managing securityContext values. Supports removing fields set automatically by OpenShift

Checklist

I have read the contribution guidelines
All commits are signed with git commit --signoff
My changes have reasonable test coverage
All tests pass with make test
I ensured my PR is ready for review with make reviewable

deploy/charts/external-secrets/values.yaml

gusfcarvalho · 2024-04-28T20:57:04Z

hi @sabre1041 - I think after updating the podSecurityContext.enabled default to true the helm unittests should already pass. You might need to update the snapshots with make helm.test.update as well.

by the way, thanks for the interest in this project 😄 and for the PR 🙏

Signed-off-by: Andrew Block <andy.block@gmail.com>

sabre1041 · 2024-04-29T00:16:14Z

@gusfcarvalho updated. tests pass

sonarqubecloud · 2024-04-29T00:16:26Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [external-secrets](https://github.com/external-secrets/external-secrets) | patch | `0.9.16` -> `0.9.17` | --- ### Release Notes <details> <summary>external-secrets/external-secrets (external-secrets)</summary> ### [`v0.9.17`](https://github.com/external-secrets/external-secrets/releases/tag/v0.9.17) [Compare Source](external-secrets/external-secrets@v0.9.16...v0.9.17) Image: `ghcr.io/external-secrets/external-secrets:v0.9.17` Image: `ghcr.io/external-secrets/external-secrets:v0.9.17-ubi` Image: `ghcr.io/external-secrets/external-secrets:v0.9.17-ubi-boringssl` #### What's Changed - bump 0.9.16 by [@gusfcarvalho](https://github.com/gusfcarvalho) in external-secrets/external-secrets#3385 - Fix typo in webhook.md by [@Bo0km4n](https://github.com/Bo0km4n) in external-secrets/external-secrets#3388 - Publish the secret updated events only when they are updated by [@shuheiktgw](https://github.com/shuheiktgw) in external-secrets/external-secrets#3293 - Feat/add validations to external secret data from remote ref by [@shuheiktgw](https://github.com/shuheiktgw) in external-secrets/external-secrets#3390 - chore(deps): bump github/codeql-action from 3.24.10 to 3.25.1 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3406 - chore(deps): bump actions/checkout from 4.1.2 to 4.1.3 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3405 - chore(deps): bump regex from 2023.12.25 to 2024.4.16 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3404 - chore(deps): bump mkdocs-material from 9.5.17 to 9.5.18 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3402 - Fix Azure Container Registry Generator invalid YAML by [@ppatel1604](https://github.com/ppatel1604) in external-secrets/external-secrets#3414 - Update Go and golangci-lint version by [@shuheiktgw](https://github.com/shuheiktgw) in external-secrets/external-secrets#3396 - chore(deps): bump pymdown-extensions from 10.7.1 to 10.8 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3401 - ADOPTERS.md: add Fivetran by [@felipeneuwald](https://github.com/felipeneuwald) in external-secrets/external-secrets#3409 - Add Conjur Support for FindByName, FindByTag by [@szh](https://github.com/szh) in external-secrets/external-secrets#3364 - chore(deps): bump mkdocs from 1.5.3 to 1.6.0 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3403 - Add support for specifying extra manifests via helm by [@upodroid](https://github.com/upodroid) in external-secrets/external-secrets#3421 - Methods for managing securityContext and OpenShift support by [@sabre1041](https://github.com/sabre1041) in external-secrets/external-secrets#3420 - Refactor the SecretStore client manager by [@shuheiktgw](https://github.com/shuheiktgw) in external-secrets/external-secrets#3419 - chore(deps): bump golang from `cdc86d9` to `cdc86d9` by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3423 - chore(deps): bump golangci/golangci-lint-action from 4.0.0 to 5.0.0 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3425 - chore(deps): bump actions/checkout from 4.1.3 to 4.1.4 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3426 - chore(deps): bump github/codeql-action from 3.25.1 to 3.25.3 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3427 - chore(deps): bump helm/kind-action from 1.9.0 to 1.10.0 by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3428 - chore(deps): bump platformdirs from 4.2.0 to 4.2.1 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3429 - chore(deps): bump pymdown-extensions from 10.8 to 10.8.1 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3430 - chore(deps): bump regex from 2024.4.16 to 2024.4.28 in /hack/api-docs by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3431 - chore(deps): bump golang from `b03f3ba` to `d0902ba` in /e2e by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3432 - Update common-k8s-secret-types.md to fix get secret jsonpath by [@tyki6](https://github.com/tyki6) in external-secrets/external-secrets#3434 - chore: update dependencies by [@eso-service-account-app](https://github.com/eso-service-account-app) in external-secrets/external-secrets#3433 - chore(deps): bump distroless/static from `6d31326` to `4197211` by [@dependabot](https://github.com/dependabot) in external-secrets/external-secrets#3424 - Improve bitwarden example by [@imstevenxyz](https://github.com/imstevenxyz) in external-secrets/external-secrets#3435 #### New Contributors - [@Bo0km4n](https://github.com/Bo0km4n) made their first contribution in external-secrets/external-secrets#3388 - [@felipeneuwald](https://github.com/felipeneuwald) made their first contribution in external-secrets/external-secrets#3409 - [@upodroid](https://github.com/upodroid) made their first contribution in external-secrets/external-secrets#3421 - [@sabre1041](https://github.com/sabre1041) made their first contribution in external-secrets/external-secrets#3420 - [@tyki6](https://github.com/tyki6) made their first contribution in external-secrets/external-secrets#3434 - [@imstevenxyz](https://github.com/imstevenxyz) made their first contribution in external-secrets/external-secrets#3435 **Full Changelog**: external-secrets/external-secrets@v0.9.16...v0.9.17 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.internal/nrdufour/home-ops/pulls/460 Co-authored-by: Renovate <renovate@ptinem.casa> Co-committed-by: Renovate <renovate@ptinem.casa>

The Helm function helper file contains a couple of merge pointers from external-secrets#3420. Signed-off-by: Gaston Festari <cilindrox@gmail.com>

The Helm function helper file contains a couple of merge pointers from #3420. Signed-off-by: Gaston Festari <cilindrox@gmail.com>

The Helm function helper file contains a couple of merge pointers from external-secrets#3420. Signed-off-by: Gaston Festari <cilindrox@gmail.com>

…secrets#3420) Signed-off-by: Andrew Block <andy.block@gmail.com> Signed-off-by: Bude8 <henryblee8@gmail.com>

The Helm function helper file contains a couple of merge pointers from external-secrets#3420. Signed-off-by: Gaston Festari <cilindrox@gmail.com> Signed-off-by: Bude8 <henryblee8@gmail.com>

…secrets#3420) Signed-off-by: Andrew Block <andy.block@gmail.com> Signed-off-by: Bill Hamilton <bill.hamilton@delinea.com>

The Helm function helper file contains a couple of merge pointers from external-secrets#3420. Signed-off-by: Gaston Festari <cilindrox@gmail.com> Signed-off-by: Bill Hamilton <bill.hamilton@delinea.com>

sabre1041 requested a review from a team as a code owner April 27, 2024 19:33

sabre1041 requested a review from moolen April 27, 2024 19:33

gusfcarvalho reviewed Apr 28, 2024

View reviewed changes

deploy/charts/external-secrets/values.yaml Outdated Show resolved Hide resolved

Methods for managing securityContext and OpenShift support

60c34be

Signed-off-by: Andrew Block <andy.block@gmail.com>

sabre1041 force-pushed the securitycontext-enhancements branch from 2218c78 to 60c34be Compare April 29, 2024 00:15

gusfcarvalho approved these changes Apr 29, 2024

View reviewed changes

gusfcarvalho merged commit 07dabc4 into external-secrets:main Apr 29, 2024

cilindrox added a commit to cilindrox/external-secrets that referenced this pull request May 7, 2024

fix(helm): remove git merge pointers

60f5f93

The Helm function helper file contains a couple of merge pointers from external-secrets#3420. Signed-off-by: Gaston Festari <cilindrox@gmail.com>

cilindrox mentioned this pull request May 7, 2024

fix(helm): remove git merge pointers #3467

Merged

5 tasks

gusfcarvalho pushed a commit that referenced this pull request May 10, 2024

fix(helm): remove git merge pointers (#3467)

e7dc3a7

The Helm function helper file contains a couple of merge pointers from #3420. Signed-off-by: Gaston Festari <cilindrox@gmail.com>

jonasgeiler mentioned this pull request May 24, 2024

Add securityContext compatibility with OpenShift platform MaikuMori/helm-charts#33

Closed

4 tasks

Bude8 pushed a commit to Bude8/external-secrets that referenced this pull request Jun 13, 2024

Methods for managing securityContext and OpenShift support (external-…

bfc2c73

…secrets#3420) Signed-off-by: Andrew Block <andy.block@gmail.com> Signed-off-by: Bude8 <henryblee8@gmail.com>

johannes94 mentioned this pull request Mar 19, 2025

ROX-27835: update external secret operator and remove special handling of user stackrox/acs-fleet-manager#2249

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Methods for managing securityContext and OpenShift support#3420

Methods for managing securityContext and OpenShift support#3420
gusfcarvalho merged 1 commit intoexternal-secrets:mainfrom
sabre1041:securitycontext-enhancements

sabre1041 commented Apr 27, 2024

Uh oh!

Uh oh!

gusfcarvalho commented Apr 28, 2024 •

edited

Loading

Uh oh!

sabre1041 commented Apr 29, 2024

Uh oh!

sonarqubecloud bot commented Apr 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

sabre1041 commented Apr 27, 2024

Problem Statement

Proposed Changes

Checklist

Uh oh!

Uh oh!

gusfcarvalho commented Apr 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sabre1041 commented Apr 29, 2024

Uh oh!

sonarqubecloud bot commented Apr 29, 2024

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gusfcarvalho commented Apr 28, 2024 •

edited

Loading