feat: add secret push format to AWS secrets manager#3189
Merged
Skarlso merged 5 commits intoexternal-secrets:mainfrom Mar 10, 2024
Skarlso:issue_1816_push_secret_type
Merged
feat: add secret push format to AWS secrets manager#3189Skarlso merged 5 commits intoexternal-secrets:mainfrom Skarlso:issue_1816_push_secret_type
Skarlso merged 5 commits intoexternal-secrets:mainfrom
Skarlso:issue_1816_push_secret_type
Conversation
shuheiktgw
suggested changes
Mar 8, 2024
Contributor
shuheiktgw
left a comment
There was a problem hiding this comment.
I left a few comments but overall LGTM 🙂
| if err != nil { | ||
| if errors.Is(err, errKeyNotFound) { | ||
| return def, nil | ||
| } |
Contributor
There was a problem hiding this comment.
I believe you forgot to return an error here.
Contributor
Author
There was a problem hiding this comment.
The intention here is that if the key is not found we return the set default value. Arguably I could have named the variable better. 🤣 or at least add a comment.
Contributor
There was a problem hiding this comment.
Ah, I see what you are trying to do here 👍
| const ( | ||
| SecretPushFormatKey = "secretPushFormat" | ||
| SecretPushFormatString = "string" | ||
| SecretPushFormatBinary = "binary" |
Contributor
There was a problem hiding this comment.
Could you add documentation on these metadata?
Contributor
Author
There was a problem hiding this comment.
Ah thanks. I forgot! 🤦
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
|
Bude8
pushed a commit
to Bude8/external-secrets
that referenced
this pull request
Jun 13, 2024
…#3189) Signed-off-by: Bude8 <henryblee8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
What is the problem you're trying to solve?
Related Issue
Fixes #1816
Proposed Changes
How do you like to solve the issue and why?
Checklist
git commit --signoffmake testmake reviewable