Fix wrong namespaceSelector configuration in snippet in document by kyasbal · Pull Request #3054 · external-secrets/external-secrets

kyasbal · 2024-01-20T07:45:46Z

Problem Statement

What is the problem you're trying to solve?

The snippet[1] was not aligning with the schema defined in CRD.

[1] https://external-secrets.io/latest/guides/security-best-practices/

Proposed Changes

How do you like to solve the issue and why?

fix the document.

Checklist

I have read the contribution guidelines
All commits are signed with git commit --signoff
My changes have reasonable test coverage
(This change is only for document)
All tests pass with make test
I ensured my PR is ready for review with make reviewable

The snippet[1] was not aligning with the schema defined in CRD. [1] https://external-secrets.io/latest/guides/security-best-practices/ Signed-off-by: kyasbal <kyasbal1994@gmail.com>

sonarqubecloud · 2024-01-20T07:46:16Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

kyasbal · 2024-01-20T07:47:55Z

Should I do test for this change as the checklist says? I just changed a snippet in the doc.

moolen

LGTM, thank you for this fix! 🙇
No need for tests in the docs ;)

…ernal-secrets#3054) The snippet[1] was not aligning with the schema defined in CRD. [1] https://external-secrets.io/latest/guides/security-best-practices/ Signed-off-by: kyasbal <kyasbal1994@gmail.com> Signed-off-by: Sai Charan Godasi <saicharangodasi@Sais-MacBook-Air.local>

…ernal-secrets#3054) The snippet[1] was not aligning with the schema defined in CRD. [1] https://external-secrets.io/latest/guides/security-best-practices/ Signed-off-by: kyasbal <kyasbal1994@gmail.com> Signed-off-by: Mike Serchenia <michael_serchenia@epam.com>

* main: (38 commits) chore: bump ubi image (external-secrets#3096) 🧹 refactor vault provider (external-secrets#3072) chore(deps): bump alpine from `51b6726` to `c5b1261` (external-secrets#3087) chore(deps): bump golang from `c4b696f` to `d8c365d` in /e2e (external-secrets#3084) chore(deps): bump github/codeql-action from 3.23.1 to 3.23.2 (external-secrets#3089) chore(deps): bump alpine from `51b6726` to `c5b1261` in /hack/api-docs (external-secrets#3088) chore(deps): bump golang from `fd78f2f` to `a6a7f1f` (external-secrets#3086) chore(deps): bump codecov/codecov-action from 3.1.4 to 3.1.5 (external-secrets#3090) IBM provider: remove deprecated code for fetching secret by name (external-secrets#3078) chore: bump jwx pkg (external-secrets#3075) added metrics support for akeyless (external-secrets#3069) chore: update dependencies (external-secrets#3065) chore(deps): bump markupsafe from 2.1.3 to 2.1.4 in /hack/api-docs (external-secrets#3062) chore(deps): bump mkdocs-minify-plugin in /hack/api-docs (external-secrets#3063) chore: add tests for AWS/SM (external-secrets#3057) chore(deps): bump alpine from 3.18 to 3.19 in /hack/api-docs (external-secrets#3039) feat: expose admission warnings to ValidateStore interface (external-secrets#3058) chore: fixup security response suggestions (external-secrets#3056) chore: refactor/centralise secretKeyRef usage (external-secrets#3022) Fix wrong namespaceSelector configuration in snippet in document (external-secrets#3054) ...

…ernal-secrets#3054) The snippet[1] was not aligning with the schema defined in CRD. [1] https://external-secrets.io/latest/guides/security-best-practices/ Signed-off-by: kyasbal <kyasbal1994@gmail.com>

Fix wrong namespaceSelector configuration in snippet in document

aae5338

The snippet[1] was not aligning with the schema defined in CRD. [1] https://external-secrets.io/latest/guides/security-best-practices/ Signed-off-by: kyasbal <kyasbal1994@gmail.com>

kyasbal requested a review from a team as a code owner January 20, 2024 07:45

kyasbal requested a review from knelasevero January 20, 2024 07:45

moolen approved these changes Jan 20, 2024

View reviewed changes

moolen merged commit b6b4f12 into external-secrets:main Jan 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix wrong namespaceSelector configuration in snippet in document#3054

Fix wrong namespaceSelector configuration in snippet in document#3054
moolen merged 1 commit intoexternal-secrets:mainfrom
kyasbal:patch-1

kyasbal commented Jan 20, 2024 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Jan 20, 2024

Uh oh!

kyasbal commented Jan 20, 2024 •

edited

Loading

Uh oh!

moolen left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kyasbal commented Jan 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem Statement

Proposed Changes

Checklist

Uh oh!

sonarqubecloud bot commented Jan 20, 2024

Quality Gate passed

Uh oh!

kyasbal commented Jan 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

moolen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kyasbal commented Jan 20, 2024 •

edited

Loading

kyasbal commented Jan 20, 2024 •

edited

Loading