feat: set default namespace on vault secretStore (namespaced ressource) by M0NsTeRRR · Pull Request #2869 · external-secrets/external-secrets

M0NsTeRRR · 2023-11-11T19:25:19Z

Related Issue

Proposed Changes

With my little understanding of the project (new user) I've tried to address the linked issue. I've added a depreciation message to the current users.

PS : Thanks for this open source project, happy to use it in my homelab :)

Checklist

I have read the contribution guidelines
All commits are signed with git commit --signoff
My changes have reasonable test coverage
All tests pass with make test
I ensured my PR is ready for review with make reviewable

paul-the-alien

Greetings!
Thank you for contributing to this project!
If this is your first time contributing, please make
sure to read the Developer and Contributing Process guides.
Please also mind and follow our Code of Conduct.

Useful commands:

make fmt: Formats the code
make check-diff: Ensures the branch is clean
make reviewable: Ensures a PR is ready for review

sonarqubecloud · 2023-11-11T19:25:42Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

M0NsTeRRR · 2024-01-10T00:04:56Z

I didn't see the notification about the failed test 😥, it should be fine now.
I've updated the code and the test regarding this.
I'm not comfortable with Go and as it's my first PR to the project, I may have misunderstood some parts of the code don't hesitate to criticize :)

moolen

Hey @M0NsTeRRR i'm so sorry for the delay, we're lacking the time to review PRs 😞

Changes LGTM, one comment regarding the deprecation notice.

pkg/provider/vault/vault.go

moolen · 2024-01-12T20:21:12Z

/ok-to-test sha=45f74de

M0NsTeRRR · 2024-01-13T12:52:26Z

i'm so sorry for the delay, we're lacking the time to review PRs 😞

No worries :)

Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

sonarqubecloud · 2024-01-13T12:54:17Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

moolen

LGTM! Thank you for your contribution 🏅 🎉

…e) (external-secrets#2869) * feat: set default namespace on vault secretStore Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> * fix: unit test Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> * feat: remove depreciation message Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> --------- Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> Signed-off-by: Mike Serchenia <michael_serchenia@epam.com>

…e) (external-secrets#2869) * feat: set default namespace on vault secretStore Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> * fix: unit test Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> * feat: remove depreciation message Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> --------- Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> Signed-off-by: Sai Charan Godasi <saicharangodasi@Sais-MacBook-Air.local>

…e) (external-secrets#2869) * feat: set default namespace on vault secretStore Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> * fix: unit test Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> * feat: remove depreciation message Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> --------- Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> Signed-off-by: Mike Serchenia <michael_serchenia@epam.com>

…e) (external-secrets#2869) * feat: set default namespace on vault secretStore Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> * fix: unit test Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> * feat: remove depreciation message Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> --------- Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

M0NsTeRRR requested a review from a team as a code owner November 11, 2023 19:25

M0NsTeRRR requested review from sebagomez and removed request for a team November 11, 2023 19:25

paul-the-alien bot reviewed Nov 11, 2023

View reviewed changes

M0NsTeRRR and others added 4 commits January 4, 2024 20:16

feat: set default namespace on vault secretStore

0d0535e

Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

Merge branch 'main' into main

a075379

Merge branch 'external-secrets:main' into main

481ceef

fix: unit test

45f74de

Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

moolen reviewed Jan 12, 2024

View reviewed changes

pkg/provider/vault/vault.go Outdated Show resolved Hide resolved

M0NsTeRRR and others added 2 commits January 13, 2024 13:53

feat: remove depreciation message

e4e9b1f

Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

Merge branch 'main' into main

fec1c97

M0NsTeRRR requested a review from moolen January 13, 2024 12:54

moolen approved these changes Jan 16, 2024

View reviewed changes

moolen mentioned this pull request Jan 16, 2024

API depreciation process #3030

Closed

10 tasks

moolen merged commit 0a02f73 into external-secrets:main Jan 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: set default namespace on vault secretStore (namespaced ressource)#2869

feat: set default namespace on vault secretStore (namespaced ressource)#2869
moolen merged 6 commits intoexternal-secrets:mainfrom
M0NsTeRRR:main

M0NsTeRRR commented Nov 11, 2023 •

edited

Loading

Uh oh!

paul-the-alien bot left a comment

Uh oh!

sonarqubecloud bot commented Nov 11, 2023

Uh oh!

M0NsTeRRR commented Jan 10, 2024

Uh oh!

moolen left a comment

Uh oh!

Uh oh!

moolen commented Jan 12, 2024

Uh oh!

M0NsTeRRR commented Jan 13, 2024

Uh oh!

sonarqubecloud bot commented Jan 13, 2024

Uh oh!

moolen left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

M0NsTeRRR commented Nov 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issue

Proposed Changes

Checklist

Uh oh!

paul-the-alien bot left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Nov 11, 2023

Uh oh!

M0NsTeRRR commented Jan 10, 2024

Uh oh!

moolen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

moolen commented Jan 12, 2024

Uh oh!

M0NsTeRRR commented Jan 13, 2024

Uh oh!

sonarqubecloud bot commented Jan 13, 2024

Quality Gate passed

Uh oh!

moolen left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

M0NsTeRRR commented Nov 11, 2023 •

edited

Loading