Onboardbase by limistah · Pull Request #2697 · external-secrets/external-secrets

limistah · 2023-09-14T08:19:52Z

Problem Statement

Add Onboardbase as an external secret provider

Proposed Changes

Integrate Onboardbase by implementing their APIs

Checklist

I have read the contribution guidelines
All commits are signed with git commit --signoff
My changes have reasonable test coverage
All tests pass with make test
I ensured my PR is ready for review with make reviewable

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

… into onboardbase

Skarlso · 2024-02-28T14:39:41Z

@limistah Ah, could you please take care of the three new Sonar issues in your files? Thanks! :)

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

… into onboardbase

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

limistah · 2024-02-28T20:05:50Z

@Skarlso all sonarcloud issues have been fixed.

Thank you

Skarlso · 2024-02-29T05:54:33Z

Marvellous. Thanks.

Skarlso · 2024-02-29T07:15:44Z

Hello. One of the unit tests is failing. Can you please take a look?

    onboardbase_test.go:259: [1] unexpected secret data: expected map[string][]uint8{"API_KEY":[]uint8{0x33, 0x61, 0x33, 0x65, 0x61, 0x34, 0x66, 0x35}, "AUTH_SA":[]uint8{0x7b, 0x22, 0x61, 0x70, 0x70, 0x49, 0x44, 0x22, 0x3a, 0x20, 0x22, 0x61, 0x31, 0x65, 0x61, 0x2d, 0x34, 0x38, 0x62, 0x64, 0x2d, 0x38, 0x37, 0x34, 0x39, 0x2d, 0x62, 0x36, 0x66, 0x35, 0x65, 0x63, 0x33, 0x63, 0x35, 0x61, 0x31, 0x66, 0x22, 0x7d}}, got map[string][]uint8{"API_KEY":[]uint8{0x33, 0x61, 0x33, 0x65, 0x61, 0x34, 0x66, 0x73, 0x35}, "AUTH_SA":[]uint8{0x7b, 0x22, 0x61, 0x70, 0x70, 0x49, 0x44, 0x22, 0x3a, 0x20, 0x22, 0x61, 0x31, 0x65, 0x61, 0x2d, 0x34, 0x38, 0x62, 0x64, 0x2d, 0x38, 0x37, 0x34, 0x39, 0x2d, 0x62, 0x36, 0x66, 0x35, 0x65, 0x63, 0x33, 0x63, 0x35, 0x61, 0x31, 0x66, 0x22, 0x7d}}
    --- FAIL: TestGetSecretMap/valid_unmarshalling_for_nested_json (0.00s)

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

limistah · 2024-02-29T08:11:38Z

Hello. One of the unit tests is failing. Can you please take a look?

    onboardbase_test.go:259: [1] unexpected secret data: expected map[string][]uint8{"API_KEY":[]uint8{0x33, 0x61, 0x33, 0x65, 0x61, 0x34, 0x66, 0x35}, "AUTH_SA":[]uint8{0x7b, 0x22, 0x61, 0x70, 0x70, 0x49, 0x44, 0x22, 0x3a, 0x20, 0x22, 0x61, 0x31, 0x65, 0x61, 0x2d, 0x34, 0x38, 0x62, 0x64, 0x2d, 0x38, 0x37, 0x34, 0x39, 0x2d, 0x62, 0x36, 0x66, 0x35, 0x65, 0x63, 0x33, 0x63, 0x35, 0x61, 0x31, 0x66, 0x22, 0x7d}}, got map[string][]uint8{"API_KEY":[]uint8{0x33, 0x61, 0x33, 0x65, 0x61, 0x34, 0x66, 0x73, 0x35}, "AUTH_SA":[]uint8{0x7b, 0x22, 0x61, 0x70, 0x70, 0x49, 0x44, 0x22, 0x3a, 0x20, 0x22, 0x61, 0x31, 0x65, 0x61, 0x2d, 0x34, 0x38, 0x62, 0x64, 0x2d, 0x38, 0x37, 0x34, 0x39, 0x2d, 0x62, 0x36, 0x66, 0x35, 0x65, 0x63, 0x33, 0x63, 0x35, 0x61, 0x31, 0x66, 0x22, 0x7d}}
    --- FAIL: TestGetSecretMap/valid_unmarshalling_for_nested_json (0.00s)

This has been fixed, an oversight modification

Skarlso · 2024-02-29T09:01:36Z

Can you run make docs please? :)

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

limistah · 2024-02-29T16:11:31Z

@Skarlso, just did.

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

sonarqubecloud · 2024-02-29T16:50:57Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.4% Duplication on New Code

See analysis details on SonarCloud

Skarlso · 2024-02-29T20:06:45Z

/ok-to-test sha=3c1e31e

Skarlso · 2024-02-29T20:28:25Z

Well done! Great job! :)

* Commit and Save Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Pull secrets Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Integrate Onboardbase Into ESO Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Minor Fix And Cleanups Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Attend to review comments Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Commit and Save Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Pull secrets Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Integrate Onboardbase Into ESO Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Minor Fix And Cleanups Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Attend to review comments Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Commit and Save Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Pull secrets Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Integrate Onboardbase Into ESO Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Minor Fix And Cleanups Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Attend to review comments Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Commit and Save Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Pull secrets Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Integrate Onboardbase Into ESO Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Minor Fix And Cleanups Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Attend to review comments Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Run decrypt with error Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Commit and Save Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Pull secrets Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Integrate Onboardbase Into ESO Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Minor Fix And Cleanups Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Attend to review comments Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Commit and Save Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Pull secrets Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Integrate Onboardbase Into ESO Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Minor Fix And Cleanups Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Attend to review comments Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Commit and Save Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Pull secrets Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Integrate Onboardbase Into ESO Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Minor Fix And Cleanups Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Attend to review comments Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Commit and Save Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Pull secrets Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Integrate Onboardbase Into ESO Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Minor Fix And Cleanups Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Attend to review comments Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Install deps Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Improved docs Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Improved docs Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Update hack/crd.generate.sh Co-authored-by: Gustavo Fernandes de Carvalho <gusfcarvalho@gmail.com> Signed-off-by: Aleem Isiaka <30846935+limistah@users.noreply.github.com> * address issues with running the code Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * decrypt library into code Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * add docs to onboardbase provider Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * refactor duplicates Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Address Issues with tests Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Address issues with delete policy and json secrets Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Fix lint errors Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * error out when there is tags in the find field Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * execute delete request with the right data Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * ignore deletion policy Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * improve lint errors Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * remove cryptojs decrypt libs Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * Get secret value if property is set Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * run obb operator Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * 👌 IMPROVE: supports request deadline, esv1beta1 api updates Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * use same timeout Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * fix sonar cloud issues Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * fix sonar cloud issues Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * fix sonar cloud issues Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * fix failing test Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * add improve docs Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> * add improve docs Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> --------- Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com> Signed-off-by: Nasirudeen Olohundare <iamnasirudeen@gmail.com> Signed-off-by: Aleem Isiaka <30846935+limistah@users.noreply.github.com> Co-authored-by: Nasirudeen Olohundare <iamnasirudeen@gmail.com> Co-authored-by: Gustavo Fernandes de Carvalho <gusfcarvalho@gmail.com> Signed-off-by: Bude8 <henryblee8@gmail.com>

limistah added 30 commits March 14, 2023 10:39

Commit and Save

8fa5b60

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Pull secrets

2b06a96

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Integrate Onboardbase Into ESO

8f3f5f9

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Minor Fix And Cleanups

bdc566e

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Attend to review comments

c0f6290

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Commit and Save

bcc9d25

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Pull secrets

6adb812

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Integrate Onboardbase Into ESO

a2ff760

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Minor Fix And Cleanups

9599e1b

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Attend to review comments

04feb43

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Commit and Save

1a5b937

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Pull secrets

f85a0cf

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Integrate Onboardbase Into ESO

36048ac

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Minor Fix And Cleanups

0ad6a70

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Attend to review comments

1495787

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Commit and Save

e72db1c

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Pull secrets

840f7d2

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Integrate Onboardbase Into ESO

0b1984f

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Minor Fix And Cleanups

f88b2c6

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Attend to review comments

5681b2d

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Run decrypt with error

3086c6f

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Commit and Save

8c99af1

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Pull secrets

9c298d4

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Integrate Onboardbase Into ESO

6d36ac7

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Minor Fix And Cleanups

b818798

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Attend to review comments

09d57dd

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Commit and Save

8f30f75

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Pull secrets

b98616f

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Integrate Onboardbase Into ESO

5ee07d1

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Minor Fix And Cleanups

af0e56a

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

limistah added 2 commits February 28, 2024 10:35

run obb operator

6ec3f40

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

👌 IMPROVE: supports request deadline, esv1beta1 api updates

04affd7

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

limistah force-pushed the onboardbase branch from 50b8a39 to 04affd7 Compare February 28, 2024 09:35

Merge branch 'main' into onboardbase

b5d4ea9

limistah requested a review from Skarlso February 28, 2024 09:37

limistah added 2 commits February 28, 2024 10:52

use same timeout

1d81a89

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Merge branch 'onboardbase' of github.com:Onboardbase/external-secrets…

0abe321

… into onboardbase

limistah and others added 5 commits February 28, 2024 20:48

fix sonar cloud issues

04368c0

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Merge branch 'main' into onboardbase

a9d80b3

fix sonar cloud issues

be13d57

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Merge branch 'onboardbase' of github.com:Onboardbase/external-secrets…

8bb3e9e

… into onboardbase

fix sonar cloud issues

4f0d483

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

fix failing test

de87655

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

limistah force-pushed the onboardbase branch from 6a00890 to de87655 Compare February 29, 2024 08:11

add improve docs

d056a5d

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

add improve docs

3c1e31e

Signed-off-by: Aleem Isiaka <aleemisiaka@gmail.com>

Skarlso approved these changes Feb 29, 2024

View reviewed changes

Skarlso merged commit 52f6655 into external-secrets:main Feb 29, 2024

fdberlking mentioned this pull request Mar 1, 2024

Correct failing crds helm.tests for providers onboardbase and fortanix #3214

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Onboardbase#2697

Onboardbase#2697
Skarlso merged 84 commits intoexternal-secrets:mainfrom
Onboardbase:onboardbase

limistah commented Sep 14, 2023

Uh oh!

Skarlso commented Feb 28, 2024

Uh oh!

limistah commented Feb 28, 2024

Uh oh!

Skarlso commented Feb 29, 2024

Uh oh!

Skarlso commented Feb 29, 2024

Uh oh!

limistah commented Feb 29, 2024

Uh oh!

Skarlso commented Feb 29, 2024

Uh oh!

limistah commented Feb 29, 2024

Uh oh!

sonarqubecloud bot commented Feb 29, 2024

Uh oh!

Skarlso commented Feb 29, 2024

Uh oh!

Skarlso commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

limistah commented Sep 14, 2023

Problem Statement

Proposed Changes

Checklist

Uh oh!

Skarlso commented Feb 28, 2024

Uh oh!

limistah commented Feb 28, 2024

Uh oh!

Skarlso commented Feb 29, 2024

Uh oh!

Skarlso commented Feb 29, 2024

Uh oh!

limistah commented Feb 29, 2024

Uh oh!

Skarlso commented Feb 29, 2024

Uh oh!

limistah commented Feb 29, 2024

Uh oh!

sonarqubecloud bot commented Feb 29, 2024

Quality Gate passed

Uh oh!

Skarlso commented Feb 29, 2024

Uh oh!

Skarlso commented Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants