Skip to content

Added documentation for calling acceptsLanguages without argument#1402

Merged
crandmck merged 1 commit intoexpressjs:gh-pagesfrom
dotnetCarpenter:patch-1
Mar 4, 2024
Merged

Added documentation for calling acceptsLanguages without argument#1402
crandmck merged 1 commit intoexpressjs:gh-pagesfrom
dotnetCarpenter:patch-1

Conversation

@dotnetCarpenter
Copy link
Copy Markdown
Contributor

Calling req.acceptsLanguages without argument(s) returns an array of languages from the HTTP Accept-Language header.

This is much easier than calling req.get('Accept-Language'), because you do not need to parse the Accept-Language header string.

Close #1401

Calling req.acceptsLanguages without argument(s) returns an array of languages from the HTTP Accept-Language header.
This is much easier than calling req.get('Accept-Language') because you do not need to parse the Accept-Language header string.

Close expressjs#1401
Copy link
Copy Markdown
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dotnetCarpenter. It took me a while to follow the change, but seems clear now that I checked the test file from accepts (https://github.com/jshttp/accepts/blob/master/test/language.js#L12) following the expressjs code (https://github.com/expressjs/express/blob/2a00da2067b7017f769c9100205a2a5f267a884b/lib/request.js#L181).

This is a very useful change in the docs! 👍

@crandmck crandmck self-requested a review March 4, 2024 01:57
@crandmck crandmck merged commit cb58132 into expressjs:gh-pages Mar 4, 2024
@dotnetCarpenter dotnetCarpenter deleted the patch-1 branch March 20, 2024 22:26
krzysdz added a commit to krzysdz/expressjs.com that referenced this pull request Apr 24, 2025
krzysdz added a commit to krzysdz/expressjs.com that referenced this pull request Apr 25, 2025
expressjs#1402

Co-authored-by: Jon Ege Ronnenberg <jon.ronnenberg@gmail.com>
bjohansebas pushed a commit that referenced this pull request May 1, 2025
* Include 4.18 API doc updates in 5.x

5c98ee4

Co-authored-by: Douglas Christopher Wilson <doug@somethingdoug.com>

* Copy acceptsLanguages documentation improvements to 5.x

#1402

Co-authored-by: Jon Ege Ronnenberg <jon.ronnenberg@gmail.com>

* Add warning boxes to {app,res}.render

5e918ea

Co-authored-by: Douglas Christopher Wilson <doug@somethingdoug.com>

* Copy warning around securing locals to 5.x

fcaca7f

Co-authored-by: Douglas Christopher Wilson <doug@somethingdoug.com>

* Copy res.cookie `partitioned` option docs

#1456

Co-authored-by: Rich Hodgkins <rhodgkins@gmail.com>

* Update req.body to point to built-in middleware

a5ca5b0

Co-Authored-By: Douglas Wilson <doug@somethingdoug.com>

* Copy setting multiple cookies example to 5.x

#1063

Co-Authored-By: Mo <hematy61@gmail.com>

---------

Co-authored-by: krzysdz <krzysdz@users.noreply.github.com>
Co-authored-by: Douglas Christopher Wilson <doug@somethingdoug.com>
Co-authored-by: Jon Ege Ronnenberg <jon.ronnenberg@gmail.com>
Co-authored-by: Rich Hodgkins <rhodgkins@gmail.com>
Co-authored-by: Mo <hematy61@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documentation bug in request.acceptsLanguages

3 participants