fix #5554 passing URL instances with new location encoding#5555
Merged
wesleytodd merged 1 commit intomasterfrom Mar 20, 2024
Merged
fix #5554 passing URL instances with new location encoding#5555wesleytodd merged 1 commit intomasterfrom
wesleytodd merged 1 commit intomasterfrom
Conversation
b06f533 to
b70c174
Compare
Member
Author
jonchurch
approved these changes
Mar 20, 2024
51584c7 to
dd96d33
Compare
dd96d33 to
813e789
Compare
wesleytodd
added a commit
that referenced
this pull request
Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new check did not account for operating on the input to
.locationpreviously being wrapped withString()insideencodeurl. Adds explicit fix for that.