[menu-bar] Support deeplinks without leading / #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
approved these changes
Jun 16, 2025
Member
gabrieldonadel
left a comment
There was a problem hiding this comment.
LGTM, thanks for this PR
gabrieldonadel
pushed a commit
that referenced
this pull request
Jun 17, 2025
* [menu-bar] Support deeplinks without leading / * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently it's not possible to post expo orbit links in slack as it doesn't recognise it as a URI. If one does a URI with two slashes instead of 3 it works well however.
Closes #277
How
By inserting the missing / when it is omitted.
Test Plan
I added unit tests for this use case.