[menu-bar] support displaying new project icons #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37af732 to
733a142
Compare
733a142 to
496c679
Compare
gabrieldonadel
approved these changes
May 19, 2025
Member
gabrieldonadel
left a comment
There was a problem hiding this comment.
LGTM, just one update on the instructions
Co-authored-by: Gabriel Donadel Dall'Agnol <donadeldev@gmail.com>
gabrieldonadel
pushed a commit
that referenced
this pull request
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Add support for new project icons, refs:
How
Update GQL schema, query and logic for determining correct asset, add solid background placeholder for loading images.
Additionally, I have made small tweaks to the CONTRIBUTING guide.
Test Plan
clilocally.menu-barlocally.Preview