This repository was archived by the owner on Jan 18, 2024. It is now read-only.
Merged
Conversation
* Removed `terser-webpack-plugin`
EvanBacon
added a commit
to expo/expo
that referenced
this pull request
Mar 6, 2019
EvanBacon
added a commit
to expo/expo
that referenced
this pull request
Mar 6, 2019
* Update AppEntry.template.js * Fixed RNWeb treeshaking * Fixed emitter for web * Added unavailability to requireNativeViewManager * Fixed camera importing all of React Native * Update AppEntry.template.js * Update webpack.prod.js * Update index.js * Updated adapter for web * Fixed symlinks * updated facebook ads * Moved DeepScope to common * Added script to generate lazy and non-lazy entry * Delete Brightness.ts * Update DangerZone.ts * Moved to #3618 * Reverted file-system * reverted font * Update package.json * Moved side-effects * Reverted core.js * removed `web:dev` command in favor of `expo start` * Moved webpack changes to expo/expo-cli#407 * Update AppEntry.template.js * Update yarn.lock
Merged
fson
reviewed
Mar 8, 2019
* Removed bfj
* Added `excludePolyfill` option to `expo build:web`
fson
reviewed
Mar 11, 2019
fson
reviewed
Mar 11, 2019
fson
reviewed
Mar 11, 2019
* Updated stats promise
fson
suggested changes
Mar 12, 2019
Contributor
fson
left a comment
There was a problem hiding this comment.
Thanks, looks good. Added just a few things to address before this can be merged.
fson
reviewed
Mar 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Running
expo build:webwill generate static files.How
WebpackDeepScopeAnalysisPluginto commonoptimizationin favor of webpack defaults