[android][image] Add CookieJar to image request client#43257
Merged
alanjhughes merged 3 commits intomainfrom Feb 19, 2026
Merged
[android][image] Add CookieJar to image request client#43257alanjhughes merged 3 commits intomainfrom
CookieJar to image request client#43257alanjhughes merged 3 commits intomainfrom
Conversation
CookieJar to image request client
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: da8744c Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-image/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "e7f03fbc5f52732f66a401867fecb0ddb07534f1"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-image/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "cbf9f66cd9364ef40c91e0c1dc1eff74089fe57c"
}
}
]Generated by PR labeler 🤖 |
Contributor
|
Subscribed to pull request
Generated by CodeMention |
lukmccall
approved these changes
Feb 19, 2026
...po-image/android/src/main/java/expo/modules/image/okhttp/ExpoImageOkHttpClientGlideModule.kt
Outdated
Show resolved
Hide resolved
benjaminkomen
pushed a commit
to benjaminkomen/expo
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes #43229
Currently, cookies sent through fetch are not shared with image requests made by expo image. This is because we create our own client but don't configure it to use the global CookieManager.
How
Implement
CookieJar, read and write cookies to the shared manager and add it to theOkHttpClientbuilder.Test Plan
Tested in the provided repro