[notifications] add FCM intent origin validation#43206
Merged
Conversation
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: 0e1c33b Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-notifications/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "9caf67006de510b0ef5aaaa31ac795e2d5b8690d"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-notifications/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "329be3225a338cf67cdd5a9d92af0c4b6f7991ed"
}
}
]Generated by PR labeler 🤖 |
195403f to
6b8b4ba
Compare
6b8b4ba to
491d689
Compare
Contributor
|
Subscribed to pull request
Generated by CodeMention |
douglowder
reviewed
Feb 17, 2026
douglowder
approved these changes
Feb 18, 2026
benjaminkomen
pushed a commit
to benjaminkomen/expo
that referenced
this pull request
Feb 25, 2026
# Why closes expo#34523 This PR fixes an issue with notification handling on Android by properly filtering out OEM-injected extras that aren't actual FCM notifications. Some device manufacturers (like Samsung) inject extras into intents that can be mistakenly processed as notifications. # How - Added a constant `GOOGLE_MESSAGE_ID_KEY` to reference the FCM message ID key consistently - Added validation in `ExpoNotificationLifecycleListener` to check if intents contain the FCM message ID before processing them as notifications # Test Plan - notification tester app on device - send push notification to a killed app, tap it, observe `isFCMIntent` returning `true` in `ExpoNotificationLifecycleListener` # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
closes #34523
This PR fixes an issue with notification handling on Android by properly filtering out OEM-injected extras that aren't actual FCM notifications. Some device manufacturers (like Samsung) inject extras into intents that can be mistakenly processed as notifications.
How
GOOGLE_MESSAGE_ID_KEYto reference the FCM message ID key consistentlyExpoNotificationLifecycleListenerto check if intents contain the FCM message ID before processing them as notificationsTest Plan
isFCMIntentreturningtrueinExpoNotificationLifecycleListenerChecklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).