Conversation
…due to Parcelable deserialization failures
Contributor
|
Subscribed to pull request
Generated by CodeMention |
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: cac0c20 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-notifications/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "66fa608c0e01aebbcb5d835af63b19c8fdbce3b9"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-notifications/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "9caf67006de510b0ef5aaaa31ac795e2d5b8690d"
}
}
]Generated by PR labeler 🤖 |
douglowder
approved these changes
Feb 17, 2026
benjaminkomen
pushed a commit
to benjaminkomen/expo
that referenced
this pull request
Feb 25, 2026
…d 11/12 (expo#43203) due to Parcelable deserialization failures # Why closes expo#38908 # How On some Android versions (especially 11 and 12), custom Parcelable extras stored in a PendingIntent can come back as null when the system delivers the intent to NotificationForwarderActivity. This causes a crash when the user taps a notification. This PR adds byte array serialization of the notification and action data alongside the existing Parcelable extras. When the Parcelable extras are null, the code falls back to deserializing from the byte arrays. As a safety net, NotificationForwarderActivity also catches the failure and opens the app instead of crashing. # Test Plan - tests run in CI # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
due to Parcelable deserialization failures
Why
closes #38908
How
On some Android versions (especially 11 and 12), custom Parcelable extras stored in a PendingIntent can come back as null when the system delivers the intent to NotificationForwarderActivity. This causes a
crash when the user taps a notification. This PR adds byte array serialization of the notification and action data alongside the existing Parcelable extras. When the Parcelable extras are null, the code falls
back to deserializing from the byte arrays. As a safety net, NotificationForwarderActivity also catches the failure and opens the app instead of crashing.
Test Plan
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).