[notifications] add custom sound existence validation#43189
Merged
Conversation
e5922e3 to
23c7d51
Compare
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: aeb6506 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-notifications/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "7ec9e8e67483a938cd528c832d079dd5a030417e"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-notifications/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "66fa608c0e01aebbcb5d835af63b19c8fdbce3b9"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-notifications/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "5bb47f10637f0e13f6ad17ef9d4b5fdbd83db351"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-notifications/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "c86dfc7a2e9c99b00292e79407731143c78d0cb4"
}
}
]Generated by PR labeler 🤖 |
23c7d51 to
3349e41
Compare
Contributor
|
Subscribed to pull request
Generated by CodeMention |
3349e41 to
1a4ead1
Compare
douglowder
approved these changes
Feb 16, 2026
benjaminkomen
pushed a commit
to benjaminkomen/expo
that referenced
this pull request
Feb 25, 2026
# Why adds custom sound validation (closes expo#40954), and improves a push token warning on simulators this validates sound resource existence on iOS when calling `scheduleNotificationAsync`, and on Android when creating a `channel`. # How - notification tester app # Test Plan via the added examples # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
adds custom sound validation (closes #40954), and improves a push token warning on simulators
this validates sound resource existence on iOS when calling
scheduleNotificationAsync, and on Android when creating achannel.How
Test Plan
via the added examples
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).