Conversation
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: 205ab6d Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../node_modules/@react-native-community/netinfo",
"reasons": [
"rncoreAutolinkingAndroid",
"rncoreAutolinkingIos"
],
"hash": "21bc10eeb458ac3a912d18639399cd09b8e61e92"
},
"afterSource": {
"type": "dir",
"filePath": "../../node_modules/@react-native-community/netinfo",
"reasons": [
"rncoreAutolinkingAndroid",
"rncoreAutolinkingIos"
],
"hash": "7131e2ecb37cc4844850df0ba562b6d8f2f43886"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-cellular/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "8319b298f39fe576e85e9757068428817ffdb889"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-cellular/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "5324395d5dce43d3b8956069f68a716c42abf4ee"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-cellular/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "45027214786e8fc2f07f26753bdebc888979f4ac"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-cellular/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "d38066c759ea4276f8a4eceae4a7a03d43c8ae2a"
}
}
]Generated by PR labeler 🤖 |
56b3faf to
b3c8160
Compare
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Subscribed to pull request
Generated by CodeMention |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes deprecated carrier-related APIs (especially those relying on deprecated iOS CoreTelephony carrier info) and standardizes iOS behavior to return null (matching web) rather than dummy values.
Changes:
- Removed deprecated synchronous constants (JS/TS and native Android/iOS constants).
- Disabled iOS implementations for carrier-related async methods and return
nullon iOS from the JS layer. - Updated generated build artifacts and docs JSON to reflect the new API surface/behavior.
Reviewed changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/expo-cellular/src/Cellular.ts | Removes deprecated exports; updates JSDoc and returns null on iOS for carrier-related async APIs. |
| packages/expo-cellular/ios/CellularModule.swift | Removes deprecated constants and carrier-related async functions from the iOS native module. |
| packages/expo-cellular/android/src/main/java/expo/modules/cellular/CellularModule.kt | Removes deprecated constants from the Android native module. |
| packages/expo-cellular/build/Cellular.js | Regenerated JS build output reflecting source changes. |
| packages/expo-cellular/build/Cellular.d.ts | Regenerated type declarations reflecting removed exports and updated docs. |
| packages/expo-cellular/build/Cellular.d.ts.map | Regenerated sourcemap for type declarations. |
| packages/expo-cellular/CHANGELOG.md | Adds a breaking-change entry for the behavior change. |
| docs/public/static/data/v55.0.0/expo-cellular.json | Updates versioned docs JSON to remove deprecated constants and reflect platform behavior. |
| docs/public/static/data/unversioned/expo-cellular.json | Updates unversioned docs JSON to remove deprecated constants and reflect platform behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amandeepmittal
approved these changes
Feb 10, 2026
b3c8160 to
3beb902
Compare
barthap
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We're exposing information from CTCarrier which is deprecated with no replacement, as it exposes information that's (I suppose) privacy-sensitive.
The apis currently return dummy values such as
--instead of carrier name. Our docs don't reflect that.I also removed several constants that were deprecated long ago.
closes #23256
How
null, same as on webTest Plan
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).