[core][ui] update jetpack compose apis to support the showcase by Kudo · Pull Request #42734 · expo/expo

Kudo · 2026-01-30T19:35:12Z

Why

add jetpack compose apis that to support the wiki reader show case

How

[core][ui] ad RNHostView as swift-ui
[core] add nestedScrollConnection composableScope that allows descendants to access it
[core] add Children with filter support. that to support SlotView for compound components
[core] add onGlobalEvent as default registered event. this aligns with swift-ui implementation and to support modifier.clickable(() => { ... })
[core] RecordTypeConverter to support convertFromMap with nested map
[ui] add Icon which supports loading material symbol xml, e.g. <Icon source={require('./path/to/symbol.xml'} />. that to align modern material symbol usage.
[ui] add BasicAlertDialog (m3 api), Card, FlowRow, DockedSearchBar, SearchBar, FilterChip (for aligned naming), HorizontalFloatingToolbar, LazyColumn, ListItem, PullToRefreshBox, RadioButton (for aligned naming), Spacer, Surface, ToggleButton
[ui] add modifiers: width, height, wrapContentWidth, wrapContentHeight, align, clickable, selectable
[ui] rename BottomSheetView to ModalBottomSheet that to align compose api naming
[ui] change clip modifier usage. remove the coupling from Shape component and use predefined constants directly. e.g. clip(Shapes.RoundedCorner(16))
[ui] support <Switch.ThumbContent>
[ui] add broder style support for Text

Test Plan

in upstack showcase

Checklist

I added a changelog.md entry and rebuilt the package sources according to this short guide
This diff will work correctly for npx expo prebuild & EAS Build (eg: updated a module plugin).
Conforms with the Documentation Writing Style Guide

Kudo · 2026-01-30T19:35:31Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

expo-bot · 2026-01-30T19:37:38Z

The Pull Request introduced fingerprint changes against the base commit: a089c97

Fingerprint diff

[
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid",
        "expoAutolinkingIos"
      ],
      "hash": "9e80db6fd0fe039df0d3b2d9fb2c25c454ff20ba"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid",
        "expoAutolinkingIos"
      ],
      "hash": "5f49b983bc0e2a9be3208b27936882877bc34ce0"
    }
  },
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo-ui/android",
      "reasons": [
        "expoAutolinkingAndroid"
      ],
      "hash": "71d911e821ffd35179576dca47381d2033001f6e"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo-ui/android",
      "reasons": [
        "expoAutolinkingAndroid"
      ],
      "hash": "87fb316fee431b5fc82327b27ee5735df86ceb2d"
    }
  }
]

Generated by PR labeler 🤖

github-actions · 2026-01-31T18:31:12Z

Subscribed to pull request

File Patterns	Mentions
packages/expo-modules-core/**	@lukmccall, @tsapeta
packages/expo-ui/**	@aleqsio, @behenate, @douglowder

Generated by CodeMention

intergalacticspacehighway · 2026-02-16T04:11:43Z

packages/expo-ui/android/src/main/java/expo/modules/ui/icon/IconView.kt

+    var drawable by remember { mutableStateOf<Drawable?>(null) }
+
+    // Load icon from URI asynchronously
+    LaunchedEffect(source) {


nit

Suggested change

LaunchedEffect(source) {

val uriString = source?.let { resolveUri(it) }

// Load icon from URI asynchronously

LaunchedEffect(uriString) {

i would lean toward to keep LaunchedEffect(source) here. it reflects the fact of props.source. if people intentionally pass the same { uri }, the recompose is fine though.

packages/expo-ui/android/src/main/java/expo/modules/ui/icon/VectorIconLoader.kt

packages/expo-ui/android/build.gradle

intergalacticspacehighway · 2026-02-16T04:57:39Z

packages/expo-ui/android/src/main/java/expo/modules/ui/CardView.kt

+  }
+
+  when (props.variant) {
+    "elevated" -> {


Are we going to split them into separate components ElevatedCard, OutlinedCard in future?

yes, will leave it for future work. we still have many variant views somewhere else

intergalacticspacehighway · 2026-02-16T05:09:51Z

packages/expo-ui/android/src/main/java/expo/modules/ui/DockedSearchBarView.kt

+    expanded = false,
+    onExpandedChange = {},
+    inputField = @Composable {
+      SearchBarDefaults.InputField(


nit: Later maybe we can export it to JS as a compound component DockedSearchBar.InputField

leaving for future work. we need to find a way to expose SearchBarDefaults.InputField or other custom input field. may need to find a better way to support this use case

intergalacticspacehighway · 2026-02-16T05:19:05Z

packages/expo-ui/src/jetpack-compose/DockedSearchBar/index.tsx

+  let leadingIconContent: React.ReactNode = null;
+  const regularChildren: React.ReactNode[] = [];
+
+  Children.forEach(props.children as any, (child) => {


nit: passing children as it is to native might be better. can help if there's a react component in between in the hierarchy. e.g. Fragment, Suspense or a component defined by user.

For example, we could do below with current setup:

export const DockedSearchBarNativeView.Placeholder = ({children}) => <SlotNativeView slotName="placeholder">{children}</SlotNativeView>

that's a great suggestion. added in the latest commit

packages/expo-ui/src/jetpack-compose/FilterChip/index.tsx

intergalacticspacehighway

👏 . Added some comments/questions. Can be done in separate PR too.

packages/expo-ui/android/src/main/java/expo/modules/ui/icon/IconView.kt

Kudo · 2026-02-16T17:50:59Z

👏 . Added some comments/questions. Can be done in separate PR too.

much appreciated for the great review. updating changes or leaving inline comments. thanks!

--------- Co-authored-by: nishan (o^▽^o) <nishanbende@gmail.com>

…42734) # Why add jetpack compose apis that to support the wiki reader show case # How - [core][ui] ad RNHostView as swift-ui - [core] add `nestedScrollConnection` composableScope that allows descendants to access it - [core] add Children with filter support. that to support SlotView for compound components - [core] add `onGlobalEvent` as default registered event. this aligns with swift-ui implementation and to support `modifier.clickable(() => { ... })` - [core] `RecordTypeConverter` to support convertFromMap with nested map - [ui] add Icon which supports loading material symbol xml, e.g. `<Icon source={require('./path/to/symbol.xml'} />`. that to align modern material symbol usage. - [ui] add BasicAlertDialog (m3 api), Card, FlowRow, DockedSearchBar, SearchBar, FilterChip (for aligned naming), HorizontalFloatingToolbar, LazyColumn, ListItem, PullToRefreshBox, RadioButton (for aligned naming), Spacer, Surface, ToggleButton - [ui] add modifiers: width, height, wrapContentWidth, wrapContentHeight, align, clickable, selectable - [ui] rename BottomSheetView to ModalBottomSheet that to align compose api naming - [ui] change clip modifier usage. remove the coupling from Shape component and use predefined constants directly. e.g. `clip(Shapes.RoundedCorner(16))` - [ui] support `<Switch.ThumbContent>` - [ui] add broder style support for Text --------- Co-authored-by: nishan (o^▽^o) <nishanbende@gmail.com>

Kudo mentioned this pull request Jan 30, 2026

[core] fix view updates for expo-ui jetpack-compose #42732

Merged

3 tasks

expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 30, 2026

github-actions bot added the bot: fingerprint changed label Jan 30, 2026

expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 30, 2026

Kudo mentioned this pull request Jan 30, 2026

[apps][DO NOT MERGE] add wiki-reader showcase #42735

Closed

3 tasks

Kudo force-pushed the @kudo/ui/fix-compose-fast-refresh branch from d3212c3 to ba0e240 Compare January 31, 2026 13:08

Kudo force-pushed the @kudo/ui/support-wiki-reader branch from 1cb8820 to eb47ce5 Compare January 31, 2026 13:08

Kudo marked this pull request as ready for review January 31, 2026 18:30

Kudo requested review from aleqsio and intergalacticspacehighway January 31, 2026 18:31

intergalacticspacehighway reviewed Feb 16, 2026

View reviewed changes

packages/expo-ui/android/src/main/java/expo/modules/ui/icon/VectorIconLoader.kt Show resolved Hide resolved

intergalacticspacehighway reviewed Feb 16, 2026

View reviewed changes

packages/expo-ui/android/build.gradle Show resolved Hide resolved

intergalacticspacehighway reviewed Feb 16, 2026

View reviewed changes

packages/expo-ui/src/jetpack-compose/FilterChip/index.tsx Outdated Show resolved Hide resolved

intergalacticspacehighway approved these changes Feb 16, 2026

View reviewed changes

intergalacticspacehighway reviewed Feb 16, 2026

View reviewed changes

packages/expo-ui/android/src/main/java/expo/modules/ui/icon/IconView.kt Outdated Show resolved Hide resolved

Kudo force-pushed the @kudo/ui/support-wiki-reader branch from eb47ce5 to 410ddc3 Compare February 16, 2026 17:40

Kudo force-pushed the @kudo/ui/fix-compose-fast-refresh branch from ba0e240 to fb3baa9 Compare February 16, 2026 17:40

Kudo force-pushed the @kudo/ui/support-wiki-reader branch from 410ddc3 to 96e077d Compare February 16, 2026 17:51

Kudo force-pushed the @kudo/ui/fix-compose-fast-refresh branch from fb3baa9 to baa1223 Compare February 17, 2026 06:30

Kudo force-pushed the @kudo/ui/support-wiki-reader branch from 96e077d to bff1687 Compare February 17, 2026 06:30

Kudo changed the base branch from @kudo/ui/fix-compose-fast-refresh to graphite-base/42734 February 17, 2026 07:35

Kudo added 4 commits February 17, 2026 07:36

[core][ui] update jetpack compose apis to support the showcase

0e6e3dd

update changelog

389be38

fix ci errors

6ee08d3

fix ci errors

8875a64

Kudo force-pushed the graphite-base/42734 branch from baa1223 to cdb81aa Compare February 17, 2026 07:36

Kudo force-pushed the @kudo/ui/support-wiki-reader branch from bff1687 to a18b66f Compare February 17, 2026 07:36

graphite-app bot changed the base branch from graphite-base/42734 to main February 17, 2026 07:36

Apply suggestions from code review

d689237

--------- Co-authored-by: nishan (o^▽^o) <nishanbende@gmail.com>

Kudo force-pushed the @kudo/ui/support-wiki-reader branch from a18b66f to d689237 Compare February 17, 2026 07:36

Kudo merged commit cac0c20 into main Feb 17, 2026
14 of 17 checks passed

Kudo deleted the @kudo/ui/support-wiki-reader branch February 17, 2026 07:38

Conversation

Kudo commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

How

Test Plan

Checklist

Uh oh!

Kudo commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

expo-bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 31, 2026

Uh oh!

intergalacticspacehighway Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Kudo Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

intergalacticspacehighway Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Kudo Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

intergalacticspacehighway Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kudo Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

intergalacticspacehighway Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kudo Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

intergalacticspacehighway left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Kudo commented Feb 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Kudo commented Jan 30, 2026 •

edited

Loading

Kudo commented Jan 30, 2026 •

edited

Loading

expo-bot commented Jan 30, 2026 •

edited

Loading

intergalacticspacehighway Feb 16, 2026 •

edited

Loading

intergalacticspacehighway Feb 16, 2026 •

edited

Loading