[prebuild] remove deprecated edgeToEdgeEnabled field#42518
Conversation
e2d6417 to
91ba702
Compare
|
Subscribed to pull request
Generated by CodeMention |
| # Use this property to enable edge-to-edge display support. | ||
| # This allows your app to draw behind system bars for an immersive UI. | ||
| # Note: Only works with ReactActivity and should not be used with custom Activity. | ||
| edgeToEdgeEnabled=true |
There was a problem hiding this comment.
This is a react-native property, I believe we should leave it as is since it enables edge-to-edge on older Androids.
| # Use this property to enable edge-to-edge display support. | ||
| # This allows your app to draw behind system bars for an immersive UI. | ||
| # Note: Only works with ReactActivity and should not be used with custom Activity. | ||
| edgeToEdgeEnabled=true |
There was a problem hiding this comment.
Same as with BareExpo edgeToEdgeEnabled
| # Use this property to enable edge-to-edge display support. | ||
| # This allows your app to draw behind system bars for an immersive UI. | ||
| # Note: Only works with ReactActivity and should not be used with custom Activity. | ||
| edgeToEdgeEnabled=true |
|
|
||
| # Specifies whether the app is configured to use edge-to-edge via the app config or plugin | ||
| # WARNING: This property has been deprecated and will be removed in Expo SDK 55. Use `edgeToEdgeEnabled` or `react.edgeToEdgeEnabled` to determine whether the project is using edge-to-edge. | ||
| expo.edgeToEdgeEnabled=true |
There was a problem hiding this comment.
On the other hand this property is ours so it should be safe to remove.
| # Use this property to enable edge-to-edge display support. | ||
| # This allows your app to draw behind system bars for an immersive UI. | ||
| # Note: Only works with ReactActivity and should not be used with custom Activity. | ||
| edgeToEdgeEnabled=true |
There was a problem hiding this comment.
This is a react-native property, I think we shouldn't remove it as it enables edge-to-edge on older Androids
91ba702 to
ed502ca
Compare
de0bc03 to
f2882ed
Compare
f2882ed to
1cd076d
Compare
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|

Why
Remove the deprecated
edgeToEdgeEnabledproperty from Android configuration as edge to edge is mandatory when targeting Android 16+.How
edgeToEdgeEnabledproperty from all template app.json filesTest Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).