Skip to content

[prebuild] remove deprecated edgeToEdgeEnabled field#42518

Merged
vonovak merged 1 commit intomainfrom
vonovak__prebuild_remove_deprecated_edgetoedgeenabled_field
Jan 30, 2026
Merged

[prebuild] remove deprecated edgeToEdgeEnabled field#42518
vonovak merged 1 commit intomainfrom
vonovak__prebuild_remove_deprecated_edgetoedgeenabled_field

Conversation

@vonovak
Copy link
Copy Markdown
Contributor

@vonovak vonovak commented Jan 25, 2026

Why

Remove the deprecated edgeToEdgeEnabled property from Android configuration as edge to edge is mandatory when targeting Android 16+.

How

  • Removed the edgeToEdgeEnabled property from all template app.json files
  • Removed the property from gradle.properties files in various apps
  • Removed the related Gradle property configuration code in prebuild-config
  • Updated the ExpoConfig type definitions to remove the deprecated property
  • Added a warning when users still have the property in their config

Test Plan

  • green CI, successful example project prebuild+build

Checklist

  • This diff will work correctly for npx expo prebuild & EAS Build (eg: updated a module plugin).

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 25, 2026
Copy link
Copy Markdown
Contributor Author

vonovak commented Jan 25, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vonovak vonovak force-pushed the vonovak__prebuild_remove_deprecated_edgetoedgeenabled_field branch from e2d6417 to 91ba702 Compare January 25, 2026 19:29
@vonovak vonovak requested a review from behenate January 25, 2026 19:58
@vonovak vonovak marked this pull request as ready for review January 28, 2026 14:52
@github-actions
Copy link
Copy Markdown
Contributor

Subscribed to pull request

File Patterns Mentions
packages/@expo/config-types/** @EvanBacon, @douglowder
packages/@expo/prebuild-config/** @EvanBacon

Generated by CodeMention

# Use this property to enable edge-to-edge display support.
# This allows your app to draw behind system bars for an immersive UI.
# Note: Only works with ReactActivity and should not be used with custom Activity.
edgeToEdgeEnabled=true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a react-native property, I believe we should leave it as is since it enables edge-to-edge on older Androids.

# Use this property to enable edge-to-edge display support.
# This allows your app to draw behind system bars for an immersive UI.
# Note: Only works with ReactActivity and should not be used with custom Activity.
edgeToEdgeEnabled=true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with BareExpo edgeToEdgeEnabled

# Use this property to enable edge-to-edge display support.
# This allows your app to draw behind system bars for an immersive UI.
# Note: Only works with ReactActivity and should not be used with custom Activity.
edgeToEdgeEnabled=true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above


# Specifies whether the app is configured to use edge-to-edge via the app config or plugin
# WARNING: This property has been deprecated and will be removed in Expo SDK 55. Use `edgeToEdgeEnabled` or `react.edgeToEdgeEnabled` to determine whether the project is using edge-to-edge.
expo.edgeToEdgeEnabled=true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the other hand this property is ours so it should be safe to remove.

# Use this property to enable edge-to-edge display support.
# This allows your app to draw behind system bars for an immersive UI.
# Note: Only works with ReactActivity and should not be used with custom Activity.
edgeToEdgeEnabled=true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a react-native property, I think we shouldn't remove it as it enables edge-to-edge on older Androids

@vonovak vonovak force-pushed the vonovak__prebuild_remove_deprecated_edgetoedgeenabled_field branch from 91ba702 to ed502ca Compare January 30, 2026 15:08
@vonovak vonovak force-pushed the vonovak__prebuild_remove_deprecated_edgetoedgeenabled_field branch 2 times, most recently from de0bc03 to f2882ed Compare January 30, 2026 15:51
@vonovak vonovak force-pushed the vonovak__prebuild_remove_deprecated_edgetoedgeenabled_field branch from f2882ed to 1cd076d Compare January 30, 2026 15:53
@expo-bot
Copy link
Copy Markdown
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog, e.g.:
- remove deprecated edgeToEdgeEnabled field ([#42518](https://github.com/expo/expo/pull/42518) by [@vonovak](https://github.com/vonovak))
Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against 1cd076d

@vonovak vonovak requested a review from behenate January 30, 2026 15:57
@vonovak vonovak merged commit 34c94f4 into main Jan 30, 2026
31 of 32 checks passed
@vonovak vonovak deleted the vonovak__prebuild_remove_deprecated_edgetoedgeenabled_field branch January 30, 2026 16:33
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot: fingerprint compatible bot: suggestions ExpoBot has some suggestions published Changes from the PR have been published to npm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants