Skip to content

[android][camera] Support screen flash on front camera#41667

Merged
alanjhughes merged 1 commit intomainfrom
_alanhughes/camera/support-screen-flash
Dec 16, 2025
Merged

[android][camera] Support screen flash on front camera#41667
alanjhughes merged 1 commit intomainfrom
_alanhughes/camera/support-screen-flash

Conversation

@alanjhughes
Copy link
Copy Markdown
Collaborator

@alanjhughes alanjhughes commented Dec 16, 2025

Why

Add support for screen flash on android when using the front facing camera.

How

Add a new flash mode option screen. On iOS, this defaults to on.

Test Plan

bare-expo

Copy link
Copy Markdown
Collaborator Author

alanjhughes commented Dec 16, 2025

@expo-bot
Copy link
Copy Markdown
Collaborator

expo-bot commented Dec 16, 2025

The Pull Request introduced fingerprint changes against the base commit: f1afb83

Fingerprint diff
[
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo-camera/android",
      "reasons": [
        "expoAutolinkingAndroid"
      ],
      "hash": "28fcf542bf0540781ddd155cd23980d9f52b6779"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo-camera/android",
      "reasons": [
        "expoAutolinkingAndroid"
      ],
      "hash": "aabb038681224cfa364cc9c5e0cab5c4c2cdf61f"
    }
  },
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo-camera/ios",
      "reasons": [
        "expoAutolinkingIos"
      ],
      "hash": "5d42b53473049838fad013ff83981ad75e36c3cd"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo-camera/ios",
      "reasons": [
        "expoAutolinkingIos"
      ],
      "hash": "805f65a17ce619b3e5ff4596371439d0d7500876"
    }
  }
]

Generated by PR labeler 🤖

@alanjhughes alanjhughes force-pushed the _alanhughes/camera/support-screen-flash branch from 9a256c3 to d5ba714 Compare December 16, 2025 10:19
@alanjhughes alanjhughes force-pushed the _alanhughes/camera/support-video-stabilization branch from bef04f9 to 7126f7b Compare December 16, 2025 10:19
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Dec 16, 2025
@alanjhughes alanjhughes marked this pull request as ready for review December 16, 2025 10:23
@github-actions
Copy link
Copy Markdown
Contributor

Subscribed to pull request

File Patterns Mentions
packages/expo-camera/** @lukmccall

Generated by CodeMention

Copy link
Copy Markdown
Collaborator Author

alanjhughes commented Dec 16, 2025

Merge activity

  • Dec 16, 3:06 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 16, 3:09 PM UTC: Graphite rebased this pull request as part of a merge.
  • Dec 16, 3:10 PM UTC: @alanjhughes merged this pull request with Graphite.

@alanjhughes alanjhughes changed the base branch from _alanhughes/camera/support-video-stabilization to graphite-base/41667 December 16, 2025 15:07
@alanjhughes alanjhughes changed the base branch from graphite-base/41667 to main December 16, 2025 15:07
@alanjhughes alanjhughes force-pushed the _alanhughes/camera/support-screen-flash branch from d5ba714 to cf7066f Compare December 16, 2025 15:08
@alanjhughes alanjhughes merged commit 6a5785f into main Dec 16, 2025
10 of 11 checks passed
@alanjhughes alanjhughes deleted the _alanhughes/camera/support-screen-flash branch December 16, 2025 15:10
aleqsio pushed a commit that referenced this pull request Dec 22, 2025
# Why
Add support for screen flash on android when using the front facing camera.

# How
Add a new flash mode option `screen`. On iOS, this defaults to on.

# Test Plan
bare-expo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants