[ui][ios] - Add label support in Slider and match API with SwiftUI#41616
Merged
intergalacticspacehighway merged 12 commits intomainfrom Dec 15, 2025
Merged
[ui][ios] - Add label support in Slider and match API with SwiftUI#41616intergalacticspacehighway merged 12 commits intomainfrom
label support in Slider and match API with SwiftUI#41616intergalacticspacehighway merged 12 commits intomainfrom
Conversation
Contributor
|
Subscribed to pull request
Generated by CodeMention |
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: 3afa835 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-ui/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "7c9a5e136025514a785622ba170fa627c594eb27"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-ui/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "cd35c3281d0996f9152955f937c9295467960df5"
}
}
]Generated by PR labeler 🤖 |
Kudo
approved these changes
Dec 15, 2025
Contributor
Kudo
left a comment
There was a problem hiding this comment.
please fix NCL ci error before merge
| import { Host, Slider } from '@expo/ui/swift-ui'; | ||
|
|
||
| <Host style={{ minHeight: 60 }}> | ||
| ## Basic slider |
Member
There was a problem hiding this comment.
Suggested change
| ## Basic slider | |
| ## Usage | |
| ### Basic slider |
Similar suggestion here: #41628 (files).
|
|
||
| ```tsx LabeledSliderExample.tsx | ||
| import { useState } from 'react'; | ||
| import { Host, Slider, Text } from '@expo/ui/swift-ui'; |
Member
There was a problem hiding this comment.
Suggested change
| import { Host, Slider, Text } from '@expo/ui/swift-ui'; | |
| import { Host, Slider } from '@expo/ui/swift-ui'; | |
| import { Text } from 'react-native'; |
I suppose the Text component is imported from react-native here?
Contributor
Author
There was a problem hiding this comment.
same as popover's. we need it from swift-ui. will add docs for this next!
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
amandeepmittal
approved these changes
Dec 15, 2025
aleqsio
pushed a commit
that referenced
this pull request
Dec 22, 2025
…41616) # Why Matches API with SwiftUI and adds `label`, `minimumValueLabel`, `maximumValueLabel` support. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How - Uses separate constructors for Slider, this removes need for default values in step/min/max and some custom handling code for steps. - Removes color prop, `tint` modifier can be used to color the slider. - Kept the min/max prop as there is no better Range alternative in JS. Array might not make much sense since `Range` only has upper and lower bounds. - Updated docs for Slider <!-- How did you build this feature or fix this bug and why? --> # Test Plan Improved example UI screen, tested all scenarios. https://github.com/user-attachments/assets/f3502758-3242-468b-b764-920b40c43914 <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Aman Mittal <amandeepmittal@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Matches API with SwiftUI and adds
label,minimumValueLabel,maximumValueLabelsupport.How
tintmodifier can be used to color the slider.Rangeonly has upper and lower bounds.Test Plan
Improved example UI screen, tested all scenarios.
https://github.com/user-attachments/assets/f3502758-3242-468b-b764-920b40c43914
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).