Skip to content

[ui][iOS] Merge Circular/Linear progress components into one#41596

Merged
jakex7 merged 3 commits intomainfrom
@jakex7/uiMergeProgress
Dec 12, 2025
Merged

[ui][iOS] Merge Circular/Linear progress components into one#41596
jakex7 merged 3 commits intomainfrom
@jakex7/uiMergeProgress

Conversation

@jakex7
Copy link
Copy Markdown
Member

@jakex7 jakex7 commented Dec 12, 2025

Why

There is no reason for these components to be split into separate entities, in SwiftUI it's just a ProgressView.

How

Merged CircularProgress and LinearProgress into a single component.

Test Plan

Bare Expo

Checklist

@jakex7 jakex7 requested review from Kudo and aleqsio December 12, 2025 11:48
@github-actions
Copy link
Copy Markdown
Contributor

Subscribed to pull request

File Patterns Mentions
packages/expo-ui/** @aleqsio, @behenate, @douglowder

Generated by CodeMention

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Dec 12, 2025
@jakex7 jakex7 requested a review from behenate December 12, 2025 11:49
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Dec 12, 2025
Copy link
Copy Markdown
Member Author

jakex7 commented Dec 12, 2025

Copy link
Copy Markdown
Member

@behenate behenate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks much better now!

@jakex7 jakex7 merged commit 206f363 into main Dec 12, 2025
20 of 21 checks passed
@jakex7 jakex7 deleted the @jakex7/uiMergeProgress branch December 12, 2025 14:12
aleqsio pushed a commit that referenced this pull request Dec 22, 2025
# Why

There is no reason for these components to be split into separate entities, in SwiftUI it's just a `ProgressView`.

# How

Merged `CircularProgress` and `LinearProgress` into a single component. 

# Test Plan

Bare Expo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants