[ui][compose] move DynamicTheme as Host.colorScheme#41413
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: ed5035a Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-ui/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "04adccbab30396483749b362cdbc3024f7977043"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-ui/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "e1b4547ec0e2985c5063fae8e215d9fcddd6f64c"
}
}
]Generated by PR labeler 🤖 |
Contributor
|
Subscribed to pull request
Generated by CodeMention |
12dd64f to
3f745b1
Compare
3 tasks
aleqsio
approved these changes
Dec 11, 2025
Contributor
aleqsio
left a comment
There was a problem hiding this comment.
Looks good, thanks for the refactor!
3 tasks
kimchi-developer
pushed a commit
to kimchi-developer/expo
that referenced
this pull request
Dec 15, 2025
# Why move tight coupled `DynamicTheme` in native compose views into Host `colorScheme` prop # How - add dedicated HostView.kt - add `colorScheme` prop for Host - remove DynamicTheme
aleqsio
pushed a commit
that referenced
this pull request
Dec 22, 2025
# Why move tight coupled `DynamicTheme` in native compose views into Host `colorScheme` prop # How - add dedicated HostView.kt - add `colorScheme` prop for Host - remove DynamicTheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
move tight coupled
DynamicThemein native compose views into HostcolorSchemepropHow
colorSchemeprop for HostTest Plan
tested in NCL switch component (and switching colorScheme)
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).