fix(create-expo-nightly): Tighten workspace pattern#41410
Merged
Conversation
Contributor
|
Subscribed to pull request
Generated by CodeMention |
Kudo
requested changes
Dec 5, 2025
hassankhan
approved these changes
Dec 5, 2025
fbe88a9 to
6097b56
Compare
Kudo
approved these changes
Dec 9, 2025
gabrieldonadel
approved these changes
Dec 10, 2025
aleqsio
pushed a commit
that referenced
this pull request
Dec 22, 2025
# Why See CI failure in: https://github.com/expo/expo/actions/runs/19916741962/job/57096975273 Caused by symlink added in: #41383 # How - ~~Update the workspaces pattern to only find Expo package folders by workspace specifier name (mirroring the path in `Project.ts` and root `package.json:workspaces`)~~ - Ignore `local-template` in `@expo/cli` # Test Plan - CI should pass the mentioned run # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
See CI failure in: https://github.com/expo/expo/actions/runs/19916741962/job/57096975273
Caused by symlink added in: #41383
How
Update the workspaces pattern to only find Expo package folders by workspace specifier name (mirroring the path inProject.tsand rootpackage.json:workspaces)local-templatein@expo/cliTest Plan
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).