[core][iOS] Replace appContext.imageLoader with the core implementation#41396
Merged
[core][iOS] Replace appContext.imageLoader with the core implementation#41396
appContext.imageLoader with the core implementation#41396Conversation
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: 1ac84d3 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-image-loader/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "b0697c0ce6885b52cc9c32d02cdf54f5d056aba5"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-image-loader/ios",
"reasons": [
"expoAutolinkingIos"
],
"hash": "dfac49a2d0e68d27dd88294bb649233d87794e05"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "7a7c1d05c6b0afcac921753a366523e572ec704e"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "fe65a221d530aba4b3b3ba621339e2ccded1aee2"
}
}
]Generated by PR labeler 🤖 |
Collaborator
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
Contributor
|
Subscribed to pull request
Generated by CodeMention |
lukmccall
approved these changes
Dec 4, 2025
aleqsio
pushed a commit
that referenced
this pull request
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part of the effort to remove the legacy module registry from the AppContext.
How
Instead of depending on
expo-image-loader, I movedEXImageLoadertoexpo-modules-coreand let it be used without the module registry. Unfortunately, it still needs the bridge to get an instance ofRCTImageLoader. I'm not sure if there is any alternative right now, but at least we can move forward.As a followup, I'm removing the
expo-image-loaderpackage in #41395 as it's no longer needed on both platforms.Test Plan
The image loader was used only in
expo-cameraandexpo-image-manipulator– I tested them both in bare-expo.