Conversation
Contributor
|
Subscribed to pull request
Generated by CodeMention |
9c85e01 to
bd090fe
Compare
vonovak
approved these changes
Dec 4, 2025
Co-authored-by: Vojtech Novak <vonovak@gmail.com>
Collaborator
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: ed5035a Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "3bb286d0365a33550abac15b973cfbee6bf6746d"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-modules-core",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid",
"expoAutolinkingIos"
],
"hash": "7da7483f71ce550814088483fae82eec1bc9c554"
}
}
]Generated by PR labeler 🤖 |
kitten
added a commit
that referenced
this pull request
Dec 4, 2025
… requirements and bump (#41379) > [!NOTE] > Backport will at least be needed for SDK 54, maybe SDK 53, if the range is compatible with it We don't need to open up the range, and can set a new minimum as of latest publishing date. We can also bump our internal version. `jest-expo` had a hard dependency on `react-server-dom-webpack` which can also be switched to a peer dependency. - Tighten peer range on `react-server-dom-webpack` and bump - Switch `react-server-dom-webpack` to optional peers in `jest-expo` and bump - CI-only <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Vojtech Novak <vonovak@gmail.com>
3 tasks
kitten
added a commit
that referenced
this pull request
Dec 4, 2025
… requirements and bump (#41379) > [!NOTE] > Backport will at least be needed for SDK 54, maybe SDK 53, if the range is compatible with it We don't need to open up the range, and can set a new minimum as of latest publishing date. We can also bump our internal version. `jest-expo` had a hard dependency on `react-server-dom-webpack` which can also be switched to a peer dependency. - Tighten peer range on `react-server-dom-webpack` and bump - Switch `react-server-dom-webpack` to optional peers in `jest-expo` and bump - CI-only <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Vojtech Novak <vonovak@gmail.com>
This was referenced Dec 4, 2025
Merged
kitten
added a commit
that referenced
this pull request
Dec 4, 2025
…edNativeModules.json` and bump (#41417) # Why Related to: - #41379 - 8f714de # How - ~~Bump `react-server-dom-webpack` to align with `react` version on `sdk-54`~~ - Add to `bundledNativeModules.json` # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
kitten
added a commit
that referenced
this pull request
Dec 4, 2025
…edNativeModules.json` (#41429) # Why Related to: #41379 As stated in #41417, we won't bump `react-server-dom-webpack` for now for `expo/expo`, since the Flight format has changed and the debug information needs to be parsed and formatted # How - Add `react-server-dom-webpack` to `bundledNativeModules.json` # Test Plan - n/a # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
kitten
added a commit
that referenced
this pull request
Dec 4, 2025
…edNativeModules.json` (#41423) # Why Related to: - #41379 - a6674f5 # How - Add `react-server-dom-webpack` to `bundledNativeModules.json` # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
aleqsio
pushed a commit
that referenced
this pull request
Dec 5, 2025
… requirements and bump (#41379) # Why > [!NOTE] > Backport will at least be needed for SDK 54, maybe SDK 53, if the range is compatible with it We don't need to open up the range, and can set a new minimum as of latest publishing date. We can also bump our internal version. `jest-expo` had a hard dependency on `react-server-dom-webpack` which can also be switched to a peer dependency. # How - Tighten peer range on `react-server-dom-webpack` and bump - Switch `react-server-dom-webpack` to optional peers in `jest-expo` and bump # Test Plan - CI-only # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Vojtech Novak <vonovak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Note
Backport will at least be needed for SDK 54, maybe SDK 53, if the range is compatible with it
We don't need to open up the range, and can set a new minimum as of latest publishing date. We can also bump our internal version.
jest-expohad a hard dependency onreact-server-dom-webpackwhich can also be switched to a peer dependency.How
react-server-dom-webpackand bumpreact-server-dom-webpackto optional peers injest-expoand bumpTest Plan
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).