Conversation
Contributor
|
Subscribed to pull request
Generated by CodeMention |
Collaborator
|
@lukmccall it will still work in expo go in release? |
Contributor
Author
Not yet, it'll be added in the next PR. |
alanjhughes
approved these changes
Dec 3, 2025
gabrieldonadel
approved these changes
Dec 3, 2025
6611337 to
d48af82
Compare
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: ed5035a Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-dev-launcher",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "4afe0249e38331c00990d1bebc4ac54740b0ff97"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-dev-launcher",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "a2516dd2906d1e6b034b6b36d2a79ec0b6471754"
}
},
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-dev-menu",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "d45e48f64be9f8fa5c89b2a9c313293c63757eb3"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-dev-menu",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "212deeed099d254387b2c13f61d175527e1ec92f"
}
}
]Generated by PR labeler 🤖 |
aleqsio
pushed a commit
that referenced
this pull request
Dec 5, 2025
…ed in release builds (#41378)
|
@lukmccall This is a major security issue. Is there a possibility to have the fix in expo 54? We can't upgrade at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #41263.
How
Went through the dev-menu and dev-launcher code and ensured that all unwanted code, assets and dependencies will be removed in the release.
Test Plan