[dev-launcher] Restore config plugin#41363
Merged
gabrieldonadel merged 3 commits intomainfrom Dec 3, 2025
Merged
Conversation
Contributor
|
Subscribed to pull request
Generated by CodeMention |
alanjhughes
approved these changes
Dec 2, 2025
Collaborator
|
The Pull Request introduced fingerprint changes against the base commit: 5a2e7f8 Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-dev-launcher",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "957efb6e96036fc44431b24963152a834a12eae3"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-dev-launcher",
"reasons": [
"expoAutolinkingIos",
"expoAutolinkingAndroid"
],
"hash": "d6b8027ab1ad3bf4beaa49da1d4d33a240b2e45f"
}
}
]Generated by PR labeler 🤖 |
lukmccall
approved these changes
Dec 3, 2025
Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>
Collaborator
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
gabrieldonadel
added a commit
that referenced
this pull request
Dec 3, 2025
We've mistakenly removed the dev-launcher config plugin when we removed all the launcher React Native JS code in a20afd4 and then removed the remaining config plugin references in 1225627, causing the `launchMode` config to stop working, even though we still have this in our docs https://docs.expo.dev/versions/latest/sdk/dev-client/#example-appjson-with-config-plugin The ability of not launch directly into a previously opened project is quite useful when testing and we should restore it. `git revert --no-commit 1225627` and `git revert --no-commit a20afd4` 1. Modify app.json to include the `expo-dev-client` config plugin ``` "plugins": [ [ "expo-dev-client", { "launchMode": "most-recent" } ] ] ``` 2. Run npx prebuild 3. Build the app and observe <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>
aleqsio
pushed a commit
that referenced
this pull request
Dec 5, 2025
# Why We've mistakenly removed the dev-launcher config plugin when we removed all the launcher React Native JS code in a20afd4 and then removed the remaining config plugin references in 1225627, causing the `launchMode` config to stop working, even though we still have this in our docs https://docs.expo.dev/versions/latest/sdk/dev-client/#example-appjson-with-config-plugin The ability of not launch directly into a previously opened project is quite useful when testing and we should restore it. # How `git revert --no-commit 1225627` and `git revert --no-commit a20afd4` # Test Plan 1. Modify app.json to include the `expo-dev-client` config plugin ``` "plugins": [ [ "expo-dev-client", { "launchMode": "most-recent" } ] ] ``` 2. Run npx prebuild 3. Build the app and observe # Checklist <!-- Please check the appropriate items below if they apply to your diff. --> - [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
We've mistakenly removed the dev-launcher config plugin when we removed all the launcher React Native JS code in a20afd4 and then removed the remaining config plugin references in 1225627, causing the
launchModeconfig to stop working, even though we still have this in our docs https://docs.expo.dev/versions/latest/sdk/dev-client/#example-appjson-with-config-pluginThe ability of not launch directly into a previously opened project is quite useful when testing and we should restore it.
How
git revert --no-commit 1225627c1894426100f1c54ff9a3393e933c0adbandgit revert --no-commit a20afd4194e844902ee272af95f280b71f33f669Test Plan
expo-dev-clientconfig pluginChecklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).