[templates,autolinking] Switch back to `node -e` for `expo-modules-autolinking` invocation in `Podfile` command by kitten · Pull Request #41264 · expo/expo

kitten · 2025-11-26T17:45:17Z

Why

Effectively, this reverts #35661 but instead uses expo/bin/autolinking as a target for readability. A comment was added to denote this.

How

Replace the invocation with:

node --no-warnings --eval "require('expo/bin/autolinking')" expo-modules-autolinking

This resolves the target CLI directly without npx causing extra printing to stdout (in some affected v10 versions), and without performing extra installation, prompting, or resolution.

This differs in what we had previously to target expo/bin/autolinking to avoid the double require.resolve invocation.

The added expo-modules-autolinking argument is purely to shift argv and is arbitrary.

The PR was actually not having an effect on Android since the command there has been moved to the Gradle plugin. I've aligned the command there to be the same as for iOS. I've omitted -- since it's error-prone. It's not needed in this position, and can, under some circumstances, cause our flags to be ignored, so it's probably safer to leave out.

Test Plan

Manually invoked a local app iOS build with the command altered
E2E CI should cover this

Checklist

I added a changelog.md entry and rebuilt the package sources according to this short guide
This diff will work correctly for npx expo prebuild & EAS Build (eg: updated a module plugin).
Conforms with the Documentation Writing Style Guide

github-actions · 2025-11-26T17:45:33Z

Subscribed to pull request

File Patterns	Mentions
packages/expo/**	@ide, @lukmccall, @brentvatne
packages/expo-modules-autolinking/**	@Kudo, @lukmccall

Generated by CodeMention

expo-bot · 2025-11-26T17:49:27Z

The Pull Request introduced fingerprint changes against the base commit: 12b1bbc

Fingerprint diff

[
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid",
        "expoConfigPlugins",
        "expoConfigPlugins",
        "rncoreAutolinkingAndroid",
        "rncoreAutolinkingIos"
      ],
      "hash": "14462b0fc3028831eb53da3f4727465bab6f6dd7"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid",
        "expoConfigPlugins",
        "expoConfigPlugins",
        "rncoreAutolinkingAndroid",
        "rncoreAutolinkingIos"
      ],
      "hash": "640dc7bae8600211c170eb4049a8a0010f3097ca"
    }
  },
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "ios",
      "reasons": [
        "bareNativeDir"
      ],
      "hash": "e54eee6f8e64c685ca1a8a55d5443b8a1a78573e"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "ios",
      "reasons": [
        "bareNativeDir"
      ],
      "hash": "ea4bd2a02a4a739ae5dd44f6a60416616dde24c3"
    }
  }
]

Generated by PR labeler 🤖

Kudo

such a smart idea to pass the additional "expo-modules-autolinking" to reduce the -- and process.argv.slice(1) change.

thanks for helping that!

packages/expo/bin/autolinking

expo-bot · 2025-11-29T14:10:54Z

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries

Your changes should be noted in the changelog, e.g.:
- Switch back to node -eforexpo-modules-autolinkinginvocation inPodfile command ([#41264](https://github.com/expo/expo/pull/41264) by [@kitten](https://github.com/kitten))
Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:

packages/expo/CHANGELOG.md

Generated by ExpoBot 🤖 against 2f474e2

kitten · 2025-11-29T14:11:24Z

@lukmccall, @Kudo: I found some more scripts where this hasn't been aligned/switched over in scripts while looking at the pnpm migration. There's one script that technically changes behaviour but I don't think we care

kitten · 2025-11-29T14:12:21Z

packages/expo-modules-autolinking/scripts/ios/autolinking_manager.rb

-        'require(require.resolve(\'expo-modules-autolinking\', { paths: [\'' +  __dir__ + '\'] }))(process.argv.slice(1))',
+        'require(\'expo/bin/autolinking\')',
+        'expo-modules-autolinking',


This changes behaviour. Technically, we'd like to just avoid the self-require here, for our monorepo. However, there's little point in this one script resolving from "itself" rather than re-entering expo while the Android side doesn't bother doing this

The self-require specifically fails with pnpm in our own monorepo

gabrieldonadel

LGTM

…template (#41383) # Why > [!NOTE] > Supersedes #41306. > This hides the template way in a CLI dev-only dependency, so it's not as publicly visible, since it's only meant for our own testing and monorepo. We're often making changes to local templates, e.g.: - #41264 - #39418 Since we don't have a concept of local templates, we then have to make sure to specify a local prebuild template manually. However, this seems pretty redundant because `expo-template-bare-minimum` is just a package and in the monorepo. Failing to apply template changes to prebuild CNG folders often causes build issues on `main` as we upgrade React Native. Applying the monorepo template automatically seems like a good idea, since we then automatically test against any template changes on `main`. # How - Add `packages/@expo/cli/local-template -> templates/expo-template-bare-minimum` symlink - Exclude `/local-template` symlink explicitly in CLI's `.npmignore` - Extend `resolveLocalTemplateAsync` to try to load from `@expo/cli/local-template` locally first This means in `expo/expo`, we'll now always look at the up-to-date `templates/expo-template-bare-minimum` contents, instead of `expo/template.tgz` # Test Plan - CI covers this behaviour # Checklist - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) --------- Co-authored-by: Kudo Chien <kudo@expo.dev>

…tolinking` invocation in `Podfile` command (#41264) Effectively, this reverts #35661 but instead uses `expo/bin/autolinking` as a target for readability. A comment was added to denote this. Replace the invocation with: ```sh node --no-warnings --eval "require('expo/bin/autolinking')" expo-modules-autolinking ``` This resolves the target CLI directly without `npx` causing extra printing to `stdout` (in some affected v10 versions), and without performing extra installation, prompting, or resolution. This differs in what we had previously to target `expo/bin/autolinking` to avoid the double `require.resolve` invocation. The added `expo-modules-autolinking` argument is purely to shift `argv` and is arbitrary. The PR was actually not having an effect on Android since the command there has been moved to the Gradle plugin. I've aligned the command there to be the same as for iOS. I've omitted `--` since it's error-prone. It's not needed in this position, and can, under some circumstances, cause our flags to be ignored, so it's probably safer to leave out. - Manually invoked a local app iOS build with the command altered - E2E CI should cover this  - [x] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)

…es-autolinking invocation in Podfile command (#41953) Backport of #41264 / aae90cd **This is applied as a PR for an additional round of reviews, just to be safe.** Resolves #36952

kitten added 2 commits November 26, 2025 17:37

Switch from npx expo-modules-autolinking back to Node invocation

8aac0e1

Update apps

f051679

kitten requested review from Kudo and gabrieldonadel November 26, 2025 17:45

expo-bot added the bot: suggestions ExpoBot has some suggestions label Nov 26, 2025

Add CHANGELOG entry

e2681bd

kitten requested a review from byCedric November 26, 2025 17:48

github-actions bot added the bot: fingerprint changed label Nov 26, 2025

Kudo approved these changes Nov 27, 2025

View reviewed changes

packages/expo/bin/autolinking Outdated Show resolved Hide resolved

lukmccall approved these changes Nov 27, 2025

View reviewed changes

kitten added 2 commits November 29, 2025 12:36

Update comment

5886ac3

Fix up remaining scripts

2f474e2

kitten commented Nov 29, 2025

View reviewed changes

kitten requested review from Kudo and lukmccall November 29, 2025 14:12

This was referenced Nov 29, 2025

feat(cli,expo): Allow prebuild from local expo-template-bare-minimum peer installation #41306

Closed

Switch to pnpm using isolated installs #41288

Closed

Kudo approved these changes Dec 1, 2025

View reviewed changes

gabrieldonadel approved these changes Dec 1, 2025

View reviewed changes

kitten merged commit aae90cd into main Dec 1, 2025
31 of 33 checks passed

kitten deleted the @kitten/refactor/switch-back-to-node-autolinking-invocation branch December 1, 2025 21:07

kitten mentioned this pull request Dec 3, 2025

feat(cli): Allow prebuild from monorepo expo-template-bare-minimum template #41383

Merged

3 tasks

vonovak mentioned this pull request Dec 3, 2025

[ci] fix failing snapshot #41392

Merged

3 tasks

Kudo mentioned this pull request Dec 5, 2025

Inline modules - apps #40430

Closed

kitten mentioned this pull request Jan 6, 2026

[sdk-54][templates,autolinking] Switch back to node -e for expo-modules-autolinking invocation in Podfile command #41953

Merged

brentvatne added the published Changes from the PR have been published to npm label Jan 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[templates,autolinking] Switch back to `node -e` for `expo-modules-autolinking` invocation in `Podfile` command#41264

[templates,autolinking] Switch back to `node -e` for `expo-modules-autolinking` invocation in `Podfile` command#41264
kitten merged 5 commits intomainfrom
@kitten/refactor/switch-back-to-node-autolinking-invocation

kitten commented Nov 26, 2025

Uh oh!

github-actions bot commented Nov 26, 2025

Uh oh!

expo-bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

Kudo left a comment

Uh oh!

Uh oh!

expo-bot commented Nov 29, 2025

Uh oh!

kitten commented Nov 29, 2025

Uh oh!

kitten Nov 29, 2025 •

edited

Loading

Uh oh!

gabrieldonadel left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

kitten commented Nov 26, 2025

Why

How

Test Plan

Checklist

Uh oh!

github-actions bot commented Nov 26, 2025

Uh oh!

expo-bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kudo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

expo-bot commented Nov 29, 2025

Uh oh!

kitten commented Nov 29, 2025

Uh oh!

kitten Nov 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gabrieldonadel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

expo-bot commented Nov 26, 2025 •

edited

Loading

kitten Nov 29, 2025 •

edited

Loading