Skip to content

[ui][Android] Add support for modifiers in primitives, add clip modifier.#40164

Merged
aleqsio merged 5 commits intomainfrom
@aleqsio/10-02-add_support_for_modifiers_in_primitives_add_clip_modifier
Oct 8, 2025
Merged

[ui][Android] Add support for modifiers in primitives, add clip modifier.#40164
aleqsio merged 5 commits intomainfrom
@aleqsio/10-02-add_support_for_modifiers_in_primitives_add_clip_modifier

Conversation

@aleqsio
Copy link
Copy Markdown
Contributor

@aleqsio aleqsio commented Oct 2, 2025 •
edited
Loading

Why

Lets you use shapes as input to a new clip modifier.
Also lets you use modifiers in primitives.

How

Test Plan

Tested in BareExpo + build a UI component with it

Checklist

@aleqsio Graphite App
Copy link
Copy Markdown
Contributor Author

aleqsio commented Oct 2, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@aleqsio aleqsio mentioned this pull request Oct 2, 2025
Merged
3 tasks
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 2, 2025
@expo-bot
Copy link
Copy Markdown
Collaborator

expo-bot commented Oct 2, 2025 •
edited
Loading

The Pull Request introduced fingerprint changes against the base commit: c8754f6

Fingerprint diff 
[
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid"
      ],
      "hash": "78a5b155f0956fa4f2613a47f2da71bbc85d43cc"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid"
      ],
      "hash": "df5d62989e9881a61f45707a02284109a4ae30f1"
    }
  },
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo-ui/android",
      "reasons": [
        "expoAutolinkingAndroid"
      ],
      "hash": "d4ba336f173455cec2013f0eaaed1c1320c141e8"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo-ui/android",
      "reasons": [
        "expoAutolinkingAndroid"
      ],
      "hash": "5c12d8a4d35b60f60f9ea43a6097b2b50500f159"
    }
  }
]

Generated by PR labeler 🤖

@aleqsio aleqsio force-pushed the @aleqsio/10-01-add_custom_button_shapes branch from 4540aff to 38e5dd9 Compare October 6, 2025 09:04
@aleqsio aleqsio force-pushed the @aleqsio/10-02-add_support_for_modifiers_in_primitives_add_clip_modifier branch 2 times, most recently from cd03bf5 to 7cb6257 Compare October 6, 2025 09:21
@aleqsio aleqsio force-pushed the @aleqsio/10-01-add_custom_button_shapes branch from 38e5dd9 to 56a7a6b Compare October 6, 2025 09:21
@aleqsio aleqsio force-pushed the @aleqsio/10-02-add_support_for_modifiers_in_primitives_add_clip_modifier branch 3 times, most recently from ea037a2 to 48960f9 Compare October 6, 2025 11:38
@aleqsio aleqsio changed the title Add support for modifiers in primitives, add clip modifier. [ui][Android] Add support for modifiers in primitives, add clip modifier. Oct 6, 2025
@aleqsio aleqsio force-pushed the @aleqsio/10-02-add_support_for_modifiers_in_primitives_add_clip_modifier branch from b9b556e to 8124984 Compare October 6, 2025 12:51
@aleqsio aleqsio requested a review from Kudo October 6, 2025 12:59
@aleqsio aleqsio marked this pull request as ready for review October 6, 2025 12:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 6, 2025

Subscribed to pull request

File Patterns Mentions
packages/expo-modules-core/** @Kudo, @lukmccall
packages/expo-ui/** @behenate, @douglowder

Generated by CodeMention

@aleqsio aleqsio mentioned this pull request Oct 7, 2025
Merged
3 tasks
@aleqsio aleqsio force-pushed the @aleqsio/10-01-add_custom_button_shapes branch from 56a7a6b to 7f83b44 Compare October 7, 2025 15:16
@aleqsio aleqsio force-pushed the @aleqsio/10-02-add_support_for_modifiers_in_primitives_add_clip_modifier branch from 8124984 to d73f7cd Compare October 7, 2025 15:16
Base automatically changed from @aleqsio/10-01-add_custom_button_shapes to main October 7, 2025 15:17
@aleqsio aleqsio requested review from jakex7 and lukmccall October 7, 2025 15:17
@aleqsio aleqsio force-pushed the @aleqsio/10-02-add_support_for_modifiers_in_primitives_add_clip_modifier branch 3 times, most recently from ce70248 to 19322c6 Compare October 8, 2025 09:45
lukmccall
lukmccall approved these changes Oct 8, 2025
View reviewed changes
jakex7
jakex7 approved these changes Oct 8, 2025
View reviewed changes
@aleqsio
Add support for modifiers in primitives, add clip modifier.
07565a5 
Discard changes to apps/bare-expo/android/.idea/modules/app/BareExpo.app.main.iml
aleqsio and others added 4 commits October 8, 2025 14:51
@aleqsio @expo-bot
Update packages/expo-ui/CHANGELOG.md
4af877d 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@aleqsio @lukmccall
Apply suggestions from code review
f418b81 
Co-authored-by: Łukasz Kosmaty <kosmatylukasz@gmail.com>
@aleqsio
Fix
f85a49b
@aleqsio
Fix conflicts
f68c233
@aleqsio aleqsio force-pushed the @aleqsio/10-02-add_support_for_modifiers_in_primitives_add_clip_modifier branch from 3660826 to f68c233 Compare October 8, 2025 14:19
@expo-bot
Copy link
Copy Markdown
Collaborator

expo-bot commented Oct 8, 2025

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog, e.g.:
- [Android] Add support for modifiers in primitives, add clip modifier. ([#40164](https://github.com/expo/expo/pull/40164) by [@aleqsio](https://github.com/aleqsio))
Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:

Generated by ExpoBot 🤖 against f68c233

@aleqsio Graphite App
Copy link
Copy Markdown
Contributor Author

aleqsio commented Oct 8, 2025 •
edited
Loading

Merge activity

  • Oct 8, 3:42 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Oct 8, 3:43 PM UTC: @aleqsio merged this pull request with Graphite.

@aleqsio aleqsio merged commit 1e6441d into main Oct 8, 2025
14 checks passed
@aleqsio aleqsio deleted the @aleqsio/10-02-add_support_for_modifiers_in_primitives_add_clip_modifier branch October 8, 2025 15:43
doombladeoff pushed a commit to doombladeoff/expo that referenced this pull request Oct 9, 2025
@aleqsio @doombladeoff
[ui][Android] Add support for modifiers in primitives, add clip modif…
1e6d2de 
…ier. (expo#40164)

# Why

Lets you use shapes as input to a new clip modifier.
Also lets you use modifiers in primitives.

# How

<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

Tested in BareExpo + build a UI component with it

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
-->

- [ ] I added a `changelog.md` entry and rebuilt the package sources according to [this short guide](https://github.com/expo/expo/blob/main/CONTRIBUTING.md#-before-submitting)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
- [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
@Kudo Kudo added the published Changes from the PR have been published to npm label Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kudo Kudo Kudo approved these changes

@lukmccall lukmccall lukmccall approved these changes

@jakex7 jakex7 jakex7 approved these changes

Assignees

No one assigned

Labels

bot: fingerprint changed bot: suggestions ExpoBot has some suggestions published Changes from the PR have been published to npm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aleqsio @expo-bot @Kudo @lukmccall @jakex7