Subscribed to pull request

Generated by CodeMention

The Pull Request introduced fingerprint changes against the base commit: 6be2724

[
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid"
      ],
      "hash": "49fa089379ae54b1cbb9dfff3960bead61efbd17"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo-modules-core",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid"
      ],
      "hash": "81925512cd02102f741e642d53957db2fb08da0b"
    }
  }
]

Generated by PR labeler 🤖

@Kudo: quick question: what is the static function in this context? is that a function binding to the shared object instance and not binding to object's prototype?

It's function bound to the object's constructor, making it the 'standard' javascript static method on a class.

For example, we could have a shared object called File that includes a static function create, which creates a new instance so it could be used like File.create(path)

It's function bound to the object's constructor, making it the 'standard' javascript static method on a class.

For example, we could have a shared object called File that includes a static function create, which creates a new instance so it could be used like File.create(path)

cool, thanks for this clarification. wdyt to rename it as ClassStaticFunction to make it clearer?

wdyt to rename it as ClassStaticFunction to make it clearer?

@jakex7 did you consider this option? when i first seen this i was confused what the "static" until you explained it. i guess ClassStaticFunction would be a clearer name.

wdyt to rename it as ClassStaticFunction to make it clearer?

@jakex7 did you consider this option? when i first seen this i was confused what the "static" until you explained it. i guess ClassStaticFunction would be a clearer name.

@Kudo

Sorry for not responding earlier. Yes, I’ve considered that, but I’m not sure if it’s the best approach. It can only be used within a Class context, so that does imply it’s class-related. On the other hand, we don’t typically use the "Class" prefix for other elements - for example, we use Property instead of ClassProperty. That said, I don’t have a strong opinion either way. If you still think that renaming it would improve clarity, I’m happy to make the change.

On the other hand, we don’t typically use the "Class" prefix for other elements - for example, we use Property instead of ClassProperty

wait. i was thinking that Property is binded to instance, not class itself . from the example, it looks like

object = new expo.modules.TestModule.Counter(0);
object.currentValue

does it also work like expo.modules.TestModule.Counter.currentValue?