Skip to content

[android][ui] Add Material3 BottomSheet component#37553

Merged
aleqsio merged 13 commits intoexpo:mainfrom
Jeroen-G:ui-android-bottomsheet
Oct 8, 2025
Merged

[android][ui] Add Material3 BottomSheet component#37553
aleqsio merged 13 commits intoexpo:mainfrom
Jeroen-G:ui-android-bottomsheet

Conversation

@Jeroen-G
Copy link
Copy Markdown
Contributor

@Jeroen-G Jeroen-G commented Jun 21, 2025

Why / How

This PR add an Android native bottom sheet using Jetpack Compose's ModalBottomSheet because it was missing next to the already existing iOS version.

Test Plan

  1. Open the app bare-expo in an Android emulator/device
  2. Go to Components > Expo UI > BottomSheet component
  3. Toggle BottomSheet

Checklist

To do

  • Figure out why content is not shown in the bottomsheet
  • Figure out why the event from Kotlin-land is not received in RN-land
  • Fix bug where app freezes after dismissing bottomsheet
  • Clean up code and complete PR description, add screenshot

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jun 21, 2025
@Jeroen-G Jeroen-G force-pushed the ui-android-bottomsheet branch from eb95cc9 to 90fbbbc Compare June 21, 2025 14:26
@Jeroen-G Jeroen-G force-pushed the ui-android-bottomsheet branch 2 times, most recently from 3e5bd8c to d5f3514 Compare July 6, 2025 16:56
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jul 6, 2025
@Jeroen-G Jeroen-G force-pushed the ui-android-bottomsheet branch 2 times, most recently from 4c061fa to c534e68 Compare July 6, 2025 17:02
@Jeroen-G Jeroen-G marked this pull request as ready for review July 6, 2025 17:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 6, 2025

Subscribed to pull request

File Patterns Mentions
docs/** @amandeepmittal
packages/expo-ui/** @aleqsio, @behenate, @douglowder

Generated by CodeMention

@aleqsio aleqsio requested review from aleqsio and behenate July 7, 2025 10:10
Copy link
Copy Markdown
Member

@amandeepmittal amandeepmittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs change looks good, thanks!

@Jeroen-G Jeroen-G force-pushed the ui-android-bottomsheet branch from 2488acd to 4fafd6e Compare July 11, 2025 12:29
@Jeroen-G Jeroen-G requested a review from aleqsio September 9, 2025 00:46
@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions and removed bot: passed checks ExpoBot has nothing to complain about labels Sep 11, 2025
Copy link
Copy Markdown
Contributor

@aleqsio aleqsio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I tested and it behaves as expected with children!

@Jeroen-G
Copy link
Copy Markdown
Contributor Author

Thanks for pushing those fixes @aleqsio!

@focux
Copy link
Copy Markdown
Contributor

focux commented Sep 30, 2025

Is there an ETA for this to make it into Expo UI? 👀

@ddeveloper2023
Copy link
Copy Markdown

Any updates on when this will be part of Expo UI?

@aleqsio aleqsio force-pushed the ui-android-bottomsheet branch from 4a3d4ca to a1786ee Compare October 8, 2025 15:50
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Oct 8, 2025
@aleqsio aleqsio merged commit c29345d into expo:main Oct 8, 2025
10 checks passed
doombladeoff pushed a commit to doombladeoff/expo that referenced this pull request Oct 9, 2025
Co-authored-by: Vincent Hagen <blackshadev@users.noreply.github.com>
Co-authored-by: aleqsio <mikucki@gmail.com>
@Kudo Kudo added the published Changes from the PR have been published to npm label Nov 6, 2025
@erickreutz
Copy link
Copy Markdown
Contributor

Where is the documentation for this component? Looking at the pull requests, I'm kind of confused as to where it ended up.

@amandeepmittal
Copy link
Copy Markdown
Member

Where is the documentation for this component? Looking at the pull requests, I'm kind of confused as to where it ended up.

Hey @erickreutz, it's under the "Next" unversioned docs here: https://docs.expo.dev/versions/unversioned/sdk/ui/jetpack-compose/bottomsheet/.

@erickreutz
Copy link
Copy Markdown
Contributor

@amandeepmittal thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants