[android][ui] Add Material3 BottomSheet component#37553
Conversation
eb95cc9 to
90fbbbc
Compare
3e5bd8c to
d5f3514
Compare
4c061fa to
c534e68
Compare
|
Subscribed to pull request
Generated by CodeMention |
amandeepmittal
left a comment
There was a problem hiding this comment.
Docs change looks good, thanks!
packages/expo-ui/android/src/main/java/expo/modules/ui/BottomSheetView.kt
Outdated
Show resolved
Hide resolved
packages/expo-ui/android/src/main/java/expo/modules/ui/BottomSheetView.kt
Outdated
Show resolved
Hide resolved
apps/native-component-list/src/screens/UI/BottomSheetScreen.android.tsx
Outdated
Show resolved
Hide resolved
2488acd to
4fafd6e
Compare
aleqsio
left a comment
There was a problem hiding this comment.
Looks good, I tested and it behaves as expected with children!
|
Thanks for pushing those fixes @aleqsio! |
|
Is there an ETA for this to make it into Expo UI? 👀 |
|
Any updates on when this will be part of Expo UI? |
Co-Authored-By: Vincent Hagen <blackshadev@users.noreply.github.com>
4a3d4ca to
a1786ee
Compare
Co-authored-by: Vincent Hagen <blackshadev@users.noreply.github.com> Co-authored-by: aleqsio <mikucki@gmail.com>
|
Where is the documentation for this component? Looking at the pull requests, I'm kind of confused as to where it ended up. |
Hey @erickreutz, it's under the "Next" unversioned docs here: https://docs.expo.dev/versions/unversioned/sdk/ui/jetpack-compose/bottomsheet/. |
|
@amandeepmittal thank you! |
Why / How
This PR add an Android native bottom sheet using Jetpack Compose's ModalBottomSheet because it was missing next to the already existing iOS version.
Test Plan
bare-expoin an Android emulator/deviceChecklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).To do