[1/n] upgrade to react-native 0.77 - fabric-tester by vonovak · Pull Request #33379 · expo/expo

vonovak · 2024-12-03T10:32:11Z

Why

How

reason dev-launcher is rebuilt is this, which caused this error for many native modules
upgraded fabric-tester to RN 0.77, removed deprecated expo-av from the app
still need to check expo-image, it seems to not render for some reason

Test Plan

fabric tester app builds and runs

Checklist

Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
Conforms with the Documentation Writing Style Guide
This diff will work correctly for npx expo prebuild & EAS Build (eg: updated a module plugin).

vonovak · 2024-12-03T10:32:27Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

expo-bot · 2024-12-03T10:34:52Z

The Pull Request introduced fingerprint changes against the base commit: 122c42f

Fingerprint diff

[
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo-dev-launcher",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid"
      ],
      "hash": "00ecc49f50853ba502b0608a486d44d0636efb2e"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo-dev-launcher",
      "reasons": [
        "expoAutolinkingIos",
        "expoAutolinkingAndroid"
      ],
      "hash": "32f8ac1e244eb471c28dda674b378447d8446576"
    }
  },
  {
    "op": "changed",
    "beforeSource": {
      "type": "contents",
      "id": "package:react-native",
      "contents": "{\"name\":\"react-native\",\"version\":\"0.76.3\",\"description\":\"A framework for building native apps using React\",\"license\":\"MIT\",\"repository\":{\"type\":\"git\",\"url\":\"git+https://github.com/facebook/react-native.git\",\"directory\":\"packages/react-native\"},\"homepage\":\"https://reactnative.dev/\",\"keywords\":[\"react\",\"react-native\",\"android\",\"ios\",\"mobile\",\"cross-platform\",\"app-framework\",\"mobile-development\"],\"bugs\":\"https://github.com/facebook/react-native/issues\",\"engines\":{\"node\":\">=18\"},\"bin\":{\"react-native\":\"cli.js\"},\"types\":\"types\",\"jest-junit\":{\"outputDirectory\":\"reports/junit\",\"outputName\":\"js-test-results.xml\"},\"files\":[\"android\",\"build.gradle.kts\",\"cli.js\",\"flow\",\"gradle.properties\",\"gradle/libs.versions.toml\",\"index.js\",\"interface.js\",\"jest-preset.js\",\"jest\",\"Libraries\",\"LICENSE\",\"React-Core.podspec\",\"react-native.config.js\",\"React.podspec\",\"React\",\"!React/Fabric/RCTThirdPartyFabricComponentsProvider.*\",\"ReactAndroid\",\"ReactApple\",\"ReactCommon\",\"README.md\",\"rn-get-polyfills.js\",\"scripts/compose-source-maps.js\",\"scripts/find-node-for-xcode.sh\",\"scripts/bundle.js\",\"scripts/generate-codegen-artifacts.js\",\"scripts/generate-provider-cli.js\",\"scripts/generate-specs-cli.js\",\"scripts/codegen\",\"!scripts/codegen/__tests__\",\"!scripts/codegen/__test_fixtures__\",\"scripts/hermes/hermes-utils.js\",\"scripts/hermes/prepare-hermes-for-build.js\",\"scripts/ios-configure-glog.sh\",\"scripts/xcode/ccache-clang++.sh\",\"scripts/xcode/ccache-clang.sh\",\"scripts/xcode/ccache.conf\",\"scripts/xcode/with-environment.sh\",\"scripts/native_modules.rb\",\"scripts/node-binary.sh\",\"scripts/packager.sh\",\"scripts/packager-reporter.js\",\"scripts/react_native_pods_utils/script_phases.rb\",\"scripts/react_native_pods_utils/script_phases.sh\",\"scripts/react_native_pods.rb\",\"scripts/cocoapods\",\"!scripts/cocoapods/__tests__\",\"scripts/react-native-xcode.sh\",\"sdks/.hermesversion\",\"sdks/hermes-engine\",\"sdks/hermesc\",\"settings.gradle.kts\",\"src\",\"template.config.js\",\"template\",\"!template/node_modules\",\"!template/package-lock.json\",\"!template/yarn.lock\",\"third-party-podspecs\",\"types\"],\"scripts\":{\"prepack\":\"node ./scripts/prepack.js\",\"featureflags-check\":\"node ./scripts/featureflags/index.js --verify-unchanged\",\"featureflags-update\":\"node ./scripts/featureflags/index.js\"},\"peerDependencies\":{\"@types/react\":\"^18.2.6\",\"react\":\"^18.2.0\"},\"peerDependenciesMeta\":{\"@types/react\":{\"optional\":true}},\"dependencies\":{\"@jest/create-cache-key-function\":\"^29.6.3\",\"@react-native/assets-registry\":\"0.76.3\",\"@react-native/codegen\":\"0.76.3\",\"@react-native/community-cli-plugin\":\"0.76.3\",\"@react-native/gradle-plugin\":\"0.76.3\",\"@react-native/js-polyfills\":\"0.76.3\",\"@react-native/normalize-colors\":\"0.76.3\",\"@react-native/virtualized-lists\":\"0.76.3\",\"abort-controller\":\"^3.0.0\",\"anser\":\"^1.4.9\",\"ansi-regex\":\"^5.0.0\",\"babel-jest\":\"^29.7.0\",\"babel-plugin-syntax-hermes-parser\":\"^0.23.1\",\"base64-js\":\"^1.5.1\",\"chalk\":\"^4.0.0\",\"commander\":\"^12.0.0\",\"event-target-shim\":\"^5.0.1\",\"flow-enums-runtime\":\"^0.0.6\",\"glob\":\"^7.1.1\",\"invariant\":\"^2.2.4\",\"jest-environment-node\":\"^29.6.3\",\"jsc-android\":\"^250231.0.0\",\"memoize-one\":\"^5.0.0\",\"metro-runtime\":\"^0.81.0\",\"metro-source-map\":\"^0.81.0\",\"mkdirp\":\"^0.5.1\",\"nullthrows\":\"^1.1.1\",\"pretty-format\":\"^29.7.0\",\"promise\":\"^8.3.0\",\"react-devtools-core\":\"^5.3.1\",\"react-refresh\":\"^0.14.0\",\"regenerator-runtime\":\"^0.13.2\",\"scheduler\":\"0.24.0-canary-efb381bbf-20230505\",\"semver\":\"^7.1.3\",\"stacktrace-parser\":\"^0.1.10\",\"whatwg-fetch\":\"^3.0.0\",\"ws\":\"^6.2.3\",\"yargs\":\"^17.6.2\"},\"codegenConfig\":{\"libraries\":[{\"name\":\"FBReactNativeSpec\",\"type\":\"modules\",\"ios\":{},\"android\":{},\"jsSrcsDir\":\"src\"},{\"name\":\"rncore\",\"type\":\"components\",\"ios\":{},\"android\":{},\"jsSrcsDir\":\"src\"}]}}",
      "reasons": [
        "package:react-native"
      ],
      "hash": "b7d9c2644e20b13bed5cfc44b987aed00a683b8d"
    },
    "afterSource": {
      "type": "contents",
      "id": "package:react-native",
      "contents": "{\"name\":\"react-native\",\"version\":\"0.77.0-rc.6\",\"description\":\"A framework for building native apps using React\",\"license\":\"MIT\",\"repository\":{\"type\":\"git\",\"url\":\"git+https://github.com/facebook/react-native.git\",\"directory\":\"packages/react-native\"},\"homepage\":\"https://reactnative.dev/\",\"keywords\":[\"react\",\"react-native\",\"android\",\"ios\",\"mobile\",\"cross-platform\",\"app-framework\",\"mobile-development\"],\"bugs\":\"https://github.com/facebook/react-native/issues\",\"engines\":{\"node\":\">=18\"},\"bin\":{\"react-native\":\"cli.js\"},\"types\":\"types\",\"jest-junit\":{\"outputDirectory\":\"reports/junit\",\"outputName\":\"js-test-results.xml\"},\"files\":[\"android\",\"build.gradle.kts\",\"cli.js\",\"flow\",\"gradle.properties\",\"gradle/libs.versions.toml\",\"index.js\",\"interface.js\",\"jest-preset.js\",\"jest\",\"Libraries\",\"LICENSE\",\"React-Core.podspec\",\"react-native.config.js\",\"React.podspec\",\"React\",\"!React/Fabric/RCTThirdPartyFabricComponentsProvider.*\",\"ReactAndroid\",\"ReactApple\",\"ReactCommon\",\"README.md\",\"rn-get-polyfills.js\",\"scripts/compose-source-maps.js\",\"scripts/find-node-for-xcode.sh\",\"scripts/bundle.js\",\"scripts/generate-codegen-artifacts.js\",\"scripts/generate-provider-cli.js\",\"scripts/generate-specs-cli.js\",\"scripts/codegen\",\"!scripts/codegen/__tests__\",\"!scripts/codegen/__test_fixtures__\",\"scripts/hermes/hermes-utils.js\",\"scripts/hermes/prepare-hermes-for-build.js\",\"scripts/ios-configure-glog.sh\",\"scripts/xcode/ccache-clang++.sh\",\"scripts/xcode/ccache-clang.sh\",\"scripts/xcode/ccache.conf\",\"scripts/xcode/with-environment.sh\",\"scripts/native_modules.rb\",\"scripts/node-binary.sh\",\"scripts/packager.sh\",\"scripts/packager-reporter.js\",\"scripts/react_native_pods_utils/script_phases.rb\",\"scripts/react_native_pods_utils/script_phases.sh\",\"scripts/react_native_pods.rb\",\"scripts/cocoapods\",\"!scripts/cocoapods/__tests__\",\"scripts/react-native-xcode.sh\",\"sdks/.hermesversion\",\"sdks/hermes-engine\",\"sdks/hermesc\",\"settings.gradle.kts\",\"src\",\"template.config.js\",\"template\",\"!template/node_modules\",\"!template/package-lock.json\",\"!template/yarn.lock\",\"third-party-podspecs\",\"types\"],\"scripts\":{\"prepack\":\"node ./scripts/prepack.js\",\"featureflags\":\"node ./scripts/featureflags/index.js\"},\"peerDependencies\":{\"@types/react\":\"^18.2.6\",\"react\":\"^18.2.0\"},\"peerDependenciesMeta\":{\"@types/react\":{\"optional\":true}},\"dependencies\":{\"@jest/create-cache-key-function\":\"^29.6.3\",\"@react-native/assets-registry\":\"0.77.0-rc.6\",\"@react-native/codegen\":\"0.77.0-rc.6\",\"@react-native/community-cli-plugin\":\"0.77.0-rc.6\",\"@react-native/gradle-plugin\":\"0.77.0-rc.6\",\"@react-native/js-polyfills\":\"0.77.0-rc.6\",\"@react-native/normalize-colors\":\"0.77.0-rc.6\",\"@react-native/virtualized-lists\":\"0.77.0-rc.6\",\"abort-controller\":\"^3.0.0\",\"anser\":\"^1.4.9\",\"ansi-regex\":\"^5.0.0\",\"babel-jest\":\"^29.7.0\",\"babel-plugin-syntax-hermes-parser\":\"0.25.1\",\"base64-js\":\"^1.5.1\",\"chalk\":\"^4.0.0\",\"commander\":\"^12.0.0\",\"event-target-shim\":\"^5.0.1\",\"flow-enums-runtime\":\"^0.0.6\",\"glob\":\"^7.1.1\",\"invariant\":\"^2.2.4\",\"jest-environment-node\":\"^29.6.3\",\"jsc-android\":\"^250231.0.0\",\"memoize-one\":\"^5.0.0\",\"metro-runtime\":\"^0.81.0\",\"metro-source-map\":\"^0.81.0\",\"nullthrows\":\"^1.1.1\",\"pretty-format\":\"^29.7.0\",\"promise\":\"^8.3.0\",\"react-devtools-core\":\"^6.0.1\",\"react-refresh\":\"^0.14.0\",\"regenerator-runtime\":\"^0.13.2\",\"scheduler\":\"0.24.0-canary-efb381bbf-20230505\",\"semver\":\"^7.1.3\",\"stacktrace-parser\":\"^0.1.10\",\"whatwg-fetch\":\"^3.0.0\",\"ws\":\"^6.2.3\",\"yargs\":\"^17.6.2\"},\"codegenConfig\":{\"libraries\":[{\"name\":\"FBReactNativeSpec\",\"type\":\"modules\",\"ios\":{},\"android\":{},\"jsSrcsDir\":\"src\"},{\"name\":\"rncore\",\"type\":\"components\",\"ios\":{},\"android\":{},\"jsSrcsDir\":\"src\"}]}}",
      "reasons": [
        "package:react-native"
      ],
      "hash": "56a82d3d0eb11a360fb77983a96020f59dc3ebdd"
    }
  }
]

Generated by PR labeler 🤖

brentvatne · 2024-12-10T18:40:59Z

 import com.facebook.react.ReactNativeHost
 import com.facebook.react.bridge.ReactContext
 import com.facebook.react.common.LifecycleState
+import com.facebook.react.common.annotations.UnstableReactNativeAPI


we need to make sure that anything we do here is also compatible with 0.76

gabrieldonadel

LGTM

gabrieldonadel · 2025-01-06T12:33:52Z

+        {mounted && (
+          <LinearGradient
+            style={{ flex: 1 }}
+            colors={colors as unknown as readonly [string, string, string]}


just a nit but wouldn't it be easier to type this inside the useState<>?

added a function that returns correctly typed result which is cleaner, TY 👍

github-actions · 2025-01-08T10:38:08Z

Subscribed to pull request

File Patterns	Mentions
packages/expo-dev-launcher/**	@lukmccall, @douglowder, @gabrieldonadel

Generated by CodeMention

vonovak · 2025-01-08T10:38:28Z

Merge activity

Jan 8, 5:38 AM EST: A user started a stack merge that includes this pull request via Graphite.
Jan 8, 5:38 AM EST: A user merged this pull request with Graphite.

expo-bot added the bot: suggestions ExpoBot has some suggestions label Dec 3, 2024

github-actions Bot added the bot: fingerprint changed label Dec 3, 2024

vonovak force-pushed the @vonovak/_1_n_upgrade_to_react-native_0.77 branch from 27eee59 to 1ce1386 Compare December 4, 2024 09:54

brentvatne reviewed Dec 10, 2024

View reviewed changes

vonovak force-pushed the @vonovak/_1_n_upgrade_to_react-native_0.77 branch 3 times, most recently from 1e26208 to b90c17d Compare December 19, 2024 16:35

vonovak force-pushed the @vonovak/_1_n_upgrade_to_react-native_0.77 branch 3 times, most recently from 31b41b3 to c240442 Compare January 5, 2025 11:39

This was referenced Jan 5, 2025

[2/n] upgrade to react-native 0.77 - packages #33946

Merged

[3/n] upgrade to react-native 0.77 - bare-expo #33947

Merged

vonovak changed the title ~~[1/n] upgrade to react-native 0.77~~ [1/n] upgrade to react-native 0.77 - fabric-tested Jan 5, 2025

vonovak changed the title ~~[1/n] upgrade to react-native 0.77 - fabric-tested~~ [1/n] upgrade to react-native 0.77 - fabric-tester Jan 5, 2025

vonovak force-pushed the @vonovak/_1_n_upgrade_to_react-native_0.77 branch 2 times, most recently from c4f4f75 to 9297ead Compare January 6, 2025 10:11

gabrieldonadel approved these changes Jan 6, 2025

View reviewed changes

vonovak force-pushed the @vonovak/_1_n_upgrade_to_react-native_0.77 branch 3 times, most recently from c131804 to 52c4c0a Compare January 8, 2025 03:45

expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 8, 2025

vonovak force-pushed the @vonovak/_1_n_upgrade_to_react-native_0.77 branch from 52c4c0a to bba52ad Compare January 8, 2025 04:26

vonovak added 2 commits January 8, 2025 17:46

[1/n] upgrade to react-native 0.77

8440f66

update devLauncher for RN 77

29c7138

vonovak force-pushed the @vonovak/_1_n_upgrade_to_react-native_0.77 branch from bba52ad to 29c7138 Compare January 8, 2025 09:46

vonovak marked this pull request as ready for review January 8, 2025 10:37

vonovak merged commit 7cc4485 into main Jan 8, 2025

vonovak deleted the @vonovak/_1_n_upgrade_to_react-native_0.77 branch January 8, 2025 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[1/n] upgrade to react-native 0.77 - fabric-tester#33379

[1/n] upgrade to react-native 0.77 - fabric-tester#33379
vonovak merged 2 commits intomainfrom
@vonovak/_1_n_upgrade_to_react-native_0.77

vonovak commented Dec 3, 2024 •

edited

Loading

Uh oh!

vonovak commented Dec 3, 2024 •

edited

Loading

Uh oh!

expo-bot commented Dec 3, 2024 •

edited

Loading

Uh oh!

brentvatne Dec 10, 2024

Uh oh!

gabrieldonadel left a comment

Uh oh!

gabrieldonadel Jan 6, 2025

Uh oh!

vonovak Jan 7, 2025

Uh oh!

github-actions Bot commented Jan 8, 2025

Uh oh!

vonovak commented Jan 8, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vonovak commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

How

Test Plan

Checklist

Uh oh!

vonovak commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

expo-bot commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brentvatne Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

gabrieldonadel left a comment

Choose a reason for hiding this comment

Uh oh!

gabrieldonadel Jan 6, 2025

Choose a reason for hiding this comment

Uh oh!

vonovak Jan 7, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 8, 2025

Uh oh!

vonovak commented Jan 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vonovak commented Dec 3, 2024 •

edited

Loading

vonovak commented Dec 3, 2024 •

edited

Loading

expo-bot commented Dec 3, 2024 •

edited

Loading

vonovak commented Jan 8, 2025 •

edited

Loading