Conversation
Cargo in the latest version upgraded the server dependency (rust-lang/cargo#9508). As a result, it no longer accepts "" as a version. So we now use a specific version of all such usage.
aykhm
reviewed
Jul 30, 2021
Contributor
aykhm
left a comment
There was a problem hiding this comment.
You can also use "*" as the semver if you want to keep some of the versions unspecified like before
Contributor
Author
I thought about that, but since we use major.minor level of specification for other crates, went with that for consistency. |
fx-chun
approved these changes
Jul 30, 2021
shadaj
pushed a commit
that referenced
this pull request
Apr 20, 2023
* Fix cargo failures on rust version 1.54 Cargo in the latest version upgraded the server dependency (rust-lang/cargo#9508). As a result, it no longer accepts "" as a version. So we now use a specific version of all such usage. * Fix new clippy warnings new to Rust 1.54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo in the latest version upgraded the server dependency (rust-lang/cargo#9508). As a result, it no longer accepts "" as a version. So we now use a specific version of all such usage.