fix: use jsdelivr CDN for ipywidgets#491
Conversation
|
@choldgraf let's see the rendered PR docs, and judge if this did indeed work! |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #491 +/- ##
=======================================
Coverage 81.47% 81.47%
=======================================
Files 29 29
Lines 2618 2618
=======================================
Hits 2133 2133
Misses 485 485
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…lebooks/MyST-NB into agoose77/fix-add-ipywidgets-cdn
choldgraf
left a comment
There was a problem hiding this comment.
I believe that it works! Good catch:
| }, | ||
| # Load IPywidgets bundle for embedding. | ||
| "https://unpkg.com/@jupyter-widgets/html-manager@^0.20.0/dist/embed-amd.js": { | ||
| "https://cdn.jsdelivr.net/npm/@jupyter-widgets/html-manager@1.0.6/dist/embed-amd.js": { |
There was a problem hiding this comment.
can we add a comment here that provides a loose guidelines for when/how to update this import link? Or maybe just a block comment at the top of the #Load IPywidgets.. section? doesn't need to block if you don't have the time, but I feel like you brought some valuable domain-knowledge to this fix that could be useful for others
There was a problem hiding this comment.
Hehe, we're on the same wavelength: 2deaa40
|
@choldgraf merge if you're happy! |
* fix: use jsdelivr CDN * chore: bump ipywidgets version to 8.0 * docs: add note about ipywidgets
Should fix #458, supercedes #469