Skip to content

checking extension before reading to check outputs#132

Merged
chrisjsewell merged 3 commits intoexecutablebooks:masterfrom
AakashGfude:checking-ext
Apr 6, 2020
Merged

checking extension before reading to check outputs#132
chrisjsewell merged 3 commits intoexecutablebooks:masterfrom
AakashGfude:checking-ext

Conversation

@AakashGfude
Copy link
Copy Markdown
Member

@AakashGfude AakashGfude commented Apr 6, 2020

Checking if the extension is ipynb before assuming it is a notebook and reading the cells for outputs.

@AakashGfude
Copy link
Copy Markdown
Member Author

AakashGfude commented Apr 6, 2020

Hey @chrisjsewell , do you know how to counter the following error causing CI build fail?
image

@AakashGfude
Copy link
Copy Markdown
Member Author

AakashGfude commented Apr 6, 2020

closes #130 .
Regarding files with different extensions but same name in toc, we can create a new issue.

chrisjsewell
chrisjsewell reviewed Apr 6, 2020
View reviewed changes
@chrisjsewell
Copy link
Copy Markdown
Member

chrisjsewell commented Apr 6, 2020

Hey @chrisjsewell , do you know how to counter the following error causing CI build fail?

Yeh weird, the token is supplied https://github.com/ExecutableBookProject/MyST-NB/blob/b64cc307b38c14db469e410434895f13f63773ff/.github/workflows/tests.yml#L51

But perhaps this only works if the PR is from a branch on this repo??

@chrisjsewell
Copy link
Copy Markdown
Member

chrisjsewell commented Apr 6, 2020

Ah I see there is an actual GitHub coveralls action: https://github.com/marketplace/actions/coveralls-github-action, that will hopefully fix this

@chrisjsewell
Copy link
Copy Markdown
Member

chrisjsewell commented Apr 6, 2020

I'll try this out in a separate PR in a min

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2020

Codecov Report

Merging #132 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   83.83%   83.85%   +0.02%     
==========================================
  Files           9        9              
  Lines         804      805       +1     
==========================================
+ Hits          674      675       +1     
  Misses        130      130
Flag Coverage Δ
#pytests 83.85% <100.00%> (+0.02%) ⬆️
Impacted Files Coverage Δ
myst_nb/cache.py 78.44% <100.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64709f8...122d273. Read the comment docs.

@chrisjsewell chrisjsewell linked an issue Apr 6, 2020 that may be closed by this pull request
Text-based notebooks being read as notebooks if jupyter_execute_notebooks=="auto" #130
Closed
@chrisjsewell chrisjsewell merged commit f31f9b5 into executablebooks:master Apr 6, 2020
phaustin pushed a commit to phaustin/MyST-NB that referenced this pull request Apr 7, 2020
@AakashGfude @phaustin
Check extension before reading file to check outputs (executablebooks…
b4ce9df 
…#132)
phaustin pushed a commit to phaustin/MyST-NB that referenced this pull request Apr 10, 2020
@AakashGfude @phaustin
Check extension before reading file to check outputs (executablebooks…
f532a9a 
…#132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisjsewell chrisjsewell chrisjsewell left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Text-based notebooks being read as notebooks if jupyter_execute_notebooks=="auto"

2 participants

@AakashGfude @chrisjsewell