Fix cache outputs retrieval for invalidated notebooks#108
Merged
Conversation
The previous implementation fails when an existing notebook is changed with failing code
Member
|
This all seems good to me - I'll hold off on merging in case @AakashGfude had a specific reason for the old pattern |
Member
|
@chrisjsewell Ooh, I was trying to get the list of records with the same URI and getting the latest record from it. Also, probably I thought of calling |
Member
|
Let's merge away then! |
phaustin
pushed a commit
to phaustin/MyST-NB
that referenced
this pull request
Apr 1, 2020
The previous implementation fails when an existing notebook is changed with failing code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation fails when an existing notebook is changed with failing code.
For example make the MyST-NB documentation, then add
raise Exceptionto a cell inuse/basic.ipynb, and re-run:With the new (simplified) code:
@AakashGfude is there any reason why you were trying to find the cache record by URI? (something you really shouldn't be trying to do 😬)