Conversation
Member
|
This LGTM - I think we should just give it a merge and @AakashGfude it would be awesome if made a follow-up PR with some testing instructions :-) |
Member
|
@choldgraf @chrisjsewell Gotcha. I will work on this tomorrow. |
phaustin
pushed a commit
to phaustin/MyST-NB
that referenced
this pull request
Apr 1, 2020
* Add development documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a page on package development, which @jstac can use to fix he's PR #104 😆
https://267-241268229-gh.circle-artifacts.com/0/html/develop/contributing.html
Also @AakashGfude, perhaps you would like to add a page about writing/running tests, as you have a pretty good understanding of that now 😁