Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

Conversation

@facs95
Copy link
Contributor

@facs95 facs95 commented Aug 26, 2022

Description

Minor fixes for eip712.
Support for optional parameters.
Time type
Support for basic types arrays.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* fixes for 19.0.1

* changelog

* changelog

Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
@fedekunze fedekunze merged commit 0b1a3ae into release/v0.19.x Aug 27, 2022
@fedekunze fedekunze deleted the eip-fix branch August 27, 2022 02:41
devon-chain pushed a commit to PundiAI/ethermint-old that referenced this pull request Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants