Merged
Conversation
This more clearly expresses the concept and also directly implies that they're run sequentially - i.e. users can change the order of the operations by simply reordering them in the config's yaml array.
Member
Author
|
@LionelOtt, the new version of the documentation is ready for review. Thanks for the comments you've already made on the code! I'll start going through them tomorrow and also complete the full description for this PR. |
LionelOtt
reviewed
Aug 14, 2024
LionelOtt
approved these changes
Aug 14, 2024
Contributor
LionelOtt
left a comment
There was a problem hiding this comment.
Looked over it and the restructuring and novel features look good to me.
d7c61f5 to
cf332c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces significant enhancements to the framework's generality and functionality. Wavemap's core library is now a standalone CMake C++ package, enabling its use on non-ROS platforms and paving the way for future integrations, including a Python API. Other major updates include generic spatial data structures, new path-planning utilities, and a plugin system for map operations.
Type of change
Users who created custom configs for a previous wavemap version will have to update these manually.
This PR changes the high-level structure of wavemap's configuration files, to accommodate new functionalities and improve user-friendliness. However, no functionality has been removed.
Detailed summary
This PR introduces major changes to wavemap's code base, focused on improving its generality, user-friendliness, and code quality. In terms of functionality, wavemap's spatial data structures can now be used to store arbitrary data types. We also added a wide range of new utilities, with a special focus on path-planning applications. In terms of code, wavemap can now be used as a pure CMake C++ library. This makes the framework usable without ROS and lays the groundwork for our upcoming Python API. Further improvements include a modular system to add and configure map operations, much like plugins. We already include new operations to publish the map in alternative formats (e.g. obstacle pointcloud) and perform local mapping, and expect to add many more in the future.
This PR addresses GH issues #25 and #59.
New features
Improvements
termination_heightBug fixes
Package changelogs
Testing
Unit tests
All unit tests are passing. Note that the C++ library's tests can now be run using GoogleTest standard mechanisms. For compatibility, we also configured the ROS1
wavemapinterface package to run the library's tests when called withcatkin test wavemap.End-to-end tests
We reran all the demos on an Intel desktop and AMD laptop. We did not notice issues or regressions.
Checklist: