Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ethpandaops/optimism-package
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.1.0
Choose a base ref
...
head repository: ethpandaops/optimism-package
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.2.0
Choose a head ref
  • 16 commits
  • 31 files changed
  • 9 contributors

Commits on Nov 26, 2024

  1. fix: readme (#93)

    barnabasbusa authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    1fb3de4 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. Configuration menu
    Copy the full SHA
    28d6a79 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. fix: Update Nethermind scripts for Holocene (#92)

    Recently we've added support for the upcoming Optimism hard-fork
    Holocene in Nethermind
    (NethermindEth/nethermind#7761) and the OP team
    suggested us to use OP's kurtosis package to test it.
    
    We found a couple of issues when trying to set up an enclave due to
    certain changes to other fork's timestamps which would trigger an error
    in Nethermind. To fix that, one of our developers (@flcl42) updated the
    `gen2spec.jq` script which fixes the above mentioned issue.
    
    Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
    emlautarom1 and barnabasbusa authored Dec 2, 2024
    Configuration menu
    Copy the full SHA
    50f0193 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2024

  1. Configuration menu
    Copy the full SHA
    01eccb4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    349d815 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    cd29b3b View commit details
    Browse the repository at this point in the history
  4. Update default network params (#102)

    The tagged versions won't work without a predeployed OPCM, which only
    exists on mainnet and Sepolia.
    mslipper authored Dec 4, 2024
    Configuration menu
    Copy the full SHA
    e0902cf View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2024

  1. fix: Readme (#103)

    barnabasbusa authored Dec 5, 2024
    Configuration menu
    Copy the full SHA
    0d60a9d View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2024

  1. feat: add option to deploy the package to an external layer 1 (#104)

    ## Description
    
    Introduce a way to deploy the OP contracts/stack rollup to an external
    L1 instead of deploying a local L1.
    
    This PR introduces a new struct called `external_l1_network_params` to
    define all the necessary parameters such as the network id, the EL/CL
    rpc urls, etc.
    
    ```yaml
    external_l1_network_params:
      network_id: "3151908"
      rpc_kind: standard
      el_rpc_url: http://el-1-geth-lighthouse:8545
      el_ws_url: ws://el-1-geth-lighthouse:8546
      cl_rpc_url: http://cl-1-lighthouse-geth:4000
      priv_key: "0xbcdf20249abf0ed6d944c0288fad489e33f66b3960d9e6229c1cd214ed3bbe31"
    ```
    
    - The default behaviour has not been changed.
    - The input parser and sanity check files have been updated to make sure
    users either specify the ethereum package args or the external l1 args
    and not both at the same time.
    - Some tests have been added in CI to test the new behaviour, for
    example:
    https://github.com/leovct/optimism-package/actions/runs/12180757633/job/33975816277
    leovct authored Dec 6, 2024
    Configuration menu
    Copy the full SHA
    a19a5fb View commit details
    Browse the repository at this point in the history
  2. fix: remove additional example from network_params (#107)

    Signed-off-by: Barnabas Busa <barnabas.busa@ethereum.org>
    barnabasbusa authored Dec 6, 2024
    Configuration menu
    Copy the full SHA
    b58e98e View commit details
    Browse the repository at this point in the history
  3. fix: sequencer forwarding (#106)

    ## Description
    
    Closes #86 
    
    Configure sequencer forwarding to send transactions to the sequencer EL
    RPC endpoint instead of the CL RPC endpoint.
    
    Nightly workflow:
    https://github.com/leovct/optimism-package/actions/runs/12199976016
    
    ## Test
    
    ```bash
    kurtosis run --enclave op --args-file .github/tests/op-geth.yaml .
    
    export ETH_RPC_URL=$(kurtosis port print op op-el-2-op-geth-hildr-op-kurtosis rpc)
    curl \
      --request POST \
      --url $ETH_RPC_URL \
      --header 'accept: application/json' \
      --header 'content-type: application/json' \
      --data '{"id":0,"jsonrpc":"2.0","method":"eth_sendRawTransaction","params":["0x02f8718320d5e480018476bb8201825208940000000000000000000000000000000000000000880de0b6b3a764000080c001a09322fe55a0a429fc26fc3703fea0e44298e28ac884afa448f1f9dd0ea6ac080ca07650448283d4afd481d7b690bb5251c75a7aca3a6e41d06cab49b0727218d074"]}'
    ```
    
    Without the fix:
    
    ```bash
    {"jsonrpc":"2.0","id":0,"error":{"code":-32601,"message":"the method eth_sendRawTransaction does not exist/is not available"}}
    ```
    
    With the fix:
    
    ```bash
    {"jsonrpc":"2.0","id":0,"result":"0x90dc459ccc7429d1cdef3c3e4e7caa069142312b65bfe45cd14b4ff8f6dcd803"}
    ```
    leovct authored Dec 6, 2024
    Configuration menu
    Copy the full SHA
    0505def View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2024

  1. Configuration menu
    Copy the full SHA
    9bd409e View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2024

  1. feat: integrate Rollup boost (#105)

    Option to add `rollup-boost` as an additional service. The rollup-boost
    image can be specified in mev_params.
    
    ---------
    
    Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
    avalonche and barnabasbusa authored Dec 11, 2024
    Configuration menu
    Copy the full SHA
    df0aa48 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2024

  1. style: Log keys/addresses for chain operator roles for Local L1 & rea…

    …dme updates (#108)
    
    * Log private keys and addresses for Chain Operator roles when running a
    local L1. Removed trace logs in bash script fund.sh since the relevant
    info is now logged. I note that the `l1_network` binding wasn't set at
    all in `main.star` and is now set to `local` for a local L1 network. The
    private key/addresses are needed when a transaction needs to be sent to
    the contract -- which is a likely step in executing a test locally in
    Kurtosis. See
    [here](ethereum-optimism/optimism#13192 (comment))
    * Log L1 faucet private key and address
    * Log L2 faucet private key and address (useful for running tx-fuzz)
    * Updates to readme with info on helpful kurtosis commands for
    inspecting local state.
    * Add sample config for geth/reth with custom batcher config
    
    Driven from the learnings of testing holocene hard fork chain split
    between `op-geth` and `op-reth` as noted in:
    ethereum-optimism/optimism#13192 (comment)
    
    The revised output from `fund.sh` locally is as follows:
    
    ```
    Collect keys, and fund addresses
    Command returned with exit code '0' and the following output:
    --------------------
    0x3be78a6b8544134adb22fa909bfb93ee69a9e2b755076d3d859455832adb9218
    0x0cf6c854e32a30be7c79b41d7841ab456b06530d31115ba651bb4bbe26545b5d
    0x721cd59d1901ff718f299f14c0ecd2bbfa39b9248cbdfaccaca415e008ea0cb9
    0xcdac4618e2128f1a3bc503ddc35e722896174681620ac7e41efa28c5a5f53414
    0x77c5e2210e89b2d2cfd591f29b47723789cd76c58b6dde603a58c820171d0097
    0xaa397e8c9d218413d130c38efe2666d15a73abdd604ae0411e4206c660eb9d62
    0xa9ad8b78b3b0ddbd41b75271d6d9bdbfbe7b60c58e937272a7255ad542542d28
    0xbb8c5f7490df7e2286aae608b7c2a1876b73164bde3d5bc9abf19590bcc464a5
    0x5db0f1227071a0a719a978f6fea60d63c6974bf114eaaa08a1cfb777b2b58e54
    0x924a64b99b825dcb1e88eb451ba90627a18c4f974d91fd4518704bd5ac49c197
    Wallet private key and addresses
    {
      "proposerPrivateKey": "0x9d77c0558ed6f31e7be16c2f45fd1f3ec3f66d20526b7fe3961872d38ac98fe7",
      "proposerAddress": "0xb0994E702b603df7191cd68E6544f99126135e34",
      "batcherPrivateKey": "0xb3d2d558e3491a3709b7c451100a0366b5872520c7aa020c17a0e7fa35b6a8df",
      "batcherAddress": "0xD3F2c5AFb2D76f5579F326b0cD7DA5F5a4126c35",
      "sequencerPrivateKey": "0x459f58fd8ef3d9123333514d0f2445153fc29ddc43be239356dad70f506475d9",
      "sequencerAddress": "0xbb900Cf56918A2639dAA90c3f7DC5DCD2f5B9935",
      "challengerPrivateKey": "0x717c53f6d6c266889465d78a885cd0a2e22d41f73e21fa1f07ba5849c82d79c3",
      "challengerAddress": "0xf08f610d1956CAAAb34f18e9e0A122E389496529",
      "l2ProxyAdminPrivateKey": "0x93be1ab4efe7633d951f19783912817a264f70889cc230e6015627695041744b",
      "l2ProxyAdminAddress": "0x21DD8D15472844b905E603Ddd48A485a630B233b",
      "l1ProxyAdminPrivateKey": "0xa8574059a5e36acd4d6ea03e90fe8b5233cc87222b0b396f9b1d6f3e5d6368fa",
      "l1ProxyAdminAddress": "0x39Dc844B8b461c6de6c572cad9585d9f5A8DEa6A",
      "baseFeeVaultRecipientPrivateKey": "0x227e712ee48868fff4651301e8f366bea05e822db3429470bbc7ed2ee045cb67",
      "baseFeeVaultRecipientAddress": "0x9ef74F0e58fdEf70c11E587A45c0a85A3258DCeA",
      "l1FeeVaultRecipientPrivateKey": "0xe6414f68c9f0d5e3470955a39c1af602a3132f709130fea6304f126a78b7f6aa",
      "l1FeeVaultRecipientAddress": "0xA7B30F9e99A248C6D623eaaD7bce81217Bb84038",
      "sequencerFeeVaultRecipientPrivateKey": "0xc11b0cec865b74505976f6c7fc5736a701f1cdf9e46aa72c02d51c0fe6ec3fed",
      "sequencerFeeVaultRecipientAddress": "0x15947bF05662caD8DF55f004c055939b574f18c0",
      "systemConfigOwnerPrivateKey": "0x28978385446dde6ce493da611d6c9ae6193d960c1cb73ecfb25800e9c9017f4c",
      "systemConfigOwnerAddress": "0x8e44fEbeaE9C2F2Bc89480aE8084328Badc496c2",
      "l1FaucetPrivateKey": "0xeaba42282ad33c8ef2524f07277c03a776d98ae19f581990ce75becb7cfa1c23",
      "l1FaucetAddress": "0x589A698b7b7dA0Bec545177D3963A2741105C7C9",
      "l2FaucetPrivateKey": "0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80",
      "l2FaucetAddress": "0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266"
    }
    ```
    
    ---------
    
    Co-authored-by: Vinod Damle <5338861+vdamle@users.noreply.github.com>
    vdamle and vdamle authored Dec 13, 2024
    Configuration menu
    Copy the full SHA
    6cbfdd3 View commit details
    Browse the repository at this point in the history
  2. chore: Fix lint and update README (#109)

    * fix lint error introduced in previous PR.
    * Update readme with instructions to run linter and also add tx-fuzz
    running instructions
    
    Co-authored-by: Vinod Damle <5338861+vdamle@users.noreply.github.com>
    vdamle and vdamle authored Dec 13, 2024
    Configuration menu
    Copy the full SHA
    e8fbe95 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2024

  1. chore(main): release 1.2.0 (#101)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ##
    [1.2.0](1.1.0...1.2.0)
    (2024-12-13)
    
    
    ### Features
    
    * add miner to op-geth
    ([#98](#98))
    ([01eccb4](01eccb4))
    * add miner to op-reth
    ([#99](#99))
    ([9bd409e](9bd409e))
    * add option to deploy the package to an external layer 1
    ([#104](#104))
    ([a19a5fb](a19a5fb))
    * integrate Rollup boost
    ([#105](#105))
    ([df0aa48](df0aa48))
    
    
    ### Bug Fixes
    
    * add miner as an api
    ([#97](#97))
    ([349d815](349d815))
    * image tag name
    ([#96](#96))
    ([28d6a79](28d6a79))
    * Readme
    ([#103](#103))
    ([0d60a9d](0d60a9d))
    * readme
    ([#93](#93))
    ([1fb3de4](1fb3de4))
    * remove additional example from network_params
    ([#107](#107))
    ([b58e98e](b58e98e))
    * sequencer forwarding
    ([#106](#106))
    ([0505def](0505def))
    * update default network params
    ([e0902cf](e0902cf))
    * Update Nethermind scripts for Holocene
    ([#92](#92))
    ([50f0193](50f0193))
    
    ---
    This PR was generated with [Release
    Please](https://github.com/googleapis/release-please). See
    [documentation](https://github.com/googleapis/release-please#release-please).
    
    Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
    EthPandaOpsBot and barnabasbusa authored Dec 16, 2024
    Configuration menu
    Copy the full SHA
    9c98e66 View commit details
    Browse the repository at this point in the history
Loading