support SLOT_DURATION_MS as replacement for deprecated SECONDS_PER_SLOT#606
Merged
barnabasbusa merged 4 commits intomasterfrom Mar 19, 2026
Merged
support SLOT_DURATION_MS as replacement for deprecated SECONDS_PER_SLOT#606barnabasbusa merged 4 commits intomasterfrom
barnabasbusa merged 4 commits intomasterfrom
Conversation
The consensus specs deprecated SECONDS_PER_SLOT in favor of SLOT_DURATION_MS (ethereum/consensus-specs#4926). The genesis generator has already removed SECONDS_PER_SLOT from config templates (ethpandaops/ethereum-genesis-generator#268). Replace all internal usage of SecondsPerSlot with SlotDurationMs to use millisecond precision throughout. The deprecated SECONDS_PER_SLOT YAML field is still parsed for backward compatibility with older configs and derived into SlotDurationMs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ddb279c to
e70e0f7
Compare
pk910
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SLOT_DURATION_MSfield toChainSpecConfigto support the new consensus spec fieldSecondsPerSlotfromSlotDurationMs / 1000when onlySLOT_DURATION_MSis present (new configs)SlotDurationMsfromSecondsPerSlot * 1000when onlySECONDS_PER_SLOTis present (backward compat)Related: ethereum/consensus-specs#4926, ethpandaops/ethereum-genesis-generator#268
Test plan
SLOT_DURATION_MS(new devnet configs)SECONDS_PER_SLOT(mainnet/older configs)🤖 Generated with Claude Code