Replace SECONDS_PER_SLOT with SLOT_DURATION_MS in specs/tests#4926
Merged
jtraglia merged 1 commit intoethereum:masterfrom Mar 2, 2026
Merged
Replace SECONDS_PER_SLOT with SLOT_DURATION_MS in specs/tests#4926jtraglia merged 1 commit intoethereum:masterfrom
SECONDS_PER_SLOT with SLOT_DURATION_MS in specs/tests#4926jtraglia merged 1 commit intoethereum:masterfrom
Conversation
686cc1c to
53391f6
Compare
4 tasks
nflaig
approved these changes
Feb 23, 2026
Member
nflaig
left a comment
There was a problem hiding this comment.
we completely removed any references from Lodestar a few months ago but I would suggest that clients still return SECONDS_PER_SLOT as part of their config until the next hard fork to avoid interop issues
53391f6 to
56b735d
Compare
Member
Author
|
We are cleaning up the config in other PRs so it makes sense to finally delete |
barnabasbusa
added a commit
to ethpandaops/ethereum-genesis-generator
that referenced
this pull request
Mar 6, 2026
Reflects ethereum/consensus-specs#4926 which removes the deprecated SECONDS_PER_SLOT config. All internal usage now derives seconds from SLOT_DURATION_MS where needed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
3 tasks
barnabasbusa
added a commit
to ethpandaops/dora
that referenced
this pull request
Mar 12, 2026
The consensus specs deprecated SECONDS_PER_SLOT in favor of SLOT_DURATION_MS (ethereum/consensus-specs#4926). The genesis generator has already removed SECONDS_PER_SLOT from config templates (ethpandaops/ethereum-genesis-generator#268). Add SlotDurationMs field and reconcile between the two fields after parsing for backward compatibility with older configs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
barnabasbusa
added a commit
to ethpandaops/dora
that referenced
this pull request
Mar 12, 2026
The consensus specs deprecated SECONDS_PER_SLOT in favor of SLOT_DURATION_MS (ethereum/consensus-specs#4926). The genesis generator has already removed SECONDS_PER_SLOT from config templates (ethpandaops/ethereum-genesis-generator#268). Replace all internal usage of SecondsPerSlot with SlotDurationMs to use millisecond precision throughout. The deprecated SECONDS_PER_SLOT YAML field is still parsed for backward compatibility with older configs and derived into SlotDurationMs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
barnabasbusa
added a commit
to ethpandaops/assertoor
that referenced
this pull request
Mar 25, 2026
SECONDS_PER_SLOT has been deprecated and removed from the consensus spec config (ethereum/consensus-specs#4926) in favor of SLOT_DURATION_MS. When CL nodes stop returning SECONDS_PER_SLOT, the ChainSpec field stays at zero, causing a divide-by-zero panic in ethwallclock when computing the current slot. Replace SecondsPerSlot (time.Duration) with SlotDurationMs (uint64) in ChainSpec to match the new spec field directly. Fall back to SECONDS_PER_SLOT for backwards compatibility with older genesis configs. Add a guard in InitWallclock to prevent the panic if neither value is available. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes the next step in removing
SECONDS_PER_SLOT. This config was deprecated but still used in a few places. It's time to fix these & remove the config.I find the current state of this PR to be a little ugly, but I think it would be best to review/merge this PR, then follow up with another PR which changes
Store.timetoStore.time_ms.