Skip to content
This repository was archived by the owner on Aug 2, 2021. It is now read-only.

swarm: release v0.4.2#1496

Merged
nonsense merged 3 commits intomasterfrom
update-changelog
Jun 28, 2019
Merged

swarm: release v0.4.2#1496
nonsense merged 3 commits intomasterfrom
update-changelog

Conversation

@nonsense
Copy link
Copy Markdown
Contributor

No description provided.

@nonsense nonsense requested review from acud and skylenet June 18, 2019 08:18
@nonsense nonsense added this to the 0.4.2 milestone Jun 18, 2019
@nonsense
Copy link
Copy Markdown
Contributor Author

@skylenet @acud not sure how we want to handle the CHANGELOG.md , but I see a few options:

  • I don't want the updates to be directly part of the PRs, because then we'd be conflicting a lot on this file.
  • developers could just push a commit to this branch after their PRs are merged, and prior to a release we merge this?
  • whoever is responsible for a given release, scans Github PRs based on the milestore and copies most/all PRs here before making a release...

Something like that. Ideas?

@skylenet
Copy link
Copy Markdown
Contributor

skylenet commented Jun 19, 2019

For me it's mandatory that the release manager reviews and updates the changelog.

For the rest: I kinda thing it's nice if someone else updates the release notes (either with a separate PR or within the same PR of the bug/feature), specially if they introduced a change that requires some additional notes there.

@nonsense nonsense changed the title CHANGELOG: reflect latest merged PRs CHANGELOG: reflect latest merged PRs ; version: set 0.4.2 to stable Jun 28, 2019
@nonsense nonsense changed the title CHANGELOG: reflect latest merged PRs ; version: set 0.4.2 to stable swarm: release v0.4.2 Jun 28, 2019
@nonsense nonsense merged commit bef5113 into master Jun 28, 2019
@acud acud deleted the update-changelog branch June 28, 2019 09:27
vojtechsimetka added a commit that referenced this pull request Jul 9, 2019
* master:
  network/newstream: new stream! protocol base implementation (#1500)
  swarm: fix bzz_info.port when using dynamic port allocation (#1537)
  cmd/swarm: make bzzaccount flag optional and add bzzkeyhex flag (#1531)
  cmd/swarm: remove separate function to parse env vars (#1536)
  network/bitvector: Multibit set/unset + string rep (#1530)
  swarm: 0.4.3 unstable (#1526)
  travis: also build on release tags (#1527)
  swarm: release v0.4.2 (#1496)
  network: bump bzz stream hive (#1522)
  docker: update ca-certificates file (#1525)
  Add swarm guide to /docs (#1513)
  network/simulation: Add ExecAdapter capability to swarm simulations (#1503)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants