Skip to content

Feat/op759/call with value#997

Closed
smartcontracts wants to merge 14 commits intoregenesis/0.4.0from
feat/OP759/call-with-value
Closed

Feat/op759/call with value#997
smartcontracts wants to merge 14 commits intoregenesis/0.4.0from
feat/OP759/call-with-value

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts commented Jun 2, 2021

Description
WIP, tracking this in a PR for clarity.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jun 2, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 80e96b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ben-chain and others added 4 commits June 1, 2021 21:56
@ben-chain @smartcontracts
feat(contracts): add ovmCALL-types with native value
9147e60 
* add ovmCALLVALUE context

* add ovmBALANCE

* test success and revert cases

* test empty contract case

* chore: lint
@ben-chain @smartcontracts
test(integration-tests): ovmCALL-types with value (compiler and wrapper)
62e4ff6 
* fix ovmDELEGATECALL type, update tests

* add ovmSELFBALANCE

* fix ovmDELEGATECALL jumping to CALL

* chore: lint
@ben-chain @smartcontracts
fix(contracts): account for intrinsic gas of OVM_ETH sends
a243c96
@smartcontracts
fix merge conflict bug
d10cc19
@smartcontracts smartcontracts force-pushed the feat/OP759/call-with-value branch from 462cb6b to d10cc19 Compare June 2, 2021 01:56
@ben-chain ben-chain force-pushed the feat/OP759/call-with-value branch from 65e3702 to cba3f77 Compare June 3, 2021 13:27
@github-actions github-actions bot added the A-geth label Jun 3, 2021
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 3, 2021 •
edited
Loading

Codecov Report

Merging #997 (80e96b3) into regenesis/0.4.0 (0887367) will decrease coverage by 0.62%.
The diff coverage is 64.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           regenesis/0.4.0     #997      +/-   ##
===================================================
- Coverage            86.17%   85.55%   -0.63%     
===================================================
  Files                   50       51       +1     
  Lines                 1881     1924      +43     
  Branches               297      302       +5     
===================================================
+ Hits                  1621     1646      +25     
- Misses                 260      278      +18
Impacted Files Coverage Δ
...libraries/wrappers/Lib_ExecutionManagerWrapper.sol 62.50% <0.00%> (-24.46%) ⬇️
...imistic-ethereum/libraries/utils/Lib_MathUtils.sol 75.00% <75.00%> (ø)
...ic-ethereum/OVM/execution/OVM_ExecutionManager.sol 74.56% <75.75%> (+0.04%) ⬆️
...ethereum/OVM/accounts/OVM_ECDSAContractAccount.sol 93.75% <100.00%> (-0.70%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0887367...80e96b3. Read the comment docs.

@maurelian maurelian self-requested a review June 4, 2021 15:23
snario
snario reviewed Jun 7, 2021
View reviewed changes
integration-tests/hardhat.config.ts
solidity: '0.7.6',
ovm: {
solcVersion: '0.7.6',
solcVersion: '0.7.6-experimental_callvalue',
Copy link
Copy Markdown
Contributor

@snario snario Jun 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder we have to bump this when preparing for release.

@tynes
Copy link
Copy Markdown
Contributor

tynes commented Jun 7, 2021

@smartcontracts any progress updates on this?

tynes
tynes reviewed Jun 8, 2021
View reviewed changes
packages/contracts/contracts/optimistic-ethereum/libraries/utils/Lib_MathUtils.sol

/**
* @title Lib_MathUtils
*/
Copy link
Copy Markdown
Contributor

@tynes tynes Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a openzeppelin Math.min that is already a dependency

@ben-chain ben-chain mentioned this pull request Jun 8, 2021
Merged
3 tasks
@ben-chain
Copy link
Copy Markdown
Collaborator

ben-chain commented Jun 8, 2021

closing in favor of #1038 so I can be updating the status/description/etc as the PR owner.

@ben-chain ben-chain closed this Jun 8, 2021
@smartcontracts smartcontracts deleted the feat/OP759/call-with-value branch June 23, 2021 21:45
theochap pushed a commit that referenced this pull request Dec 10, 2025
@clabby
fix(ci): Action tests (#997)
f0a7bfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes left review comments

@maurelian maurelian Awaiting requested review from maurelian

+1 more reviewer

@snario snario snario left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@smartcontracts @codecov-commenter @tynes @ben-chain @snario @K-Ho