Skip to content

feat[ci]: parallelize integration, example, and sync tests#972

Closed
annieke wants to merge 6 commits intodevelopfrom
ci/parallelize-examples
Closed

feat[ci]: parallelize integration, example, and sync tests#972
annieke wants to merge 6 commits intodevelopfrom
ci/parallelize-examples

Conversation

@annieke
Copy link
Copy Markdown
Contributor

@annieke annieke commented May 27, 2021

Description
Make integration testing more efficient by parallelizing the 3 test suites.

Additional context
following up on #913

Metadata

  • OP-810

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 27, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 480fef5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 27, 2021 •
edited
Loading

Codecov Report

Merging #972 (93ee3a2) into develop (d168005) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #972   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d168005...93ee3a2. Read the comment docs.

annieke
annieke commented May 28, 2021
View reviewed changes
@annieke annieke force-pushed the ci/parallelize-examples branch from 9ab5bf4 to 9e352d4 Compare May 28, 2021 04:29
@annieke annieke marked this pull request as ready for review May 28, 2021 04:46
@annieke annieke requested review from gakonst and snario May 28, 2021 04:47
gakonst
gakonst suggested changes May 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The work flows still take many minutes to run because the load-images step is not finding the tarballs

@annieke annieke marked this pull request as draft May 28, 2021 16:40
@annieke annieke force-pushed the ci/parallelize-examples branch 2 times, most recently from 20659d3 to 9a048f5 Compare May 28, 2021 18:14
@annieke annieke marked this pull request as ready for review May 28, 2021 18:14
@annieke annieke requested a review from gakonst May 28, 2021 18:40
gakonst
gakonst suggested changes May 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@gakonst gakonst left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does what we want, but it seems to be making things slower due to having to save/upload & download/load the images...If this does not improve our CI times let's hold on it. I've opened #989 to enable the sync tests on CI.

@snario
Copy link
Copy Markdown
Contributor

snario commented Jun 1, 2021

Curious if you considered using the caching strategy Docker proposes here?

@annieke
Copy link
Copy Markdown
Contributor Author

annieke commented Jun 2, 2021

@snario just poked around some docs and i think for us to share images between jobs (necessary for parallelizing the tests), the uploading artifacts part is still necessary, and the caching just helps with the build part: docker/build-push-action#225 let me know if your investigations yield any further results! going to mark this as draft until then

@annieke annieke marked this pull request as draft June 2, 2021 01:22
@gakonst gakonst force-pushed the ci/parallelize-examples branch from a9990f7 to 2e49a43 Compare June 2, 2021 10:32
@gakonst gakonst force-pushed the ci/parallelize-examples branch from 2e49a43 to 480fef5 Compare June 2, 2021 13:07
@annieke annieke mentioned this pull request Jun 2, 2021
Merged
@annieke annieke closed this Jun 7, 2021
@smartcontracts smartcontracts deleted the ci/parallelize-examples branch June 23, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karlfloersch karlfloersch Awaiting requested review from karlfloersch

@tynes tynes Awaiting requested review from tynes

@snario snario Awaiting requested review from snario

1 more reviewer

@gakonst gakonst gakonst requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-ops Area: ops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@annieke @codecov-commenter @snario @gakonst