Conversation
|
Codecov Report
@@ Coverage Diff @@
## develop #989 +/- ##
========================================
Coverage 82.21% 82.21%
========================================
Files 48 48
Lines 1895 1895
Branches 303 303
========================================
Hits 1558 1558
Misses 337 337 Continue to review full report at Codecov.
|
|
i'm updating the branch here |
|
I like the idea but it looks like the path to the |
annieke
left a comment
There was a problem hiding this comment.
this is where i want to eventually move to! i think 2 issues right now:
- running the tests in docker also gives me this
spawn docker-compose ENOENTerror locally, which i think is from trying to use docker-compose within docker. haven't tried too hard to debug it, because - sync tests will always fail when ran with integration tests right now, since erc20 deploys + transfers produce mismatched stateroots
so as of now the simplest way is still to run sync tests in their own workflow, i'll try out the other solution to see if it's faster #972 (comment)
|
Closing given Annie is on it. I think we should figure out what causes the mismatched state roots before enabling the tests (independently of having it in the same or other workflow, since otherwise the test would give us false confidence) |
Enables running the sync tests introduced in #913 on CI by moving them under the
test/directory.