🦋 Changeset detected

Latest commit: 12c2d09

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Codecov Report

Merging #969 (e781bf4) into develop (77108d3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #969   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77108d3...e781bf4. Read the comment docs.

So far so good - does this also need changes on the rollup client?

I believe this is the change:

type decoded struct {
	Signature signature       `json:"sig"`
	Value     hexutil.Uint64  `json:"value"`
	GasLimit  uint64          `json:"gasLimit,string"`
	GasPrice  uint64          `json:"gasPrice"`
	Nonce     uint64          `json:"nonce"`
	Target    *common.Address `json:"target"`
	Data      hexutil.Bytes   `json:"data"`
}

It does seem to be working in the integration tests so perhaps its not needed?

@smartcontracts Could you add a changeset?

Do not merge without a changeset

Running some load tests right now, will get a changeset here in about 10 mins

We currently do not have tests for replicas, I'm syncing a replica with this now and observing it working after 989a6eb

Getting a replica sync test is a high priority cc @annieke @snario