fix[hardhat-ovm]: use correct url when creating ethers object#938
Merged
fix[hardhat-ovm]: use correct url when creating ethers object#938
Conversation
🦋 Changeset detectedLatest commit: 67e74f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #938 +/- ##
========================================
Coverage 82.21% 82.21%
========================================
Files 48 48
Lines 1895 1895
Branches 303 303
========================================
Hits 1558 1558
Misses 337 337 Continue to review full report at Codecov.
|
gakonst
approved these changes
May 23, 2021
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
…um-optimism#938) * fix[hardhat-ovm]: use correct url when creating ethers object * chore: add changeset * chore: rename changeset Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For some reason we were using the completely incorrect URL when modifying the
hardhat-ethersobject. I don't know if this was an error on our part or some sort of dependency that broke, so using||to remain backwards compatible if it indeed was an updated dependency. Also moves the step where we update the provider to the very end of the modification code so we can avoid weird issues when overridinggetSigners.Metadata