Skip to content

ci: run examples and integration tests in parallel#891

Closed
gakonst wants to merge 3 commits intodevelopfrom
ci/parallelize-examples
Closed

ci: run examples and integration tests in parallel#891
gakonst wants to merge 3 commits intodevelopfrom
ci/parallelize-examples

Conversation

@gakonst
Copy link
Copy Markdown
Contributor

@gakonst gakonst commented May 17, 2021

As title

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented May 17, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 51f35a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added A-ci A-ops Area: ops labels May 17, 2021
@gakonst gakonst force-pushed the ci/parallelize-examples branch 2 times, most recently from 4d77ef4 to 71e3354 Compare May 17, 2021 19:05
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 17, 2021 •
edited
Loading

Codecov Report

Merging #891 (51f35a0) into develop (dcb538d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #891   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files           48       48           
  Lines         1895     1895           
  Branches       303      303           
========================================
  Hits          1558     1558           
  Misses         337      337

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb538d...51f35a0. Read the comment docs.

tynes
tynes reviewed May 17, 2021
View reviewed changes
ops/scripts/load-images.sh Outdated
Copy link
Copy Markdown
Contributor

@tynes tynes May 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have a #!/bin/bash at the top, same as the other script

tynes
tynes reviewed May 17, 2021
View reviewed changes
.github/workflows/integration.yml Outdated
Copy link
Copy Markdown
Contributor

@tynes tynes May 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this collide with other PRs? ie another PR is submitted that saves images and then retriggering the CI causes different images to be used?

Copy link
Copy Markdown
Contributor Author

@gakonst gakonst May 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, each one is in its own unique runner, no?

@tynes
Copy link
Copy Markdown
Contributor

tynes commented May 17, 2021

We will need to update the required checks to include the new name - it is no longer integration but instead integration_tests. We should also add one for the examples. The integration check above will wait forever

@gakonst gakonst force-pushed the ci/parallelize-examples branch from 5215aa2 to 51f35a0 Compare May 20, 2021 13:04
@gakonst gakonst closed this May 23, 2021
@gakonst gakonst deleted the ci/parallelize-examples branch May 23, 2021 10:58
@annieke annieke mentioned this pull request May 27, 2021
Merged
theochap pushed a commit that referenced this pull request Dec 10, 2025
@github-actions
chore: release v0.2.2 (#891)
7c49548 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tynes tynes tynes left review comments

@karlfloersch karlfloersch Awaiting requested review from karlfloersch

Assignees

No one assigned

Labels

A-ops Area: ops

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gakonst @codecov-commenter @tynes